From d70bd5a62f66955d277b33d3f091f89b03118c59 Mon Sep 17 00:00:00 2001
From: deraadt <>
Date: Sat, 31 May 2014 18:49:47 +0000
Subject: copy a comment placed in other files; req from miod

---
 src/lib/libcrypto/ec/ecp_nistp224.c         | 4 +++-
 src/lib/libssl/src/crypto/ec/ecp_nistp224.c | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/lib/libcrypto/ec/ecp_nistp224.c b/src/lib/libcrypto/ec/ecp_nistp224.c
index afe25853e6..17777f517b 100644
--- a/src/lib/libcrypto/ec/ecp_nistp224.c
+++ b/src/lib/libcrypto/ec/ecp_nistp224.c
@@ -1437,9 +1437,11 @@ ec_GFp_nistp224_points_mul(const EC_GROUP * group, EC_POINT * r,
 		}
 		secrets = calloc(num_points, sizeof(felem_bytearray));
 		pre_comp = calloc(num_points, 17 * 3 * sizeof(felem));
-		if (mixed)
+		if (mixed) {
+			/* XXX should do more int overflow checking */
 			tmp_felems = reallocarray(NULL,
 			    (num_points * 17 + 1), sizeof(felem));
+		}
 		if ((secrets == NULL) || (pre_comp == NULL) || (mixed && (tmp_felems == NULL))) {
 			ECerr(EC_F_EC_GFP_NISTP224_POINTS_MUL, ERR_R_MALLOC_FAILURE);
 			goto err;
diff --git a/src/lib/libssl/src/crypto/ec/ecp_nistp224.c b/src/lib/libssl/src/crypto/ec/ecp_nistp224.c
index afe25853e6..17777f517b 100644
--- a/src/lib/libssl/src/crypto/ec/ecp_nistp224.c
+++ b/src/lib/libssl/src/crypto/ec/ecp_nistp224.c
@@ -1437,9 +1437,11 @@ ec_GFp_nistp224_points_mul(const EC_GROUP * group, EC_POINT * r,
 		}
 		secrets = calloc(num_points, sizeof(felem_bytearray));
 		pre_comp = calloc(num_points, 17 * 3 * sizeof(felem));
-		if (mixed)
+		if (mixed) {
+			/* XXX should do more int overflow checking */
 			tmp_felems = reallocarray(NULL,
 			    (num_points * 17 + 1), sizeof(felem));
+		}
 		if ((secrets == NULL) || (pre_comp == NULL) || (mixed && (tmp_felems == NULL))) {
 			ECerr(EC_F_EC_GFP_NISTP224_POINTS_MUL, ERR_R_MALLOC_FAILURE);
 			goto err;
-- 
cgit v1.2.3-55-g6feb