From d831c78b3e48383635e9bfa30710637001e9782d Mon Sep 17 00:00:00 2001 From: beck <> Date: Wed, 15 Jul 2015 17:13:17 +0000 Subject: Fix possible 32 byte buffer overrun, found by coverity, CID 78869 ok miod@ --- src/lib/libcrypto/gost/gostr341194.c | 4 ++-- src/lib/libssl/src/crypto/gost/gostr341194.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/libcrypto/gost/gostr341194.c b/src/lib/libcrypto/gost/gostr341194.c index 34ca504bb2..32c166aefa 100644 --- a/src/lib/libcrypto/gost/gostr341194.c +++ b/src/lib/libcrypto/gost/gostr341194.c @@ -1,4 +1,4 @@ -/* $OpenBSD: gostr341194.c,v 1.3 2014/12/07 16:33:51 jsing Exp $ */ +/* $OpenBSD: gostr341194.c,v 1.4 2015/07/15 17:13:17 beck Exp $ */ /* * Copyright (c) 2014 Dmitry Eremin-Solenikov * Copyright (c) 2005-2006 Cryptocom LTD @@ -238,7 +238,7 @@ GOSTR341194_Final(unsigned char *md, GOSTR341194_CTX * c) unsigned char T[32]; if (c->num > 0) { - memset(p + c->num, 0, 32); + memset(p + c->num, 0, 32 - c->num); hash_step(c, c->H, p); add_blocks(32, c->S, p); } diff --git a/src/lib/libssl/src/crypto/gost/gostr341194.c b/src/lib/libssl/src/crypto/gost/gostr341194.c index 34ca504bb2..32c166aefa 100644 --- a/src/lib/libssl/src/crypto/gost/gostr341194.c +++ b/src/lib/libssl/src/crypto/gost/gostr341194.c @@ -1,4 +1,4 @@ -/* $OpenBSD: gostr341194.c,v 1.3 2014/12/07 16:33:51 jsing Exp $ */ +/* $OpenBSD: gostr341194.c,v 1.4 2015/07/15 17:13:17 beck Exp $ */ /* * Copyright (c) 2014 Dmitry Eremin-Solenikov * Copyright (c) 2005-2006 Cryptocom LTD @@ -238,7 +238,7 @@ GOSTR341194_Final(unsigned char *md, GOSTR341194_CTX * c) unsigned char T[32]; if (c->num > 0) { - memset(p + c->num, 0, 32); + memset(p + c->num, 0, 32 - c->num); hash_step(c, c->H, p); add_blocks(32, c->S, p); } -- cgit v1.2.3-55-g6feb