From dedace976f6f0b10e4b1548a628f5a724c541101 Mon Sep 17 00:00:00 2001 From: tb <> Date: Fri, 9 Nov 2018 04:20:27 +0000 Subject: Avoid leaking memory that was already allocated in ASN1_item_new(). From Ben L --- src/lib/libcrypto/asn1/evp_asn1.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/lib/libcrypto/asn1/evp_asn1.c b/src/lib/libcrypto/asn1/evp_asn1.c index 4d616e2b34..4b7ebbb022 100644 --- a/src/lib/libcrypto/asn1/evp_asn1.c +++ b/src/lib/libcrypto/asn1/evp_asn1.c @@ -1,4 +1,4 @@ -/* $OpenBSD: evp_asn1.c,v 1.22 2018/11/09 03:42:30 tb Exp $ */ +/* $OpenBSD: evp_asn1.c,v 1.23 2018/11/09 04:20:27 tb Exp $ */ /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) * All rights reserved. * @@ -137,12 +137,8 @@ ASN1_TYPE_set_int_octetstring(ASN1_TYPE *at, long num, const unsigned char *data if ((ios = (ASN1_int_octetstring *)ASN1_item_new( &ASN1_INT_OCTETSTRING_it)) == NULL) goto err; - if ((ios->num = ASN1_INTEGER_new()) == NULL) - goto err; if (!ASN1_INTEGER_set(ios->num, num)) goto err; - if ((ios->value = ASN1_OCTET_STRING_new()) == NULL) - goto err; if (!ASN1_OCTET_STRING_set(ios->value, data, len)) goto err; -- cgit v1.2.3-55-g6feb