From e1d97f672bb21109e95b3a91fd67865f61ec96ca Mon Sep 17 00:00:00 2001 From: deraadt <> Date: Wed, 25 Sep 1996 08:17:31 +0000 Subject: nls buffers are NL_TEXTMAX long -- not a security hole; netbsd pr#2780, mike.long@analog.com --- src/lib/libc/string/__strsignal.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'src/lib/libc/string/__strsignal.c') diff --git a/src/lib/libc/string/__strsignal.c b/src/lib/libc/string/__strsignal.c index 5a424bfde2..53c9e59e59 100644 --- a/src/lib/libc/string/__strsignal.c +++ b/src/lib/libc/string/__strsignal.c @@ -32,7 +32,7 @@ */ #if defined(LIBC_SCCS) && !defined(lint) -static char *rcsid = "$OpenBSD: __strsignal.c,v 1.3 1996/09/16 05:43:39 tholo Exp $"; +static char *rcsid = "$OpenBSD: __strsignal.c,v 1.4 1996/09/25 08:17:31 deraadt Exp $"; #endif /* LIBC_SCCS and not lint */ #ifdef NLS @@ -79,18 +79,20 @@ __strsignal(num, buf) signum = num; /* convert to unsigned */ if (signum < NSIG) { #ifdef NLS - strcpy(buf, catgets(catd, 2, signum, - (char *)sys_siglist[signum])); + strncpy(buf, catgets(catd, 2, signum, + (char *)sys_siglist[signum]), NL_TEXTMAX-1); + buf[NL_TEXTMAX-1] = '\0'; #else return((char *)sys_siglist[signum]); #endif } else { #ifdef NLS - strcpy(buf, catgets(catd, 1, 0xffff, UPREFIX)); + strncpy(buf, catgets(catd, 1, 0xffff, UPREFIX), NL_TEXTMAX-1); + buf[NL_TEXTMAX-1] = '\0'; #else strcpy(buf, UPREFIX); #endif - strcat(buf, itoa(signum)); + strncat(buf, itoa(signum), NL_TEXTMAX-strlen(buf)-1); } #ifdef NLS -- cgit v1.2.3-55-g6feb