From abd9b10898e82011a65d8e8fca56bf56532edd69 Mon Sep 17 00:00:00 2001 From: deraadt <> Date: Fri, 30 May 2014 06:22:57 +0000 Subject: more: no need for null check before free ok tedu guenther --- src/lib/libcrypto/asn1/a_int.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'src/lib/libcrypto/asn1/a_int.c') diff --git a/src/lib/libcrypto/asn1/a_int.c b/src/lib/libcrypto/asn1/a_int.c index 0559cce384..881f08a766 100644 --- a/src/lib/libcrypto/asn1/a_int.c +++ b/src/lib/libcrypto/asn1/a_int.c @@ -256,8 +256,7 @@ c2i_ASN1_INTEGER(ASN1_INTEGER **a, const unsigned char **pp, long len) memcpy(s, p, (int)len); } - if (ret->data != NULL) - free(ret->data); + free(ret->data); ret->data = s; ret->length = (int)len; if (a != NULL) @@ -324,8 +323,7 @@ d2i_ASN1_UINTEGER(ASN1_INTEGER **a, const unsigned char **pp, long length) p += len; } - if (ret->data != NULL) - free(ret->data); + free(ret->data); ret->data = s; ret->length = (int)len; if (a != NULL) @@ -350,8 +348,7 @@ ASN1_INTEGER_set(ASN1_INTEGER *a, long v) a->type = V_ASN1_INTEGER; if (a->length < (int)(sizeof(long) + 1)) { - if (a->data != NULL) - free(a->data); + free(a->data); a->data = calloc(1, sizeof(long) + 1); } if (a->data == NULL) { -- cgit v1.2.3-55-g6feb