From 15e0442b8cfbbc095af4db97db7cd2b6d8dc23d0 Mon Sep 17 00:00:00 2001 From: guenther <> Date: Sat, 19 Apr 2014 11:46:39 +0000 Subject: We'll interpret a (void) cast on snprintf() to mean it's been verified that truncation is either desirable, not an issue, or is detected and handled later ok deraadt@ --- src/lib/libcrypto/err/err.c | 8 ++++---- src/lib/libcrypto/err/err_prn.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src/lib/libcrypto/err') diff --git a/src/lib/libcrypto/err/err.c b/src/lib/libcrypto/err/err.c index 0672477cc8..c4192c6bfa 100644 --- a/src/lib/libcrypto/err/err.c +++ b/src/lib/libcrypto/err/err.c @@ -842,13 +842,13 @@ void ERR_error_string_n(unsigned long e, char *buf, size_t len) rs=ERR_reason_error_string(e); if (ls == NULL) - (void) snprintf(lsbuf, sizeof(lsbuf), "lib(%lu)", l); + snprintf(lsbuf, sizeof(lsbuf), "lib(%lu)", l); if (fs == NULL) - (void) snprintf(fsbuf, sizeof(fsbuf), "func(%lu)", f); + snprintf(fsbuf, sizeof(fsbuf), "func(%lu)", f); if (rs == NULL) - (void) snprintf(rsbuf, sizeof(rsbuf), "reason(%lu)", r); + snprintf(rsbuf, sizeof(rsbuf), "reason(%lu)", r); - (void) snprintf(buf, len,"error:%08lX:%s:%s:%s", e, ls?ls:lsbuf, + snprintf(buf, len,"error:%08lX:%s:%s:%s", e, ls?ls:lsbuf, fs?fs:fsbuf, rs?rs:rsbuf); if (strlen(buf) == len-1) { diff --git a/src/lib/libcrypto/err/err_prn.c b/src/lib/libcrypto/err/err_prn.c index 7374c0abe7..be4d5de2d2 100644 --- a/src/lib/libcrypto/err/err_prn.c +++ b/src/lib/libcrypto/err/err_prn.c @@ -79,7 +79,7 @@ void ERR_print_errors_cb(int (*cb)(const char *str, size_t len, void *u), while ((l=ERR_get_error_line_data(&file,&line,&data,&flags)) != 0) { ERR_error_string_n(l, buf, sizeof buf); - (void) snprintf(buf2, sizeof(buf2), "%lu:%s:%s:%d:%s\n", es, buf, + snprintf(buf2, sizeof(buf2), "%lu:%s:%s:%d:%s\n", es, buf, file, line, (flags & ERR_TXT_STRING) ? data : ""); if (cb(buf2, strlen(buf2), u) <= 0) break; /* abort outputting the error report */ -- cgit v1.2.3-55-g6feb