From e44d7af88579ebe18a2d8ef57242b067993706b1 Mon Sep 17 00:00:00 2001
From: tb <>
Date: Wed, 13 Mar 2019 20:34:00 +0000
Subject: Fix a number of ASN1_INTEGER vs ASN1_STRING mixups coming from the
 mechanical M_ASN1 macro expansion.  The ASN1_INTEGER_cmp function takes signs
 into account while ASN1_STRING_cmp doesn't. The mixups mostly involve
 serialNumbers, which, in principle, should be positive. However, it is
 unclear whether that is checked or enforced anywhere in the code, so these
 are probably bugs.

Patch from Holger Mikolon
ok jsing
---
 src/lib/libcrypto/x509v3/v3_sxnet.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/lib/libcrypto/x509v3/v3_sxnet.c')

diff --git a/src/lib/libcrypto/x509v3/v3_sxnet.c b/src/lib/libcrypto/x509v3/v3_sxnet.c
index 53db28248a..400bc26346 100644
--- a/src/lib/libcrypto/x509v3/v3_sxnet.c
+++ b/src/lib/libcrypto/x509v3/v3_sxnet.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: v3_sxnet.c,v 1.21 2018/05/13 15:03:01 tb Exp $ */
+/* $OpenBSD: v3_sxnet.c,v 1.22 2019/03/13 20:34:00 tb Exp $ */
 /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
  * project 1999.
  */
@@ -376,7 +376,7 @@ SXNET_get_id_INTEGER(SXNET *sx, ASN1_INTEGER *zone)
 
 	for (i = 0; i < sk_SXNETID_num(sx->ids); i++) {
 		id = sk_SXNETID_value(sx->ids, i);
-		if (!ASN1_STRING_cmp(id->zone, zone))
+		if (!ASN1_INTEGER_cmp(id->zone, zone))
 			return id->user;
 	}
 	return NULL;
-- 
cgit v1.2.3-55-g6feb