From de48c77a08514ed654e05e710444452ffab6d0aa Mon Sep 17 00:00:00 2001
From: deraadt <>
Date: Sat, 7 Jun 2014 22:23:12 +0000
Subject: 
 http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=2016265dfbab162ec30718b5e7480add42598158
 Don't know the full story, but it looks like a "can't do random perfectly, so
 do it god awful" problem was found in 2013, and replaced with "only do it
 badly if a flag is set".  New flags (SSL_MODE_SEND_SERVERHELLO_TIME and
 SSL_MODE_SEND_SERVERHELLO_TIME) were added [Ben Laurie?] to support the old
 scheme of "use time_t for first 4 bytes of the random buffer".

Nothing uses these flags [ecosystem scan by sthen]

Fully discourage use of these flags in the future by removing
support & definition of them.  The buflen < 4 check is also interesting,
because no entropy would be returned.  No callers passed such small
buffers.
ok miod sthen
---
 src/lib/libssl/s3_clnt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

(limited to 'src/lib/libssl/s3_clnt.c')

diff --git a/src/lib/libssl/s3_clnt.c b/src/lib/libssl/s3_clnt.c
index f2c7dd2442..45dfb64f92 100644
--- a/src/lib/libssl/s3_clnt.c
+++ b/src/lib/libssl/s3_clnt.c
@@ -674,9 +674,7 @@ ssl3_client_hello(SSL *s)
 		/* else use the pre-loaded session */
 
 		p = s->s3->client_random;
-
-		if (ssl_fill_hello_random(s, 0, p, SSL3_RANDOM_SIZE) <= 0)
-			goto err;
+		RAND_pseudo_bytes(p, SSL3_RANDOM_SIZE);
 
 		/* Do the message type and length last */
 		d = p = &(buf[4]);
-- 
cgit v1.2.3-55-g6feb