From 2b561cb0e87f2ee535e8c64907883cd275ad3fec Mon Sep 17 00:00:00 2001 From: deraadt <> Date: Tue, 2 May 2017 03:59:45 +0000 Subject: use freezero() instead of memset/explicit_bzero + free. Substantially reduces conditional logic (-218, +82). MOD_EXP_CTIME_MIN_CACHE_LINE_WIDTH cache alignment calculation bn/bn_exp.c wasn'tt quite right. Two other tricky bits with ASN1_STRING_FLAG_NDEF and BN_FLG_STATIC_DATA where the condition cannot be collapsed completely. Passes regress. ok beck --- src/lib/libtls/tls_config.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/lib/libtls') diff --git a/src/lib/libtls/tls_config.c b/src/lib/libtls/tls_config.c index 65063117e2..3945da75ac 100644 --- a/src/lib/libtls/tls_config.c +++ b/src/lib/libtls/tls_config.c @@ -1,4 +1,4 @@ -/* $OpenBSD: tls_config.c,v 1.38 2017/04/30 02:10:22 jsing Exp $ */ +/* $OpenBSD: tls_config.c,v 1.39 2017/05/02 03:59:45 deraadt Exp $ */ /* * Copyright (c) 2014 Joel Sing * @@ -188,9 +188,7 @@ tls_config_load_file(struct tls_error *error, const char *filetype, fail: if (fd != -1) close(fd); - if (*buf != NULL) - explicit_bzero(*buf, *len); - free(*buf); + freezero(*buf, *len); *buf = NULL; *len = 0; -- cgit v1.2.3-55-g6feb