From 1fafed06aeab0e0177e46136e9f456587a2fd1b3 Mon Sep 17 00:00:00 2001 From: miod <> Date: Sat, 5 Nov 2016 10:47:16 +0000 Subject: Stop abusing the ternary operator to decide which function to call in a return statement. ok beck@ jsing@ --- src/lib/libcrypto/bn/bn_mod.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'src/lib') diff --git a/src/lib/libcrypto/bn/bn_mod.c b/src/lib/libcrypto/bn/bn_mod.c index 67bd3541b0..eb2d5b072e 100644 --- a/src/lib/libcrypto/bn/bn_mod.c +++ b/src/lib/libcrypto/bn/bn_mod.c @@ -1,4 +1,4 @@ -/* $OpenBSD: bn_mod.c,v 1.9 2014/07/12 16:03:36 miod Exp $ */ +/* $OpenBSD: bn_mod.c,v 1.10 2016/11/05 10:47:16 miod Exp $ */ /* Includes code written by Lenka Fibikova * for the OpenSSL project. */ /* ==================================================================== @@ -125,8 +125,11 @@ BN_nnmod(BIGNUM *r, const BIGNUM *m, const BIGNUM *d, BN_CTX *ctx) return 0; if (!r->neg) return 1; - /* now -|d| < r < 0, so we have to set r := r + |d| */ - return (d->neg ? BN_sub : BN_add)(r, r, d); + /* now -|d| < r < 0, so we have to set r := r + |d| */ + if (d->neg) + return BN_sub(r, r, d); + else + return BN_add(r, r, d); } int -- cgit v1.2.3-55-g6feb