From 32a82f1d836ae0b4585960be533eecc2e39c1cb7 Mon Sep 17 00:00:00 2001 From: jsing <> Date: Thu, 22 May 2014 17:37:06 +0000 Subject: Stop pulling pqueue.h into ssl_locl.h since only a small part of libssl actually needs it. Instead, just include it in the files where it is actually necessary. Also remove standard includes from pqueue.h so that they are not available as a side effect. Just add the two includes that are needed to pqueue.c. ok miod@ --- src/lib/libssl/d1_both.c | 2 ++ src/lib/libssl/d1_lib.c | 2 ++ src/lib/libssl/d1_pkt.c | 2 ++ src/lib/libssl/pqueue.c | 2 ++ src/lib/libssl/pqueue.h | 4 ---- src/lib/libssl/src/ssl/d1_both.c | 2 ++ src/lib/libssl/src/ssl/d1_lib.c | 2 ++ src/lib/libssl/src/ssl/d1_pkt.c | 2 ++ src/lib/libssl/src/ssl/pqueue.c | 2 ++ src/lib/libssl/src/ssl/pqueue.h | 4 ---- src/lib/libssl/src/ssl/ssl_locl.h | 2 -- src/lib/libssl/ssl_locl.h | 2 -- 12 files changed, 16 insertions(+), 12 deletions(-) (limited to 'src/lib') diff --git a/src/lib/libssl/d1_both.c b/src/lib/libssl/d1_both.c index 10b62cd410..0e32825695 100644 --- a/src/lib/libssl/d1_both.c +++ b/src/lib/libssl/d1_both.c @@ -123,6 +123,8 @@ #include #include +#include "pqueue.h" + #define RSMBLY_BITMASK_SIZE(msg_len) (((msg_len) + 7) / 8) #define RSMBLY_BITMASK_MARK(bitmask, start, end) { \ diff --git a/src/lib/libssl/d1_lib.c b/src/lib/libssl/d1_lib.c index b6b765634d..a2500ee0bf 100644 --- a/src/lib/libssl/d1_lib.c +++ b/src/lib/libssl/d1_lib.c @@ -64,6 +64,8 @@ #include #include + +#include "pqueue.h" #include "ssl_locl.h" const char dtls1_version_str[]="DTLSv1" OPENSSL_VERSION_PTEXT; diff --git a/src/lib/libssl/d1_pkt.c b/src/lib/libssl/d1_pkt.c index df18e5bae3..a9ccc6d349 100644 --- a/src/lib/libssl/d1_pkt.c +++ b/src/lib/libssl/d1_pkt.c @@ -121,6 +121,8 @@ #include #include +#include "pqueue.h" + /* mod 128 saturating subtract of two 64-bit values in big-endian order */ static int satsub64be(const unsigned char *v1, const unsigned char *v2) diff --git a/src/lib/libssl/pqueue.c b/src/lib/libssl/pqueue.c index daf5e21b3a..af8530064f 100644 --- a/src/lib/libssl/pqueue.c +++ b/src/lib/libssl/pqueue.c @@ -57,7 +57,9 @@ * */ +#include #include + #include "pqueue.h" typedef struct _pqueue { diff --git a/src/lib/libssl/pqueue.h b/src/lib/libssl/pqueue.h index 6e7df8f35b..4b167871ef 100644 --- a/src/lib/libssl/pqueue.h +++ b/src/lib/libssl/pqueue.h @@ -60,10 +60,6 @@ #ifndef HEADER_PQUEUE_H #define HEADER_PQUEUE_H -#include -#include -#include - typedef struct _pqueue *pqueue; typedef struct _pitem { diff --git a/src/lib/libssl/src/ssl/d1_both.c b/src/lib/libssl/src/ssl/d1_both.c index 10b62cd410..0e32825695 100644 --- a/src/lib/libssl/src/ssl/d1_both.c +++ b/src/lib/libssl/src/ssl/d1_both.c @@ -123,6 +123,8 @@ #include #include +#include "pqueue.h" + #define RSMBLY_BITMASK_SIZE(msg_len) (((msg_len) + 7) / 8) #define RSMBLY_BITMASK_MARK(bitmask, start, end) { \ diff --git a/src/lib/libssl/src/ssl/d1_lib.c b/src/lib/libssl/src/ssl/d1_lib.c index b6b765634d..a2500ee0bf 100644 --- a/src/lib/libssl/src/ssl/d1_lib.c +++ b/src/lib/libssl/src/ssl/d1_lib.c @@ -64,6 +64,8 @@ #include #include + +#include "pqueue.h" #include "ssl_locl.h" const char dtls1_version_str[]="DTLSv1" OPENSSL_VERSION_PTEXT; diff --git a/src/lib/libssl/src/ssl/d1_pkt.c b/src/lib/libssl/src/ssl/d1_pkt.c index df18e5bae3..a9ccc6d349 100644 --- a/src/lib/libssl/src/ssl/d1_pkt.c +++ b/src/lib/libssl/src/ssl/d1_pkt.c @@ -121,6 +121,8 @@ #include #include +#include "pqueue.h" + /* mod 128 saturating subtract of two 64-bit values in big-endian order */ static int satsub64be(const unsigned char *v1, const unsigned char *v2) diff --git a/src/lib/libssl/src/ssl/pqueue.c b/src/lib/libssl/src/ssl/pqueue.c index daf5e21b3a..af8530064f 100644 --- a/src/lib/libssl/src/ssl/pqueue.c +++ b/src/lib/libssl/src/ssl/pqueue.c @@ -57,7 +57,9 @@ * */ +#include #include + #include "pqueue.h" typedef struct _pqueue { diff --git a/src/lib/libssl/src/ssl/pqueue.h b/src/lib/libssl/src/ssl/pqueue.h index 6e7df8f35b..4b167871ef 100644 --- a/src/lib/libssl/src/ssl/pqueue.h +++ b/src/lib/libssl/src/ssl/pqueue.h @@ -60,10 +60,6 @@ #ifndef HEADER_PQUEUE_H #define HEADER_PQUEUE_H -#include -#include -#include - typedef struct _pqueue *pqueue; typedef struct _pitem { diff --git a/src/lib/libssl/src/ssl/ssl_locl.h b/src/lib/libssl/src/ssl/ssl_locl.h index a0c3017836..012a38cc5c 100644 --- a/src/lib/libssl/src/ssl/ssl_locl.h +++ b/src/lib/libssl/src/ssl/ssl_locl.h @@ -164,8 +164,6 @@ #include #include -#include "pqueue.h" - #define c2l(c,l) (l = ((unsigned long)(*((c)++))) , \ l|=(((unsigned long)(*((c)++)))<< 8), \ l|=(((unsigned long)(*((c)++)))<<16), \ diff --git a/src/lib/libssl/ssl_locl.h b/src/lib/libssl/ssl_locl.h index a0c3017836..012a38cc5c 100644 --- a/src/lib/libssl/ssl_locl.h +++ b/src/lib/libssl/ssl_locl.h @@ -164,8 +164,6 @@ #include #include -#include "pqueue.h" - #define c2l(c,l) (l = ((unsigned long)(*((c)++))) , \ l|=(((unsigned long)(*((c)++)))<< 8), \ l|=(((unsigned long)(*((c)++)))<<16), \ -- cgit v1.2.3-55-g6feb