From 4b550e7e97a6068d5f18fbfc47b22d8b4faa4ff6 Mon Sep 17 00:00:00 2001 From: tedu <> Date: Fri, 11 Jul 2014 09:24:03 +0000 Subject: better document perils of setuid getenv and xr with issetugid ok deraadt --- src/lib/libc/stdlib/getenv.3 | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'src/lib') diff --git a/src/lib/libc/stdlib/getenv.3 b/src/lib/libc/stdlib/getenv.3 index 2333559516..ce2ef43b6f 100644 --- a/src/lib/libc/stdlib/getenv.3 +++ b/src/lib/libc/stdlib/getenv.3 @@ -29,9 +29,9 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.\" $OpenBSD: getenv.3,v 1.20 2014/04/21 08:46:59 guenther Exp $ +.\" $OpenBSD: getenv.3,v 1.21 2014/07/11 09:24:03 tedu Exp $ .\" -.Dd $Mdocdate: April 21 2014 $ +.Dd $Mdocdate: July 11 2014 $ .Dt GETENV 3 .Os .Sh NAME @@ -145,6 +145,7 @@ function failed because it was unable to allocate memory for the environment. .Xr csh 1 , .Xr sh 1 , .Xr execve 2 , +.Xr issetugid 2 , .Xr environ 7 .Sh STANDARDS The @@ -175,3 +176,10 @@ The .Fn putenv function appeared in .Bx 4.3 Reno . +.Sh CAVEATS +Library code must be careful about using +.Fn getenv +to read untrusted environment variables in setuid programs. +The +.Fn issetugid +function is provided for this purpose. -- cgit v1.2.3-55-g6feb