From d0bbacc151e9bccff4588511de44901a286322c2 Mon Sep 17 00:00:00 2001 From: jsing <> Date: Sun, 7 Dec 2014 16:01:03 +0000 Subject: Fix a memory leak in tls_check_subject_altname() by calling sk_GENERAL_NAME_pop_free() instead of sk_GENERAL_NAME_free(). The latter only frees the stack itself and does not free the items. From Basskrapfen on github. --- src/lib/libtls/tls_verify.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/lib') diff --git a/src/lib/libtls/tls_verify.c b/src/lib/libtls/tls_verify.c index 35a18202a9..ddc403fb10 100644 --- a/src/lib/libtls/tls_verify.c +++ b/src/lib/libtls/tls_verify.c @@ -1,4 +1,4 @@ -/* $OpenBSD: tls_verify.c,v 1.3 2014/12/07 15:48:02 bcook Exp $ */ +/* $OpenBSD: tls_verify.c,v 1.4 2014/12/07 16:01:03 jsing Exp $ */ /* * Copyright (c) 2014 Jeremie Courreges-Anglas * @@ -155,7 +155,7 @@ tls_check_subject_altname(X509 *cert, const char *host) } } - sk_GENERAL_NAME_free(altname_stack); + sk_GENERAL_NAME_pop_free(altname_stack, GENERAL_NAME_free); return rv; } -- cgit v1.2.3-55-g6feb