From d0e75df669e616f4e020ff1b663080bf874ecf0b Mon Sep 17 00:00:00 2001 From: tb <> Date: Sun, 9 Mar 2025 15:35:40 +0000 Subject: Unexport EC_GROUP_copy() Without EC_GROUP_new(), this API is useless. There's EC_GROUP_dup(). ok jsing --- src/lib/libcrypto/Symbols.list | 1 - src/lib/libcrypto/ec/ec.h | 3 +-- src/lib/libcrypto/ec/ec_lib.c | 5 ++--- src/lib/libcrypto/hidden/openssl/ec.h | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) (limited to 'src/lib') diff --git a/src/lib/libcrypto/Symbols.list b/src/lib/libcrypto/Symbols.list index 647dfa6065..463eef8fe8 100644 --- a/src/lib/libcrypto/Symbols.list +++ b/src/lib/libcrypto/Symbols.list @@ -865,7 +865,6 @@ EC_GROUP_check EC_GROUP_check_discriminant EC_GROUP_clear_free EC_GROUP_cmp -EC_GROUP_copy EC_GROUP_dup EC_GROUP_free EC_GROUP_get0_generator diff --git a/src/lib/libcrypto/ec/ec.h b/src/lib/libcrypto/ec/ec.h index 0229a4bf41..4f5d33226e 100644 --- a/src/lib/libcrypto/ec/ec.h +++ b/src/lib/libcrypto/ec/ec.h @@ -1,4 +1,4 @@ -/* $OpenBSD: ec.h,v 1.50 2025/03/09 15:33:35 tb Exp $ */ +/* $OpenBSD: ec.h,v 1.51 2025/03/09 15:35:40 tb Exp $ */ /* * Originally written by Bodo Moeller for the OpenSSL project. */ @@ -101,7 +101,6 @@ typedef struct ec_point_st EC_POINT; void EC_GROUP_free(EC_GROUP *group); void EC_GROUP_clear_free(EC_GROUP *group); -int EC_GROUP_copy(EC_GROUP *dst, const EC_GROUP *src); EC_GROUP *EC_GROUP_dup(const EC_GROUP *src); int EC_GROUP_set_generator(EC_GROUP *group, const EC_POINT *generator, diff --git a/src/lib/libcrypto/ec/ec_lib.c b/src/lib/libcrypto/ec/ec_lib.c index 874c3f1d45..9c7f684385 100644 --- a/src/lib/libcrypto/ec/ec_lib.c +++ b/src/lib/libcrypto/ec/ec_lib.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ec_lib.c,v 1.117 2025/03/09 15:33:35 tb Exp $ */ +/* $OpenBSD: ec_lib.c,v 1.118 2025/03/09 15:35:40 tb Exp $ */ /* * Originally written by Bodo Moeller for the OpenSSL project. */ @@ -146,7 +146,7 @@ EC_GROUP_clear_free(EC_GROUP *group) } LCRYPTO_ALIAS(EC_GROUP_clear_free); -int +static int EC_GROUP_copy(EC_GROUP *dst, const EC_GROUP *src) { if (dst->meth != src->meth) { @@ -197,7 +197,6 @@ EC_GROUP_copy(EC_GROUP *dst, const EC_GROUP *src) return 1; } -LCRYPTO_ALIAS(EC_GROUP_copy); EC_GROUP * EC_GROUP_dup(const EC_GROUP *in_group) diff --git a/src/lib/libcrypto/hidden/openssl/ec.h b/src/lib/libcrypto/hidden/openssl/ec.h index 8ffa017d2d..510b26284f 100644 --- a/src/lib/libcrypto/hidden/openssl/ec.h +++ b/src/lib/libcrypto/hidden/openssl/ec.h @@ -1,4 +1,4 @@ -/* $OpenBSD: ec.h,v 1.8 2025/03/09 15:33:35 tb Exp $ */ +/* $OpenBSD: ec.h,v 1.9 2025/03/09 15:35:40 tb Exp $ */ /* * Copyright (c) 2023 Bob Beck * @@ -26,7 +26,6 @@ #include "crypto_namespace.h" LCRYPTO_USED(EC_GROUP_free); -LCRYPTO_USED(EC_GROUP_copy); LCRYPTO_USED(EC_GROUP_dup); LCRYPTO_USED(EC_GROUP_set_generator); LCRYPTO_USED(EC_GROUP_get0_generator); -- cgit v1.2.3-55-g6feb