From 232e4582dd23763c78b3bb546bef2f11ee7103c8 Mon Sep 17 00:00:00 2001 From: tb <> Date: Tue, 28 Jul 2026 10:29:05 +0000 Subject: tlsfuzzer: avoid mutable default arguments --- src/regress/lib/libssl/tlsfuzzer/tlsfuzzer.py | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) (limited to 'src') diff --git a/src/regress/lib/libssl/tlsfuzzer/tlsfuzzer.py b/src/regress/lib/libssl/tlsfuzzer/tlsfuzzer.py index 2b78e07b4e..8e12494379 100644 --- a/src/regress/lib/libssl/tlsfuzzer/tlsfuzzer.py +++ b/src/regress/lib/libssl/tlsfuzzer/tlsfuzzer.py @@ -1,4 +1,4 @@ -# $OpenBSD: tlsfuzzer.py,v 1.61 2026/07/28 10:21:34 tb Exp $ +# $OpenBSD: tlsfuzzer.py,v 1.62 2026/07/28 10:29:05 tb Exp $ # # Copyright (c) 2020 Theo Buehler # @@ -32,7 +32,15 @@ class Test: XXX Add client cert support. """ - def __init__(self, name="", args=[], tls12_args=[], tls13_args=[]): + + def __init__(self, name="", args=None, tls12_args=None, tls13_args=None): + if args is None: + args = [] + if tls12_args is None: + tls12_args = [] + if tls13_args is None: + tls13_args = [] + self.name = name self.tls12_args = args self.tls13_args = args @@ -55,7 +63,10 @@ class Test: class TestGroup: """A group of Test objects to be run by TestRunner.""" - def __init__(self, title="Tests", tests=[]): + def __init__(self, title="Tests", tests=None): + if tests is None: + tests = [] + self.title = title self.tests = tests @@ -654,7 +665,7 @@ class TestRunner: def __init__( self, timing=False, verbose=False, host="localhost", port=4433, - use_tls1_3=True, dry_run=False, tests=[], scriptdir=tlsfuzzer_scriptdir, + use_tls1_3=True, dry_run=False, scriptdir=tlsfuzzer_scriptdir, ): self.tests = [] @@ -671,8 +682,9 @@ class TestRunner: self.timing = timing self.verbose = verbose - def add(self, title="tests", tests=[]): - # tests.sort(key=lambda test: test.name) + def add(self, title="tests", tests=None): + if tests is None: + tests = [] self.tests.append(TestGroup(title, tests)) def add_group(self, group): -- cgit v1.2.3-55-g6feb