From 3d5d777847c4c3150ded4c8ec6e62798a116c542 Mon Sep 17 00:00:00 2001 From: tb <> Date: Sun, 28 Apr 2019 05:05:56 +0000 Subject: Avoid an undefined shift in ASN1_ENUMERATED_get(). (same fix as in a_int.c rev 1.34) Fixes oss-fuzz issue #13809 ok beck, jsing --- src/lib/libcrypto/asn1/a_enum.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/lib/libcrypto/asn1/a_enum.c b/src/lib/libcrypto/asn1/a_enum.c index c7d3a9a0ac..0952e049db 100644 --- a/src/lib/libcrypto/asn1/a_enum.c +++ b/src/lib/libcrypto/asn1/a_enum.c @@ -1,4 +1,4 @@ -/* $OpenBSD: a_enum.c,v 1.19 2018/04/25 11:48:21 tb Exp $ */ +/* $OpenBSD: a_enum.c,v 1.20 2019/04/28 05:05:56 tb Exp $ */ /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) * All rights reserved. * @@ -56,6 +56,7 @@ * [including the GNU Public Licence.] */ +#include #include #include @@ -107,7 +108,7 @@ long ASN1_ENUMERATED_get(const ASN1_ENUMERATED *a) { int neg = 0, i; - long r = 0; + unsigned long r = 0; if (a == NULL) return (0L); @@ -128,9 +129,13 @@ ASN1_ENUMERATED_get(const ASN1_ENUMERATED *a) r <<= 8; r |= (unsigned char)a->data[i]; } + + if (r > LONG_MAX) + return -1; + if (neg) - r = -r; - return (r); + return -(long)r; + return (long)r; } ASN1_ENUMERATED * -- cgit v1.2.3-55-g6feb