From 7c01be4b2669dbaad7e74b56200a97050be3bf54 Mon Sep 17 00:00:00 2001 From: jsing <> Date: Tue, 5 Aug 2025 15:01:13 +0000 Subject: Mark the inputs to bn_mul_comba{4,8}() as const. This makes it consistent with bn_sqr_comba{4,8}() and simplifies an upcoming change. ok tb@ --- src/lib/libcrypto/bn/arch/amd64/bn_arch.c | 6 +++--- src/lib/libcrypto/bn/bn_local.h | 6 +++--- src/lib/libcrypto/bn/bn_mul.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) (limited to 'src') diff --git a/src/lib/libcrypto/bn/arch/amd64/bn_arch.c b/src/lib/libcrypto/bn/arch/amd64/bn_arch.c index a377a05681..8eb3670def 100644 --- a/src/lib/libcrypto/bn/arch/amd64/bn_arch.c +++ b/src/lib/libcrypto/bn/arch/amd64/bn_arch.c @@ -1,4 +1,4 @@ -/* $OpenBSD: bn_arch.c,v 1.7 2023/06/24 16:01:44 jsing Exp $ */ +/* $OpenBSD: bn_arch.c,v 1.8 2025/08/05 15:01:13 jsing Exp $ */ /* * Copyright (c) 2023 Joel Sing * @@ -78,7 +78,7 @@ bn_mul_words(BN_ULONG *rd, const BN_ULONG *ad, int num, BN_ULONG w) #ifdef HAVE_BN_MUL_COMBA4 void -bn_mul_comba4(BN_ULONG *rd, BN_ULONG *ad, BN_ULONG *bd) +bn_mul_comba4(BN_ULONG *rd, const BN_ULONG *ad, const BN_ULONG *bd) { /* XXX - consider using non-alt on CPUs that have the ADX extension. */ bignum_mul_4_8_alt((uint64_t *)rd, (uint64_t *)ad, (uint64_t *)bd); @@ -87,7 +87,7 @@ bn_mul_comba4(BN_ULONG *rd, BN_ULONG *ad, BN_ULONG *bd) #ifdef HAVE_BN_MUL_COMBA8 void -bn_mul_comba8(BN_ULONG *rd, BN_ULONG *ad, BN_ULONG *bd) +bn_mul_comba8(BN_ULONG *rd, const BN_ULONG *ad, const BN_ULONG *bd) { /* XXX - consider using non-alt on CPUs that have the ADX extension. */ bignum_mul_8_16_alt((uint64_t *)rd, (uint64_t *)ad, (uint64_t *)bd); diff --git a/src/lib/libcrypto/bn/bn_local.h b/src/lib/libcrypto/bn/bn_local.h index 0eb9a7a745..af280ebfce 100644 --- a/src/lib/libcrypto/bn/bn_local.h +++ b/src/lib/libcrypto/bn/bn_local.h @@ -1,4 +1,4 @@ -/* $OpenBSD: bn_local.h,v 1.51 2025/05/25 04:30:55 jsing Exp $ */ +/* $OpenBSD: bn_local.h,v 1.52 2025/08/05 15:01:13 jsing Exp $ */ /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) * All rights reserved. * @@ -240,8 +240,8 @@ BN_ULONG bn_sub(BN_ULONG *r, int r_len, const BN_ULONG *a, int a_len, const BN_ULONG *b, int b_len); void bn_mul_normal(BN_ULONG *r, BN_ULONG *a, int na, BN_ULONG *b, int nb); -void bn_mul_comba4(BN_ULONG *r, BN_ULONG *a, BN_ULONG *b); -void bn_mul_comba8(BN_ULONG *r, BN_ULONG *a, BN_ULONG *b); +void bn_mul_comba4(BN_ULONG *r, const BN_ULONG *a, const BN_ULONG *b); +void bn_mul_comba8(BN_ULONG *r, const BN_ULONG *a, const BN_ULONG *b); void bn_sqr_comba4(BN_ULONG *r, const BN_ULONG *a); void bn_sqr_comba8(BN_ULONG *r, const BN_ULONG *a); diff --git a/src/lib/libcrypto/bn/bn_mul.c b/src/lib/libcrypto/bn/bn_mul.c index 7ec7d43437..ebf34bb413 100644 --- a/src/lib/libcrypto/bn/bn_mul.c +++ b/src/lib/libcrypto/bn/bn_mul.c @@ -1,4 +1,4 @@ -/* $OpenBSD: bn_mul.c,v 1.40 2025/08/03 10:32:04 tb Exp $ */ +/* $OpenBSD: bn_mul.c,v 1.41 2025/08/05 15:01:13 jsing Exp $ */ /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) * All rights reserved. * @@ -74,7 +74,7 @@ */ #ifndef HAVE_BN_MUL_COMBA4 void -bn_mul_comba4(BN_ULONG *r, BN_ULONG *a, BN_ULONG *b) +bn_mul_comba4(BN_ULONG *r, const BN_ULONG *a, const BN_ULONG *b) { BN_ULONG c0, c1, c2; @@ -110,7 +110,7 @@ bn_mul_comba4(BN_ULONG *r, BN_ULONG *a, BN_ULONG *b) */ #ifndef HAVE_BN_MUL_COMBA8 void -bn_mul_comba8(BN_ULONG *r, BN_ULONG *a, BN_ULONG *b) +bn_mul_comba8(BN_ULONG *r, const BN_ULONG *a, const BN_ULONG *b) { BN_ULONG c0, c1, c2; -- cgit v1.2.3-55-g6feb