From 815dfad45fb21455544f1076aeb41edc3805817d Mon Sep 17 00:00:00 2001 From: tb <> Date: Sun, 9 Mar 2025 15:39:39 +0000 Subject: Remove Jprojective_coordinates API There goes another implementation detail that should never have been leaked out of the library. ok jsing --- src/lib/libcrypto/Symbols.list | 2 -- src/lib/libcrypto/ec/ec.h | 6 +----- src/lib/libcrypto/ec/ec_lib.c | 20 +------------------- src/lib/libcrypto/hidden/openssl/ec.h | 4 +--- 4 files changed, 3 insertions(+), 29 deletions(-) (limited to 'src') diff --git a/src/lib/libcrypto/Symbols.list b/src/lib/libcrypto/Symbols.list index 332f55af8e..a48d870fc1 100644 --- a/src/lib/libcrypto/Symbols.list +++ b/src/lib/libcrypto/Symbols.list @@ -943,7 +943,6 @@ EC_POINT_copy EC_POINT_dbl EC_POINT_dup EC_POINT_free -EC_POINT_get_Jprojective_coordinates_GFp EC_POINT_get_affine_coordinates EC_POINT_get_affine_coordinates_GFp EC_POINT_hex2point @@ -957,7 +956,6 @@ EC_POINT_oct2point EC_POINT_point2bn EC_POINT_point2hex EC_POINT_point2oct -EC_POINT_set_Jprojective_coordinates_GFp EC_POINT_set_affine_coordinates EC_POINT_set_affine_coordinates_GFp EC_POINT_set_compressed_coordinates diff --git a/src/lib/libcrypto/ec/ec.h b/src/lib/libcrypto/ec/ec.h index 6d8d9dfb07..3417df1ce9 100644 --- a/src/lib/libcrypto/ec/ec.h +++ b/src/lib/libcrypto/ec/ec.h @@ -1,4 +1,4 @@ -/* $OpenBSD: ec.h,v 1.52 2025/03/09 15:37:31 tb Exp $ */ +/* $OpenBSD: ec.h,v 1.53 2025/03/09 15:39:39 tb Exp $ */ /* * Originally written by Bodo Moeller for the OpenSSL project. */ @@ -172,10 +172,6 @@ int EC_POINT_get_affine_coordinates(const EC_GROUP *group, const EC_POINT *p, int EC_POINT_set_compressed_coordinates(const EC_GROUP *group, EC_POINT *p, const BIGNUM *x, int y_bit, BN_CTX *ctx); -int EC_POINT_set_Jprojective_coordinates_GFp(const EC_GROUP *group, EC_POINT *p, - const BIGNUM *x, const BIGNUM *y, const BIGNUM *z, BN_CTX *ctx); -int EC_POINT_get_Jprojective_coordinates_GFp(const EC_GROUP *group, - const EC_POINT *p, BIGNUM *x, BIGNUM *y, BIGNUM *z, BN_CTX *ctx); int EC_POINT_set_affine_coordinates_GFp(const EC_GROUP *group, EC_POINT *p, const BIGNUM *x, const BIGNUM *y, BN_CTX *ctx); int EC_POINT_get_affine_coordinates_GFp(const EC_GROUP *group, diff --git a/src/lib/libcrypto/ec/ec_lib.c b/src/lib/libcrypto/ec/ec_lib.c index 43774d4267..b9829b6a47 100644 --- a/src/lib/libcrypto/ec/ec_lib.c +++ b/src/lib/libcrypto/ec/ec_lib.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ec_lib.c,v 1.119 2025/03/09 15:37:31 tb Exp $ */ +/* $OpenBSD: ec_lib.c,v 1.120 2025/03/09 15:39:39 tb Exp $ */ /* * Originally written by Bodo Moeller for the OpenSSL project. */ @@ -1367,24 +1367,6 @@ LCRYPTO_ALIAS(EC_POINT_mul); * XXX - remove everything below in the next bump */ -int -EC_POINT_set_Jprojective_coordinates_GFp(const EC_GROUP *group, EC_POINT *point, - const BIGNUM *x, const BIGNUM *y, const BIGNUM *z, BN_CTX *ctx) -{ - ECerror(ERR_R_DISABLED); - return 0; -} -LCRYPTO_ALIAS(EC_POINT_set_Jprojective_coordinates_GFp); - -int -EC_POINT_get_Jprojective_coordinates_GFp(const EC_GROUP *group, - const EC_POINT *point, BIGNUM *x, BIGNUM *y, BIGNUM *z, BN_CTX *ctx) -{ - ECerror(ERR_R_DISABLED); - return 0; -} -LCRYPTO_ALIAS(EC_POINT_get_Jprojective_coordinates_GFp); - int EC_POINTs_make_affine(const EC_GROUP *group, size_t num, EC_POINT *points[], BN_CTX *ctx_in) diff --git a/src/lib/libcrypto/hidden/openssl/ec.h b/src/lib/libcrypto/hidden/openssl/ec.h index ada455c089..44adfc458e 100644 --- a/src/lib/libcrypto/hidden/openssl/ec.h +++ b/src/lib/libcrypto/hidden/openssl/ec.h @@ -1,4 +1,4 @@ -/* $OpenBSD: ec.h,v 1.10 2025/03/09 15:37:31 tb Exp $ */ +/* $OpenBSD: ec.h,v 1.11 2025/03/09 15:39:39 tb Exp $ */ /* * Copyright (c) 2023 Bob Beck * @@ -156,8 +156,6 @@ LCRYPTO_UNUSED(EC_GROUP_clear_free); LCRYPTO_UNUSED(EC_GROUP_set_curve_GFp); LCRYPTO_UNUSED(EC_GROUP_get_curve_GFp); LCRYPTO_UNUSED(EC_POINT_clear_free); -LCRYPTO_UNUSED(EC_POINT_set_Jprojective_coordinates_GFp); -LCRYPTO_UNUSED(EC_POINT_get_Jprojective_coordinates_GFp); LCRYPTO_UNUSED(EC_POINT_set_affine_coordinates_GFp); LCRYPTO_UNUSED(EC_POINT_get_affine_coordinates_GFp); LCRYPTO_UNUSED(EC_POINT_set_compressed_coordinates_GFp); -- cgit v1.2.3-55-g6feb