From 8240aac2f833ab9870011a4aba19d9fff2bfc019 Mon Sep 17 00:00:00 2001 From: tb <> Date: Wed, 18 Dec 2024 10:55:21 +0000 Subject: mlkem: fix whitespace --- src/lib/libcrypto/mlkem/mlkem1024.c | 5 +++-- src/lib/libcrypto/mlkem/mlkem768.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/lib/libcrypto/mlkem/mlkem1024.c b/src/lib/libcrypto/mlkem/mlkem1024.c index d016a1de15..b3cacc828b 100644 --- a/src/lib/libcrypto/mlkem/mlkem1024.c +++ b/src/lib/libcrypto/mlkem/mlkem1024.c @@ -1,4 +1,4 @@ -/* $OpenBSD: mlkem1024.c,v 1.3 2024/12/17 17:06:10 beck Exp $ */ +/* $OpenBSD: mlkem1024.c,v 1.4 2024/12/18 10:55:21 tb Exp $ */ /* * Copyright (c) 2024, Google Inc. * Copyright (c) 2024, Bob Beck @@ -188,7 +188,7 @@ reduce_once(uint16_t x) * value to transit through a general-purpose register). On AArch64, this * is a difference of 2x. * - * We usually add value barriers to selects because Clang turns + * We usually add value barriers to selects because Clang turns * consecutive selects with the same condition into a branch instead of * CMOV/CSEL. This condition does not occur in ML-KEM, so omitting it * seems to be safe so far but see @@ -477,6 +477,7 @@ scalar_centered_binomial_distribution_eta_2_with_prf(scalar *out, uint16_t value = (byte & 1) + ((byte >> 1) & 1); value -= ((byte >> 2) & 1) + ((byte >> 3) & 1); + /* * Add |kPrime| if |value| underflowed. See |reduce_once| for a * discussion on why the value barrier is omitted. While this diff --git a/src/lib/libcrypto/mlkem/mlkem768.c b/src/lib/libcrypto/mlkem/mlkem768.c index 4f8affaf60..040118cafc 100644 --- a/src/lib/libcrypto/mlkem/mlkem768.c +++ b/src/lib/libcrypto/mlkem/mlkem768.c @@ -1,4 +1,4 @@ -/* $OpenBSD: mlkem768.c,v 1.4 2024/12/17 17:06:10 beck Exp $ */ +/* $OpenBSD: mlkem768.c,v 1.5 2024/12/18 10:55:21 tb Exp $ */ /* * Copyright (c) 2024, Google Inc. * Copyright (c) 2024, Bob Beck @@ -187,7 +187,7 @@ reduce_once(uint16_t x) * value to transit through a general-purpose register). On AArch64, this * is a difference of 2x. * - * We usually add value barriers to selects because Clang turns + * We usually add value barriers to selects because Clang turns * consecutive selects with the same condition into a branch instead of * CMOV/CSEL. This condition does not occur in ML-KEM, so omitting it * seems to be safe so far but see @@ -476,6 +476,7 @@ scalar_centered_binomial_distribution_eta_2_with_prf(scalar *out, uint16_t value = (byte & 1) + ((byte >> 1) & 1); value -= ((byte >> 2) & 1) + ((byte >> 3) & 1); + /* * Add |kPrime| if |value| underflowed. See |reduce_once| for a * discussion on why the value barrier is omitted. While this -- cgit v1.2.3-55-g6feb