From 90df0c5f081a9ff7e6e051eb8807d786b33b957a Mon Sep 17 00:00:00 2001 From: deraadt <> Date: Fri, 13 Nov 2015 18:13:13 +0000 Subject: Since rtable was hoisted to the top with setrtable, it should have no bearing on the following pledge setups anymore. ok benno --- src/usr.bin/nc/netcat.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/usr.bin/nc/netcat.c b/src/usr.bin/nc/netcat.c index 8860bac824..ae2404bd0d 100644 --- a/src/usr.bin/nc/netcat.c +++ b/src/usr.bin/nc/netcat.c @@ -1,4 +1,4 @@ -/* $OpenBSD: netcat.c,v 1.142 2015/11/12 20:33:52 benno Exp $ */ +/* $OpenBSD: netcat.c,v 1.143 2015/11/13 18:13:13 deraadt Exp $ */ /* * Copyright (c) 2001 Eric Jackson * Copyright (c) 2015 Bob Beck. All rights reserved. @@ -310,23 +310,20 @@ main(int argc, char *argv[]) argc -= optind; argv += optind; - if (rtableid >= 0) { + if (rtableid >= 0) if (setrtable(rtableid) == -1) err(1, "setrtable"); - } + if (family == AF_UNIX) { if (pledge("stdio rpath wpath cpath tmppath unix", NULL) == -1) err(1, "pledge"); - } - else if (Fflag) { + } else if (Fflag) { if (pledge("stdio inet dns sendfd", NULL) == -1) err(1, "pledge"); - } - else if (usetls) { + } else if (usetls) { if (pledge("stdio rpath inet dns", NULL) == -1) err(1, "pledge"); - } - else if (pledge("stdio inet dns", NULL) == -1) + } else if (pledge("stdio inet dns", NULL) == -1) err(1, "pledge"); /* Cruft to make sure options are clean, and used properly. */ @@ -830,7 +827,7 @@ remote_connect(const char *host, const char *port, struct addrinfo hints) if (timeout_connect(s, res0->ai_addr, res0->ai_addrlen) == 0) break; - else if (vflag) + if (vflag) warn("connect to %s port %s (%s) failed", host, port, uflag ? "udp" : "tcp"); -- cgit v1.2.3-55-g6feb