From dd7cad4ac6e5632efe1e2fd3ed0e9e80e2405328 Mon Sep 17 00:00:00 2001
From: tb <>
Date: Fri, 7 Mar 2025 10:57:29 +0000
Subject: _CONF_new_section(): avoid silly ok dance

ok jsing
---
 src/lib/libcrypto/conf/conf_api.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

(limited to 'src')

diff --git a/src/lib/libcrypto/conf/conf_api.c b/src/lib/libcrypto/conf/conf_api.c
index b0056bcbe6..511f9d6470 100644
--- a/src/lib/libcrypto/conf/conf_api.c
+++ b/src/lib/libcrypto/conf/conf_api.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: conf_api.c,v 1.23 2025/03/07 10:54:51 tb Exp $ */
+/* $OpenBSD: conf_api.c,v 1.24 2025/03/07 10:57:29 tb Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -247,7 +247,6 @@ CONF_VALUE *
 _CONF_new_section(CONF *conf, const char *section)
 {
 	STACK_OF(CONF_VALUE) *sk = NULL;
-	int ok = 0;
 	CONF_VALUE *v = NULL, *vv;
 
 	if ((sk = sk_CONF_VALUE_new_null()) == NULL)
@@ -260,14 +259,12 @@ _CONF_new_section(CONF *conf, const char *section)
 
 	vv = lh_CONF_VALUE_insert(conf->data, v);
 	OPENSSL_assert(vv == NULL);
-	ok = 1;
 
-err:
-	if (!ok) {
-		if (sk != NULL)
-			sk_CONF_VALUE_free(sk);
-		free(v);
-		v = NULL;
-	}
-	return (v);
+	return v;
+
+ err:
+	sk_CONF_VALUE_free(sk);
+	free(v);
+
+	return NULL;
 }
-- 
cgit v1.2.3-55-g6feb