From f70a0d22279737fa16152bac39154453ba8aeac8 Mon Sep 17 00:00:00 2001 From: djm <> Date: Wed, 21 May 2025 09:14:01 +0000 Subject: for SOCKS4A don't perform a local hostname lookup that we're not going to use; spotted by lucas@ --- src/usr.bin/nc/socks.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/usr.bin/nc/socks.c b/src/usr.bin/nc/socks.c index 4c5ff90135..684d6062d3 100644 --- a/src/usr.bin/nc/socks.c +++ b/src/usr.bin/nc/socks.c @@ -1,4 +1,4 @@ -/* $OpenBSD: socks.c,v 1.32 2025/05/21 08:41:35 djm Exp $ */ +/* $OpenBSD: socks.c,v 1.33 2025/05/21 09:14:01 djm Exp $ */ /* * Copyright (c) 1999 Niklas Hallqvist. All rights reserved. @@ -294,9 +294,11 @@ socks_connect(const char *host, const char *port, errx(1, "connection failed, unsupported address type"); } } else if (socksv == 4 || socksv == 44) { - /* This will exit on lookup failure */ - decode_addrport(host, port, (struct sockaddr *)&addr, - sizeof(addr), 1, 0); + if (socksv == 4) { + /* This will exit on lookup failure */ + decode_addrport(host, port, (struct sockaddr *)&addr, + sizeof(addr), 1, 0); + } /* Version 4 */ buf[0] = SOCKS_V4; -- cgit v1.2.3-55-g6feb