summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrent Cook <bcook@openbsd.org>2014-07-24 20:23:24 -0500
committerBrent Cook <bcook@openbsd.org>2014-07-24 21:36:38 -0500
commita5c82283e08dd6f85cbe25624204c7a55ef45051 (patch)
tree06c9c1518ac4de25efabf0d33aa402a8ab3166ff
parent55d07e70dcb7f689b161c56b2d6b5eeefbf127a6 (diff)
downloadportable-a5c82283e08dd6f85cbe25624204c7a55ef45051.tar.gz
portable-a5c82283e08dd6f85cbe25624204c7a55ef45051.tar.bz2
portable-a5c82283e08dd6f85cbe25624204c7a55ef45051.zip
remove per-OS arc4random_buf overrides
If an OS provides an arc4random_buf implementation in its C library, prefer it over an in-library version. This allows OS-specific implementations to become more robust over time. It also prevents possible link-time confusion as to which arc4random_buf implementation is in use by an application when linked with LibreSSL. The built-in unit tests will identify some common issues, such as fork safety and PID wrap handling. Other elements, such as seeding mechanisms, should be audited by the vendor or user for correctness. ok deraadt@ beck@
-rw-r--r--configure.ac.tpl6
1 files changed, 0 insertions, 6 deletions
diff --git a/configure.ac.tpl b/configure.ac.tpl
index ac66565..8e85e9b 100644
--- a/configure.ac.tpl
+++ b/configure.ac.tpl
@@ -84,12 +84,6 @@ AC_CHECK_FUNC(arc4random_buf,[AC_SEARCH_LIBS(write,, [NO_ARC4RANDOM_BUF=],
84AC_SUBST(NO_ARC4RANDOM_BUF) 84AC_SUBST(NO_ARC4RANDOM_BUF)
85AM_CONDITIONAL(NO_ARC4RANDOM_BUF, test "x$NO_ARC4RANDOM_BUF" = "xyes") 85AM_CONDITIONAL(NO_ARC4RANDOM_BUF, test "x$NO_ARC4RANDOM_BUF" = "xyes")
86 86
87# overrides for arc4random_buf implementations with known issues
88AM_CONDITIONAL(NO_ARC4RANDOM_BUF,
89 test x$HOST_OS = xdarwin \
90 -o x$HOST_OS = xsolaris \
91 -o x$NO_ARC4RANDOM_BUF = xyes)
92
93AC_CHECK_FUNC(getentropy,[AC_SEARCH_LIBS(write,, [NO_GETENTROPY=], 87AC_CHECK_FUNC(getentropy,[AC_SEARCH_LIBS(write,, [NO_GETENTROPY=],
94 [NO_GETENTROPY=yes])], [NO_GETENTROPY=yes]) 88 [NO_GETENTROPY=yes])], [NO_GETENTROPY=yes])
95AC_SUBST(NO_GETENTROPY) 89AC_SUBST(NO_GETENTROPY)