From 9a8d1ec81730b6aface3670b1c96375dca5af424 Mon Sep 17 00:00:00 2001 From: Yang Kun <91833768+ikspress@users.noreply.github.com> Date: Wed, 21 Aug 2024 21:58:47 +0800 Subject: Append version to dll on CMake --- crypto/CMakeLists.txt | 8 +++----- ssl/CMakeLists.txt | 8 +++----- tls/CMakeLists.txt | 8 +++----- 3 files changed, 9 insertions(+), 15 deletions(-) diff --git a/crypto/CMakeLists.txt b/crypto/CMakeLists.txt index 4492360..9599a70 100644 --- a/crypto/CMakeLists.txt +++ b/crypto/CMakeLists.txt @@ -860,15 +860,13 @@ add_library(crypto $ $ emp export_symbol(crypto ${CMAKE_CURRENT_BINARY_DIR}/crypto_p.sym) target_link_libraries(crypto ${PLATFORM_LIBS}) -if (WIN32) - set(CRYPTO_POSTFIX -${CRYPTO_MAJOR_VERSION} PARENT_SCOPE) -endif() set_target_properties(crypto PROPERTIES - OUTPUT_NAME crypto${CRYPTO_POSTFIX} - ARCHIVE_OUTPUT_NAME crypto${CRYPTO_POSTFIX} + OUTPUT_NAME crypto + ARCHIVE_OUTPUT_NAME crypto EXPORT_NAME Crypto VERSION ${CRYPTO_VERSION} SOVERSION ${CRYPTO_MAJOR_VERSION} + DLL_NAME_WITH_SOVERSION TRUE ) target_include_directories( diff --git a/ssl/CMakeLists.txt b/ssl/CMakeLists.txt index 76f4570..414fe07 100644 --- a/ssl/CMakeLists.txt +++ b/ssl/CMakeLists.txt @@ -86,15 +86,13 @@ endif() export_symbol(ssl ${CMAKE_CURRENT_SOURCE_DIR}/ssl.sym) target_link_libraries(ssl crypto ${PLATFORM_LIBS}) -if (WIN32) - set(SSL_POSTFIX -${SSL_MAJOR_VERSION} PARENT_SCOPE) -endif() set_target_properties(ssl PROPERTIES - OUTPUT_NAME ssl${SSL_POSTFIX} - ARCHIVE_OUTPUT_NAME ssl${SSL_POSTFIX} + OUTPUT_NAME ssl + ARCHIVE_OUTPUT_NAME ssl EXPORT_NAME SSL VERSION ${SSL_VERSION} SOVERSION ${SSL_MAJOR_VERSION} + DLL_NAME_WITH_SOVERSION TRUE ) target_include_directories( diff --git a/tls/CMakeLists.txt b/tls/CMakeLists.txt index 919b1fa..e584dcb 100644 --- a/tls/CMakeLists.txt +++ b/tls/CMakeLists.txt @@ -58,15 +58,13 @@ endif() export_symbol(tls ${CMAKE_CURRENT_BINARY_DIR}/tls.sym) target_link_libraries(tls ${OPENSSL_LIBS}) -if (WIN32) - set(TLS_POSTFIX -${TLS_MAJOR_VERSION} PARENT_SCOPE) -endif() set_target_properties(tls PROPERTIES - OUTPUT_NAME tls${TLS_POSTFIX} - ARCHIVE_OUTPUT_NAME tls${TLS_POSTFIX} + OUTPUT_NAME tls + ARCHIVE_OUTPUT_NAME tls EXPORT_NAME TLS VERSION ${TLS_VERSION} SOVERSION ${TLS_MAJOR_VERSION} + DLL_NAME_WITH_SOVERSION TRUE ) target_include_directories( -- cgit v1.2.3-55-g6feb From 5feccf86658d09b917c005bfb43191dd38f38c83 Mon Sep 17 00:00:00 2001 From: Brent Cook Date: Tue, 1 Oct 2024 03:23:09 -0500 Subject: bump minimum CMake version for DLL_NAME_WITH_SOVERSION --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 048f6cf..387e919 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required (VERSION 3.16.4) +cmake_minimum_required (VERSION 3.27) if(MSVC) cmake_policy(SET CMP0091 NEW) endif() -- cgit v1.2.3-55-g6feb From 5b8d17bcc3dd353e8a08b650f950adc620a7f7b7 Mon Sep 17 00:00:00 2001 From: Brent Cook Date: Tue, 1 Oct 2024 03:23:43 -0500 Subject: properly specify define for shared libraries --- .github/workflows/windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 6aca153..c4c7d72 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -50,7 +50,7 @@ jobs: - name: "Configure CMake" shell: cmd - run: cmake -Bbuild -G "${{ matrix.generator }}" -A ${{ matrix.arch }} DBUILD_SHARED_LIBS=${{ matrix.shared }} -DCMAKE_INSTALL_PREFIX=../local + run: cmake -Bbuild -G "${{ matrix.generator }}" -A ${{ matrix.arch }} -D BUILD_SHARED_LIBS=${{ matrix.shared }} -D CMAKE_INSTALL_PREFIX=../local - name: "Build" shell: cmd -- cgit v1.2.3-55-g6feb