A mirror of https://github.com/wixtoolset/wix.git https://git.lua4.win/wix/atom?h=v5.0.0-rc.2 2024-03-22T19:03:41+00:00 2024-03-22T19:03:41+00:00 Rob Mensching rob@firegiant.com 2024-03-22T19:03:41+00:00 urn:sha1:dbb148c20d2490cf85f3f62f7d59f8dbc5c1a2c5 2024-03-22T18:57:27+00:00 Rob Mensching rob@firegiant.com 2024-03-21T06:51:53+00:00 urn:sha1:fed3d69eb4da7fa2bafdd8f555ce5869c36925f7 When running elevated, Burn uses the Windows Temp folder as its working folder to prevent normal processes from tampering with the files. Windows Temp does allow non-elevated processes to write to the folder but they cannot see the files there. Unfortunately, contrary to our belief, non-elevated processes can read the files in Windows Temp by watching for directory changes. This allows a malicious process to lie in wait, watching the Windows Temp folder until a Burn process is launched elevated, then attack the working folder. Mitigate that attack by protecting the working folder to only elevated users. Managed custom actions also fall back to using the Windows Temp folder in some cases and thus can be exposed in a similar fashion as an elevated Burn process. Remove that possibility. 2024-03-22T18:55:43+00:00 Rob Mensching rob@firegiant.com 2024-03-22T18:55:43+00:00 urn:sha1:e84b6768772c01e44dd55fb583cf78388ec7e48a When deleting directories recursively, an elevated custom action following junctions in a user-writable location could recurse into any directory, including some that you might not want to be deleted. Therefore, avoid recursing into directories that are actually junctions (aka "reparse points"). This applies to: - The RemoveFoldersEx custom action (which doesn't actually do deletions but would instruct elevated MSI to delete on your behalf). - DTF's custom action runner. 2024-03-21T20:07:14+00:00 Rob Mensching rob@firegiant.com 2024-03-21T07:59:21+00:00 urn:sha1:90cdebbe94c7f60db86965ffb97d9ba51d0bc9fc Take this breaking change opportunity to simplify the header files used by BA devs. 2024-03-20T18:39:21+00:00 Bob Arnson bob@firegiant.com 2024-03-20T17:43:21+00:00 urn:sha1:a2b75ebed82be8c488f2840c359a512e865d682c 2024-03-20T18:39:21+00:00 Bob Arnson bob@firegiant.com 2024-03-20T17:42:57+00:00 urn:sha1:66d4fa7b30289cdbead9d6307864af8832c8c458 Fixes https://github.com/wixtoolset/issues/issues/8059. 2024-03-18T18:38:06+00:00 Bob Arnson bob@firegiant.com 2024-03-17T16:10:29+00:00 urn:sha1:db7727a8b38e9ca118792c1f22835b3291314869 It's a formatted field but was too short. Fixes https://github.com/wixtoolset/issues/issues/8043. 2024-03-18T18:30:03+00:00 Bob Arnson bob@firegiant.com 2024-03-18T14:49:20+00:00 urn:sha1:3b842aeea892c9dae01e5167e5f2e35c448f5bda 2024-03-14T21:21:36+00:00 Bob Arnson bob@firegiant.com 2024-03-14T17:48:20+00:00 urn:sha1:f104c01bc29378b544c0f458c45106bcfd63c11b 2024-03-14T19:59:07+00:00 Bob Arnson bob@firegiant.com 2024-03-14T17:51:07+00:00 urn:sha1:dabcb37846e8f6da9d43984863678e9a4cf57b3e Fixes https://github.com/wixtoolset/issues/issues/8040.