diff options
author | Bob Arnson <bob@firegiant.com> | 2020-06-10 21:38:18 -0400 |
---|---|---|
committer | Bob Arnson <bob@firegiant.com> | 2020-06-10 21:39:48 -0400 |
commit | 9ebc094931aa473136c56c095a1170948f481f2e (patch) | |
tree | a0b550084720962ad39e79633570c328cfdf6073 | |
parent | eecd0353a70e74f2776c25f8b89e86f08c013168 (diff) | |
download | wix-9ebc094931aa473136c56c095a1170948f481f2e.tar.gz wix-9ebc094931aa473136c56c095a1170948f481f2e.tar.bz2 wix-9ebc094931aa473136c56c095a1170948f481f2e.zip |
Add error message when tuple can't be found.
Diffstat (limited to '')
-rw-r--r-- | src/WixToolset.Data/ErrorMessages.cs | 6 | ||||
-rw-r--r-- | src/WixToolset.Data/IntermediateTuple.cs | 7 | ||||
-rw-r--r-- | src/WixToolset.Data/WarningMessages.cs | 2 |
3 files changed, 13 insertions, 2 deletions
diff --git a/src/WixToolset.Data/ErrorMessages.cs b/src/WixToolset.Data/ErrorMessages.cs index cb8d5f8f..d0736628 100644 --- a/src/WixToolset.Data/ErrorMessages.cs +++ b/src/WixToolset.Data/ErrorMessages.cs | |||
@@ -2279,6 +2279,11 @@ namespace WixToolset.Data | |||
2279 | return Message(null, Ids.IntermediatesMustBeResolved, "Intermediates being bound must have been resolved. This intermediate was not resolved: {0}", invalidIntermediate); | 2279 | return Message(null, Ids.IntermediatesMustBeResolved, "Intermediates being bound must have been resolved. This intermediate was not resolved: {0}", invalidIntermediate); |
2280 | } | 2280 | } |
2281 | 2281 | ||
2282 | public static Message UnknownSymbolType(string symbolName) | ||
2283 | { | ||
2284 | return Message(null, Ids.UnknownSymbolType, "Could not deserialize symbol of type type '{0}' because it is not a standard symbol type or one provided by a loaded extension.", symbolName); | ||
2285 | } | ||
2286 | |||
2282 | private static Message Message(SourceLineNumber sourceLineNumber, Ids id, string format, params object[] args) | 2287 | private static Message Message(SourceLineNumber sourceLineNumber, Ids id, string format, params object[] args) |
2283 | { | 2288 | { |
2284 | return new Message(sourceLineNumber, MessageLevel.Error, (int)id, format, args); | 2289 | return new Message(sourceLineNumber, MessageLevel.Error, (int)id, format, args); |
@@ -2680,6 +2685,7 @@ namespace WixToolset.Data | |||
2680 | IntermediatesMustBeResolved = 396, | 2685 | IntermediatesMustBeResolved = 396, |
2681 | MissingBundleSearch = 397, | 2686 | MissingBundleSearch = 397, |
2682 | CircularSearchReference = 398, | 2687 | CircularSearchReference = 398, |
2688 | UnknownSymbolType = 399, | ||
2683 | } | 2689 | } |
2684 | } | 2690 | } |
2685 | } | 2691 | } |
diff --git a/src/WixToolset.Data/IntermediateTuple.cs b/src/WixToolset.Data/IntermediateTuple.cs index 8a5858ee..9146b2be 100644 --- a/src/WixToolset.Data/IntermediateTuple.cs +++ b/src/WixToolset.Data/IntermediateTuple.cs | |||
@@ -165,7 +165,12 @@ namespace WixToolset.Data | |||
165 | var id = (idJson == null) ? null : Identifier.Deserialize(idJson); | 165 | var id = (idJson == null) ? null : Identifier.Deserialize(idJson); |
166 | var sourceLineNumbers = (sourceLineNumbersJson == null) ? null : SourceLineNumber.Deserialize(sourceLineNumbersJson); | 166 | var sourceLineNumbers = (sourceLineNumbersJson == null) ? null : SourceLineNumber.Deserialize(sourceLineNumbersJson); |
167 | 167 | ||
168 | creator.TryGetTupleDefinitionByName(definitionName, out var definition); // TODO: this isn't sufficient. | 168 | // TODO: this isn't sufficient. |
169 | if (!creator.TryGetTupleDefinitionByName(definitionName, out var definition)) | ||
170 | { | ||
171 | throw new WixException(ErrorMessages.UnknownSymbolType(definitionName)); | ||
172 | } | ||
173 | |||
169 | var tuple = definition.CreateTuple(sourceLineNumbers, id); | 174 | var tuple = definition.CreateTuple(sourceLineNumbers, id); |
170 | 175 | ||
171 | for (var i = 0; i < fieldsJson.Count && i < tuple.Fields.Length; ++i) | 176 | for (var i = 0; i < fieldsJson.Count && i < tuple.Fields.Length; ++i) |
diff --git a/src/WixToolset.Data/WarningMessages.cs b/src/WixToolset.Data/WarningMessages.cs index 55bf2c2c..b31f5aaf 100644 --- a/src/WixToolset.Data/WarningMessages.cs +++ b/src/WixToolset.Data/WarningMessages.cs | |||
@@ -504,7 +504,7 @@ namespace WixToolset.Data | |||
504 | 504 | ||
505 | public static Message RequiresMsi500forArmPackage(SourceLineNumber sourceLineNumbers) | 505 | public static Message RequiresMsi500forArmPackage(SourceLineNumber sourceLineNumbers) |
506 | { | 506 | { |
507 | return Message(sourceLineNumbers, Ids.RequiresMsi500forArmPackage, "Package/@InstallerVersion must be 500 or greater for an Arm package. The value will be changed to 500. Please specify a value of 500 or greater in order to eliminate this warning."); | 507 | return Message(sourceLineNumbers, Ids.RequiresMsi500forArmPackage, "Package/@InstallerVersion must be 500 or greater for an ARM or ARM64 package. The value will be changed to 500. Please specify a value of 500 or greater in order to eliminate this warning."); |
508 | } | 508 | } |
509 | 509 | ||
510 | public static Message ReservedAttribute(SourceLineNumber sourceLineNumbers, string elementName, string attributeName) | 510 | public static Message ReservedAttribute(SourceLineNumber sourceLineNumbers, string elementName, string attributeName) |