aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2018-07-13 15:14:19 -0700
committerRob Mensching <rob@firegiant.com>2018-07-13 15:14:19 -0700
commitcb634e2e83d1aa44652a4bf5383fdd3e9ce7f2fc (patch)
tree1823957f60ad32fe9769d5ccfa251f76f229543f
parent06835732a8e6e9d18d548fbb4487bcaf5c8e1725 (diff)
downloadwix-cb634e2e83d1aa44652a4bf5383fdd3e9ce7f2fc.tar.gz
wix-cb634e2e83d1aa44652a4bf5383fdd3e9ce7f2fc.tar.bz2
wix-cb634e2e83d1aa44652a4bf5383fdd3e9ce7f2fc.zip
Fix up defaults for MsbuildMessageListener
-rw-r--r--src/WixToolset.BuildTasks/DoIt.cs19
1 files changed, 5 insertions, 14 deletions
diff --git a/src/WixToolset.BuildTasks/DoIt.cs b/src/WixToolset.BuildTasks/DoIt.cs
index 0c7a0943..02b33522 100644
--- a/src/WixToolset.BuildTasks/DoIt.cs
+++ b/src/WixToolset.BuildTasks/DoIt.cs
@@ -17,15 +17,6 @@ namespace WixToolset.BuildTasks
17 /// </summary> 17 /// </summary>
18 public sealed class DoIt : Task 18 public sealed class DoIt : Task
19 { 19 {
20 public DoIt() : this(null)
21 {
22 }
23
24 public DoIt(IMessageListener listener)
25 {
26 this.Listener = listener ?? new MsbuildMessageListener(this.Log, "WIX", "wix.exe");
27 }
28
29 public string AdditionalOptions { get; set; } 20 public string AdditionalOptions { get; set; }
30 21
31 public string[] Cultures { get; set; } 22 public string[] Cultures { get; set; }
@@ -115,8 +106,6 @@ namespace WixToolset.BuildTasks
115 public string[] SuppressIces { get; set; } 106 public string[] SuppressIces { get; set; }
116 public string AdditionalCub { get; set; } 107 public string AdditionalCub { get; set; }
117 108
118 private IMessageListener Listener { get; }
119
120 public override bool Execute() 109 public override bool Execute()
121 { 110 {
122 try 111 try
@@ -138,6 +127,8 @@ namespace WixToolset.BuildTasks
138 127
139 private void ExecuteCore() 128 private void ExecuteCore()
140 { 129 {
130 var listener = new MsbuildMessageListener(this.Log, "WIX", this.BuildEngine.ProjectFileOfTaskNode);
131
141 var commandLineBuilder = new WixCommandLineBuilder(); 132 var commandLineBuilder = new WixCommandLineBuilder();
142 133
143 commandLineBuilder.AppendTextUnquoted("build"); 134 commandLineBuilder.AppendTextUnquoted("build");
@@ -172,7 +163,7 @@ namespace WixToolset.BuildTasks
172 var serviceProvider = new WixToolsetServiceProvider(); 163 var serviceProvider = new WixToolsetServiceProvider();
173 164
174 var messaging = serviceProvider.GetService<IMessaging>(); 165 var messaging = serviceProvider.GetService<IMessaging>();
175 messaging.SetListener(this.Listener); 166 messaging.SetListener(listener);
176 167
177 var arguments = serviceProvider.GetService<ICommandLineArguments>(); 168 var arguments = serviceProvider.GetService<ICommandLineArguments>();
178 arguments.Populate(commandLineString); 169 arguments.Populate(commandLineString);
@@ -302,11 +293,11 @@ namespace WixToolset.BuildTasks
302 293
303 private class MsbuildMessageListener : IMessageListener 294 private class MsbuildMessageListener : IMessageListener
304 { 295 {
305 public MsbuildMessageListener(TaskLoggingHelper logger, string longName, string shortName) 296 public MsbuildMessageListener(TaskLoggingHelper logger, string shortName, string longName)
306 { 297 {
307 this.Logger = logger; 298 this.Logger = logger;
308 this.LongAppName = longName;
309 this.ShortAppName = shortName; 299 this.ShortAppName = shortName;
300 this.LongAppName = longName;
310 } 301 }
311 302
312 public string ShortAppName { get; } 303 public string ShortAppName { get; }