aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBob Arnson <bob@firegiant.com>2021-12-16 23:33:46 -0500
committerBob Arnson <github@bobs.org>2021-12-17 09:03:18 -0500
commit7d0391599aa451f774e2db76528df266abedb004 (patch)
tree2d67ce54933b0703c65b1f9c81936ba0eb9ed236
parent0761f2cf91e3194a9f25814d4e3695f8963951b2 (diff)
downloadwix-7d0391599aa451f774e2db76528df266abedb004.tar.gz
wix-7d0391599aa451f774e2db76528df266abedb004.tar.bz2
wix-7d0391599aa451f774e2db76528df266abedb004.zip
Fix dependency table column names.
(More extensions to fix but in general, primary key column names do not repeat the table name. There's no benefit to including the `4` and some don't use a prefix either. I'll aim for consistency but not pedantic consistency.)
-rw-r--r--src/ext/Dependency/ca/wixdepca.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/ext/Dependency/ca/wixdepca.cpp b/src/ext/Dependency/ca/wixdepca.cpp
index efb19ea2..88342217 100644
--- a/src/ext/Dependency/ca/wixdepca.cpp
+++ b/src/ext/Dependency/ca/wixdepca.cpp
@@ -6,14 +6,14 @@
6#define INITIAL_STRINGDICT_SIZE 4 6#define INITIAL_STRINGDICT_SIZE 4
7 7
8LPCWSTR vcsDependencyProviderQuery = 8LPCWSTR vcsDependencyProviderQuery =
9 L"SELECT `Wix4DependencyProvider`.`Wix4DependencyProvider`, `Wix4DependencyProvider`.`Component_`, `Wix4DependencyProvider`.`ProviderKey`, `Wix4DependencyProvider`.`Attributes` " 9 L"SELECT `Wix4DependencyProvider`.`WixDependencyProvider`, `Wix4DependencyProvider`.`Component_`, `Wix4DependencyProvider`.`ProviderKey`, `Wix4DependencyProvider`.`Attributes` "
10 L"FROM `Wix4DependencyProvider`"; 10 L"FROM `Wix4DependencyProvider`";
11enum eDependencyProviderQuery { dpqId = 1, dpqComponent, dpqProviderKey, dpqAttributes }; 11enum eDependencyProviderQuery { dpqId = 1, dpqComponent, dpqProviderKey, dpqAttributes };
12 12
13LPCWSTR vcsDependencyQuery = 13LPCWSTR vcsDependencyQuery =
14 L"SELECT `Wix4Dependency`.`Wix4Dependency`, `Wix4DependencyProvider`.`Component_`, `Wix4Dependency`.`ProviderKey`, `Wix4Dependency`.`MinVersion`, `Wix4Dependency`.`MaxVersion`, `Wix4Dependency`.`Attributes` " 14 L"SELECT `Wix4Dependency`.`WixDependency`, `Wix4DependencyProvider`.`Component_`, `Wix4Dependency`.`ProviderKey`, `Wix4Dependency`.`MinVersion`, `Wix4Dependency`.`MaxVersion`, `Wix4Dependency`.`Attributes` "
15 L"FROM `Wix4DependencyProvider`, `Wix4Dependency`, `Wix4DependencyRef` " 15 L"FROM `Wix4DependencyProvider`, `Wix4Dependency`, `Wix4DependencyRef` "
16 L"WHERE `Wix4Dependency`.`Wix4Dependency` = `Wix4DependencyRef`.`Wix4Dependency_` AND `Wix4DependencyProvider`.`Wix4DependencyProvider` = `Wix4DependencyRef`.`Wix4DependencyProvider_`"; 16 L"WHERE `Wix4Dependency`.`WixDependency` = `Wix4DependencyRef`.`WixDependency_` AND `Wix4DependencyProvider`.`WixDependencyProvider` = `Wix4DependencyRef`.`WixDependencyProvider_`";
17enum eDependencyComponentQuery { dqId = 1, dqComponent, dqProviderKey, dqMinVersion, dqMaxVersion, dqAttributes }; 17enum eDependencyComponentQuery { dqId = 1, dqComponent, dqProviderKey, dqMinVersion, dqMaxVersion, dqAttributes };
18 18
19static HRESULT EnsureRequiredDependencies( 19static HRESULT EnsureRequiredDependencies(
@@ -159,7 +159,7 @@ static HRESULT EnsureRequiredDependencies(
159 while (S_OK == (hr = WcaFetchRecord(hView, &hRec))) 159 while (S_OK == (hr = WcaFetchRecord(hView, &hRec)))
160 { 160 {
161 hr = WcaGetRecordString(hRec, dqId, &sczId); 161 hr = WcaGetRecordString(hRec, dqId, &sczId);
162 ExitOnFailure(hr, "Failed to get Wix4Dependency.Wix4Dependency."); 162 ExitOnFailure(hr, "Failed to get Wix4Dependency.WixDependency.");
163 163
164 hr = WcaGetRecordString(hRec, dqComponent, &sczComponent); 164 hr = WcaGetRecordString(hRec, dqComponent, &sczComponent);
165 ExitOnFailure(hr, "Failed to get Wix4DependencyProvider.Component_."); 165 ExitOnFailure(hr, "Failed to get Wix4DependencyProvider.Component_.");
@@ -317,7 +317,7 @@ static HRESULT EnsureAbsentDependents(
317 while (S_OK == (hr = WcaFetchRecord(hView, &hRec))) 317 while (S_OK == (hr = WcaFetchRecord(hView, &hRec)))
318 { 318 {
319 hr = WcaGetRecordString(hRec, dpqId, &sczId); 319 hr = WcaGetRecordString(hRec, dpqId, &sczId);
320 ExitOnFailure(hr, "Failed to get Wix4DependencyProvider.Wix4DependencyProvider."); 320 ExitOnFailure(hr, "Failed to get Wix4DependencyProvider.WixDependencyProvider.");
321 321
322 hr = WcaGetRecordString(hRec, dpqComponent, &sczComponent); 322 hr = WcaGetRecordString(hRec, dpqComponent, &sczComponent);
323 ExitOnFailure(hr, "Failed to get Wix4DependencyProvider.Component."); 323 ExitOnFailure(hr, "Failed to get Wix4DependencyProvider.Component.");