aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2023-11-06 22:45:46 -0800
committerRob Mensching <rob@firegiant.com>2023-11-07 14:27:27 -0800
commit575dc6b828300aaf7fea47eda2526719eb85dc91 (patch)
treeacbada419c4bdca1554db3b2a037d0bb6d281308
parent1e6697673d0d1bad77cbd6ef11ece45cf6aeac28 (diff)
downloadwix-575dc6b828300aaf7fea47eda2526719eb85dc91.tar.gz
wix-575dc6b828300aaf7fea47eda2526719eb85dc91.tar.bz2
wix-575dc6b828300aaf7fea47eda2526719eb85dc91.zip
Fix duplication of AdditionalOptions being added to command-line
Fixes 7837
-rw-r--r--src/wix/WixToolset.BuildTasks/DetachBundleEngineForSigning.cs2
-rw-r--r--src/wix/WixToolset.BuildTasks/InscribeMsiWithCabinetSignatures.cs2
-rw-r--r--src/wix/WixToolset.BuildTasks/ReattachSignedBundleEngine.cs2
-rw-r--r--src/wix/WixToolset.BuildTasks/WindowsInstallerValidation.cs2
-rw-r--r--src/wix/WixToolset.BuildTasks/WixBuild.cs1
5 files changed, 0 insertions, 9 deletions
diff --git a/src/wix/WixToolset.BuildTasks/DetachBundleEngineForSigning.cs b/src/wix/WixToolset.BuildTasks/DetachBundleEngineForSigning.cs
index 27d4436b..506f6d56 100644
--- a/src/wix/WixToolset.BuildTasks/DetachBundleEngineForSigning.cs
+++ b/src/wix/WixToolset.BuildTasks/DetachBundleEngineForSigning.cs
@@ -42,8 +42,6 @@ namespace WixToolset.BuildTasks
42 commandLineBuilder.AppendSwitchIfNotNull("-intermediatefolder ", this.IntermediateDirectory); 42 commandLineBuilder.AppendSwitchIfNotNull("-intermediatefolder ", this.IntermediateDirectory);
43 43
44 base.BuildCommandLine(commandLineBuilder); 44 base.BuildCommandLine(commandLineBuilder);
45
46 commandLineBuilder.AppendTextIfNotWhitespace(this.AdditionalOptions);
47 } 45 }
48 46
49 protected override int ExecuteTool(string pathToTool, string responseFileCommands, string commandLineCommands) 47 protected override int ExecuteTool(string pathToTool, string responseFileCommands, string commandLineCommands)
diff --git a/src/wix/WixToolset.BuildTasks/InscribeMsiWithCabinetSignatures.cs b/src/wix/WixToolset.BuildTasks/InscribeMsiWithCabinetSignatures.cs
index 72d9e872..4be47532 100644
--- a/src/wix/WixToolset.BuildTasks/InscribeMsiWithCabinetSignatures.cs
+++ b/src/wix/WixToolset.BuildTasks/InscribeMsiWithCabinetSignatures.cs
@@ -27,8 +27,6 @@ namespace WixToolset.BuildTasks
27 commandLineBuilder.AppendSwitchIfNotNull("-intermediatefolder ", this.IntermediateDirectory); 27 commandLineBuilder.AppendSwitchIfNotNull("-intermediatefolder ", this.IntermediateDirectory);
28 28
29 base.BuildCommandLine(commandLineBuilder); 29 base.BuildCommandLine(commandLineBuilder);
30
31 commandLineBuilder.AppendTextIfNotWhitespace(this.AdditionalOptions);
32 } 30 }
33 } 31 }
34} 32}
diff --git a/src/wix/WixToolset.BuildTasks/ReattachSignedBundleEngine.cs b/src/wix/WixToolset.BuildTasks/ReattachSignedBundleEngine.cs
index d131402d..0dbcc46d 100644
--- a/src/wix/WixToolset.BuildTasks/ReattachSignedBundleEngine.cs
+++ b/src/wix/WixToolset.BuildTasks/ReattachSignedBundleEngine.cs
@@ -49,8 +49,6 @@ namespace WixToolset.BuildTasks
49 commandLineBuilder.AppendSwitchIfNotNull("-intermediatefolder ", this.IntermediateDirectory); 49 commandLineBuilder.AppendSwitchIfNotNull("-intermediatefolder ", this.IntermediateDirectory);
50 50
51 base.BuildCommandLine(commandLineBuilder); 51 base.BuildCommandLine(commandLineBuilder);
52
53 commandLineBuilder.AppendTextIfNotWhitespace(this.AdditionalOptions);
54 } 52 }
55 53
56 protected override int ExecuteTool(string pathToTool, string responseFileCommands, string commandLineCommands) 54 protected override int ExecuteTool(string pathToTool, string responseFileCommands, string commandLineCommands)
diff --git a/src/wix/WixToolset.BuildTasks/WindowsInstallerValidation.cs b/src/wix/WixToolset.BuildTasks/WindowsInstallerValidation.cs
index 24e50444..e0077ffa 100644
--- a/src/wix/WixToolset.BuildTasks/WindowsInstallerValidation.cs
+++ b/src/wix/WixToolset.BuildTasks/WindowsInstallerValidation.cs
@@ -53,8 +53,6 @@ namespace WixToolset.BuildTasks
53 commandLineBuilder.AppendArrayIfNotNull("-sice ", this.SuppressIces); 53 commandLineBuilder.AppendArrayIfNotNull("-sice ", this.SuppressIces);
54 54
55 base.BuildCommandLine(commandLineBuilder); 55 base.BuildCommandLine(commandLineBuilder);
56
57 commandLineBuilder.AppendTextIfNotWhitespace(this.AdditionalOptions);
58 } 56 }
59 } 57 }
60} 58}
diff --git a/src/wix/WixToolset.BuildTasks/WixBuild.cs b/src/wix/WixToolset.BuildTasks/WixBuild.cs
index 4cadd7e0..0d455c46 100644
--- a/src/wix/WixToolset.BuildTasks/WixBuild.cs
+++ b/src/wix/WixToolset.BuildTasks/WixBuild.cs
@@ -82,7 +82,6 @@ namespace WixToolset.BuildTasks
82 commandLineBuilder.AppendArrayIfNotNull("-bindVariable ", this.CalculateBindVariableStrings()); 82 commandLineBuilder.AppendArrayIfNotNull("-bindVariable ", this.CalculateBindVariableStrings());
83 commandLineBuilder.AppendArrayIfNotNull("-loc ", this.LocalizationFiles); 83 commandLineBuilder.AppendArrayIfNotNull("-loc ", this.LocalizationFiles);
84 commandLineBuilder.AppendArrayIfNotNull("-lib ", this.LibraryFiles); 84 commandLineBuilder.AppendArrayIfNotNull("-lib ", this.LibraryFiles);
85 commandLineBuilder.AppendTextIfNotWhitespace(this.AdditionalOptions);
86 commandLineBuilder.AppendFileNamesIfNotNull(this.SourceFiles, " "); 85 commandLineBuilder.AppendFileNamesIfNotNull(this.SourceFiles, " ");
87 } 86 }
88 87