aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2022-09-24 10:58:17 -0700
committerRob Mensching <rob@firegiant.com>2022-09-27 16:25:20 -0700
commit7113e775cf68aba493c5e769e8e5584db15d1974 (patch)
treec4599bb02c2e011184df06d9c22848e7ef717fea
parentcdf4cdf88fd411ae6c67eea8e2b0cbb7f0cecb4c (diff)
downloadwix-7113e775cf68aba493c5e769e8e5584db15d1974.tar.gz
wix-7113e775cf68aba493c5e769e8e5584db15d1974.tar.bz2
wix-7113e775cf68aba493c5e769e8e5584db15d1974.zip
Symbols won't have section ids.
-rw-r--r--src/wix/WixToolset.Core.WindowsInstaller/Bind/CreateWindowsInstallerDataFromIRCommand.cs3
-rw-r--r--src/wix/WixToolset.Core/Linker.cs29
2 files changed, 0 insertions, 32 deletions
diff --git a/src/wix/WixToolset.Core.WindowsInstaller/Bind/CreateWindowsInstallerDataFromIRCommand.cs b/src/wix/WixToolset.Core.WindowsInstaller/Bind/CreateWindowsInstallerDataFromIRCommand.cs
index 4d99ff40..cdb8da2b 100644
--- a/src/wix/WixToolset.Core.WindowsInstaller/Bind/CreateWindowsInstallerDataFromIRCommand.cs
+++ b/src/wix/WixToolset.Core.WindowsInstaller/Bind/CreateWindowsInstallerDataFromIRCommand.cs
@@ -1183,9 +1183,6 @@ namespace WixToolset.Core.WindowsInstaller.Bind
1183 var customRow = this.CreateRow(firstCellSymbol, customTableDefinition); 1183 var customRow = this.CreateRow(firstCellSymbol, customTableDefinition);
1184 var customRowFieldsByColumnName = customRow.Fields.ToDictionary(f => f.Column.Name); 1184 var customRowFieldsByColumnName = customRow.Fields.ToDictionary(f => f.Column.Name);
1185 1185
1186#if TODO // SectionId seems like a good thing to preserve.
1187 customRow.SectionId = symbol.SectionId;
1188#endif
1189 foreach (var cell in rowOfCells) 1186 foreach (var cell in rowOfCells)
1190 { 1187 {
1191 var data = cell.Data; 1188 var data = cell.Data;
diff --git a/src/wix/WixToolset.Core/Linker.cs b/src/wix/WixToolset.Core/Linker.cs
index 40654735..1aeb783b 100644
--- a/src/wix/WixToolset.Core/Linker.cs
+++ b/src/wix/WixToolset.Core/Linker.cs
@@ -22,8 +22,6 @@ namespace WixToolset.Core
22 { 22 {
23 private static readonly string EmptyGuid = Guid.Empty.ToString("B"); 23 private static readonly string EmptyGuid = Guid.Empty.ToString("B");
24 24
25 private readonly bool sectionIdOnRows;
26
27 /// <summary> 25 /// <summary>
28 /// Creates a linker. 26 /// Creates a linker.
29 /// </summary> 27 /// </summary>
@@ -31,7 +29,6 @@ namespace WixToolset.Core
31 { 29 {
32 this.ServiceProvider = serviceProvider; 30 this.ServiceProvider = serviceProvider;
33 this.Messaging = this.ServiceProvider.GetService<IMessaging>(); 31 this.Messaging = this.ServiceProvider.GetService<IMessaging>();
34 this.sectionIdOnRows = true; // TODO: what is the correct value for this?
35 } 32 }
36 33
37 private IServiceProvider ServiceProvider { get; } 34 private IServiceProvider ServiceProvider { get; }
@@ -182,18 +179,8 @@ namespace WixToolset.Core
182 // metadata. 179 // metadata.
183 var resolvedSection = new IntermediateSection(find.EntrySection.Id, find.EntrySection.Type); 180 var resolvedSection = new IntermediateSection(find.EntrySection.Id, find.EntrySection.Type);
184 181
185 var sectionCount = 0;
186
187 foreach (var section in sections) 182 foreach (var section in sections)
188 { 183 {
189 sectionCount++;
190
191 var sectionId = section.Id;
192 if (null == sectionId && this.sectionIdOnRows)
193 {
194 sectionId = "wix.section." + sectionCount.ToString(CultureInfo.InvariantCulture);
195 }
196
197 foreach (var symbol in section.Symbols) 184 foreach (var symbol in section.Symbols)
198 { 185 {
199 if (find.RedundantSymbols.Contains(symbol)) 186 if (find.RedundantSymbols.Contains(symbol))
@@ -289,22 +276,6 @@ namespace WixToolset.Core
289 } 276 }
290 } 277 }
291 278
292 // Correct the section Id in FeatureComponents table.
293 if (this.sectionIdOnRows)
294 {
295#if TODO_DO_SYMBOLS_NEED_SECTIONIDS
296 var componentSectionIds = resolvedSection.Symbols.OfType<ComponentSymbol>().ToDictionary(c => c.Id.Id, c => c.SectionId);
297
298 foreach (var featureComponentSymbol in resolvedSection.Symbols.OfType<FeatureComponentsSymbol>())
299 {
300 if (componentSectionIds.TryGetValue(featureComponentSymbol.ComponentRef, out var componentSectionId))
301 {
302 featureComponentSymbol.SectionId = componentSectionId;
303 }
304 }
305#endif
306 }
307
308 // Copy the wix variable rows to the output now that all overriding has been accounted for. 279 // Copy the wix variable rows to the output now that all overriding has been accounted for.
309 foreach (var symbol in wixVariables.Values) 280 foreach (var symbol in wixVariables.Values)
310 { 281 {