diff options
| author | Bob Arnson <bob@firegiant.com> | 2024-09-03 14:25:04 -0400 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2024-10-04 12:58:59 -0700 |
| commit | ae879a638643fd34bd1917160f94268930e15b7d (patch) | |
| tree | 8edb88578274baada86b730c2ab3adfdf2b84d49 | |
| parent | 7c7d8269c4edce3307fdc9a1e93eb07f44f4b95b (diff) | |
| download | wix-ae879a638643fd34bd1917160f94268930e15b7d.tar.gz wix-ae879a638643fd34bd1917160f94268930e15b7d.tar.bz2 wix-ae879a638643fd34bd1917160f94268930e15b7d.zip | |
Fix crash with use of File/@PatchGroup.
| -rw-r--r-- | src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs | 2 | ||||
| -rw-r--r-- | src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs b/src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs index e0ed56b1..8cf2df3a 100644 --- a/src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs +++ b/src/wix/WixToolset.Core.WindowsInstaller/Bind/UpdateMediaSequencesCommand.cs | |||
| @@ -60,7 +60,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 60 | 60 | ||
| 61 | if (facade.PatchGroup.HasValue) | 61 | if (facade.PatchGroup.HasValue) |
| 62 | { | 62 | { |
| 63 | if (patchGroups.TryGetValue(facade.PatchGroup.Value, out var patchGroup)) | 63 | if (!patchGroups.TryGetValue(facade.PatchGroup.Value, out var patchGroup)) |
| 64 | { | 64 | { |
| 65 | patchGroup = new List<IFileFacade>(); | 65 | patchGroup = new List<IFileFacade>(); |
| 66 | patchGroups.Add(facade.PatchGroup.Value, patchGroup); | 66 | patchGroups.Add(facade.PatchGroup.Value, patchGroup); |
diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs index 5cab1dbd..1e2efb40 100644 --- a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs +++ b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs | |||
| @@ -17,7 +17,7 @@ | |||
| 17 | <Fragment> | 17 | <Fragment> |
| 18 | <ComponentGroup Id="Components" Directory="INSTALLFOLDER"> | 18 | <ComponentGroup Id="Components" Directory="INSTALLFOLDER"> |
| 19 | <Component> | 19 | <Component> |
| 20 | <File Source="$(sys.SOURCEFILEPATH)" /> | 20 | <File PatchGroup="22" Source="$(sys.SOURCEFILEPATH)" /> |
| 21 | </Component> | 21 | </Component> |
| 22 | 22 | ||
| 23 | <Component> | 23 | <Component> |