aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBob Arnson <bob@firegiant.com>2024-02-27 18:17:33 -0500
committerBob Arnson <github@bobs.org>2024-02-27 19:04:03 -0500
commitb62127f2f458d15ca22ff2a5398f5ed80c72a6a6 (patch)
tree77ff69165e53eff75b84b0daa9b882846840b1d0
parentd1b711af0d33713f29f583f9c9a17b54d9a90df3 (diff)
downloadwix-b62127f2f458d15ca22ff2a5398f5ed80c72a6a6.tar.gz
wix-b62127f2f458d15ca22ff2a5398f5ed80c72a6a6.tar.bz2
wix-b62127f2f458d15ca22ff2a5398f5ed80c72a6a6.zip
Decompile null Message column in Error table.
-rw-r--r--src/wix/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs2
-rw-r--r--src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ExpectedUI.wxs1
-rw-r--r--src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ui.msibin290816 -> 290816 bytes
3 files changed, 2 insertions, 1 deletions
diff --git a/src/wix/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs b/src/wix/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs
index e3609b30..788e87b8 100644
--- a/src/wix/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs
+++ b/src/wix/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs
@@ -4506,7 +4506,7 @@ namespace WixToolset.Core.WindowsInstaller.Decompile
4506 { 4506 {
4507 var xError = new XElement(Names.ErrorElement, 4507 var xError = new XElement(Names.ErrorElement,
4508 new XAttribute("Id", row.FieldAsString(0)), 4508 new XAttribute("Id", row.FieldAsString(0)),
4509 new XAttribute("Message", row.FieldAsString(1))); 4509 row.IsColumnNull(1) ? null : new XAttribute("Message", row.FieldAsString(1)));
4510 4510
4511 this.UIElement.Add(xError); 4511 this.UIElement.Add(xError);
4512 } 4512 }
diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ExpectedUI.wxs b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ExpectedUI.wxs
index 38aa2e7a..7c90971a 100644
--- a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ExpectedUI.wxs
+++ b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ExpectedUI.wxs
@@ -542,6 +542,7 @@
542 </UI> 542 </UI>
543 <CustomAction Id="WixUIValidatePath" Return="ignore" BinaryRef="WixUIWixca" DllEntry="ValidatePath" /> 543 <CustomAction Id="WixUIValidatePath" Return="ignore" BinaryRef="WixUIWixca" DllEntry="ValidatePath" />
544 <CustomAction Id="WixUIPrintEula" Return="ignore" BinaryRef="WixUIWixca" DllEntry="PrintEula" /> 544 <CustomAction Id="WixUIPrintEula" Return="ignore" BinaryRef="WixUIWixca" DllEntry="PrintEula" />
545 <Error Id="123" />
545 <Feature Id="ProductFeature" Title="ui" Level="1"> 546 <Feature Id="ProductFeature" Title="ui" Level="1">
546 <ComponentRef Id="ProductComponent" /> 547 <ComponentRef Id="ProductComponent" />
547 </Feature> 548 </Feature>
diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ui.msi b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ui.msi
index 230cdb5d..4dea2b88 100644
--- a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ui.msi
+++ b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ui.msi
Binary files differ