diff options
| author | Rob Mensching <rob@firegiant.com> | 2021-04-02 14:41:49 -0700 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2021-04-02 14:58:00 -0700 |
| commit | 4449fcc5b8d104817c67135229682c66c3d892ca (patch) | |
| tree | 327f617de2e296ddb4e62c50bf07ec8b5dcf0a3e /src/WixToolset.Core/Compiler_Module.cs | |
| parent | 9cca339473d77c7036035f949239f5231c325968 (diff) | |
| download | wix-4449fcc5b8d104817c67135229682c66c3d892ca.tar.gz wix-4449fcc5b8d104817c67135229682c66c3d892ca.tar.bz2 wix-4449fcc5b8d104817c67135229682c66c3d892ca.zip | |
Enable codepages and languages to be set via .wxl files
Fixes wixtoolset/issues#5801
Diffstat (limited to 'src/WixToolset.Core/Compiler_Module.cs')
| -rw-r--r-- | src/WixToolset.Core/Compiler_Module.cs | 20 |
1 files changed, 5 insertions, 15 deletions
diff --git a/src/WixToolset.Core/Compiler_Module.cs b/src/WixToolset.Core/Compiler_Module.cs index 597bc25c..59fe9164 100644 --- a/src/WixToolset.Core/Compiler_Module.cs +++ b/src/WixToolset.Core/Compiler_Module.cs | |||
| @@ -104,7 +104,7 @@ namespace WixToolset.Core | |||
| 104 | try | 104 | try |
| 105 | { | 105 | { |
| 106 | this.compilingModule = true; // notice that we are actually building a Merge Module here | 106 | this.compilingModule = true; // notice that we are actually building a Merge Module here |
| 107 | this.Core.CreateActiveSection(this.activeName, SectionType.Module, codepage, this.Context.CompilationId); | 107 | this.Core.CreateActiveSection(this.activeName, SectionType.Module, this.Context.CompilationId); |
| 108 | 108 | ||
| 109 | foreach (var child in node.Elements()) | 109 | foreach (var child in node.Elements()) |
| 110 | { | 110 | { |
| @@ -232,15 +232,6 @@ namespace WixToolset.Core | |||
| 232 | 232 | ||
| 233 | if (!this.Core.EncounteredError) | 233 | if (!this.Core.EncounteredError) |
| 234 | { | 234 | { |
| 235 | if (!setCodepage) | ||
| 236 | { | ||
| 237 | this.Core.AddSymbol(new SummaryInformationSymbol(sourceLineNumbers) | ||
| 238 | { | ||
| 239 | PropertyId = SummaryInformationType.Codepage, | ||
| 240 | Value = "1252" | ||
| 241 | }); | ||
| 242 | } | ||
| 243 | |||
| 244 | if (!setPackageName) | 235 | if (!setPackageName) |
| 245 | { | 236 | { |
| 246 | this.Core.AddSymbol(new SummaryInformationSymbol(sourceLineNumbers) | 237 | this.Core.AddSymbol(new SummaryInformationSymbol(sourceLineNumbers) |
| @@ -259,21 +250,20 @@ namespace WixToolset.Core | |||
| 259 | }); | 250 | }); |
| 260 | } | 251 | } |
| 261 | 252 | ||
| 262 | var symbol = this.Core.AddSymbol(new ModuleSignatureSymbol(sourceLineNumbers, new Identifier(AccessModifier.Global, this.activeName, this.activeLanguage)) | 253 | var symbol = this.Core.AddSymbol(new WixModuleSymbol(sourceLineNumbers, new Identifier(AccessModifier.Global, this.activeName, this.activeLanguage)) |
| 263 | { | 254 | { |
| 264 | ModuleID = this.activeName, | 255 | ModuleId = this.activeName, |
| 256 | Language = this.activeLanguage, | ||
| 265 | Version = version | 257 | Version = version |
| 266 | }); | 258 | }); |
| 267 | 259 | ||
| 268 | symbol.Set((int)ModuleSignatureSymbolFields.Language, this.activeLanguage); | ||
| 269 | |||
| 270 | this.Core.AddSymbol(new SummaryInformationSymbol(sourceLineNumbers) | 260 | this.Core.AddSymbol(new SummaryInformationSymbol(sourceLineNumbers) |
| 271 | { | 261 | { |
| 272 | PropertyId = SummaryInformationType.PackageCode, | 262 | PropertyId = SummaryInformationType.PackageCode, |
| 273 | Value = moduleId | 263 | Value = moduleId |
| 274 | }); | 264 | }); |
| 275 | 265 | ||
| 276 | this.ValidateAndAddCommonSummaryInformationSymbols(sourceLineNumbers, msiVersion, platform); | 266 | this.ValidateAndAddCommonSummaryInformationSymbols(sourceLineNumbers, msiVersion, platform, this.activeLanguage); |
| 277 | } | 267 | } |
| 278 | } | 268 | } |
| 279 | finally | 269 | finally |
