aboutsummaryrefslogtreecommitdiff
path: root/src/WixToolset.Core/ExtensibilityServices
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2020-06-25 14:43:50 -0700
committerRob Mensching <rob@firegiant.com>2020-06-25 14:50:31 -0700
commit38afa9e7bc7eacc021f8805f607368a05751e3c3 (patch)
tree803b0a8d9a06a7d6f7c4df408437017ae21a883e /src/WixToolset.Core/ExtensibilityServices
parent8968578d50858721317d410549a9f9b5c62bf1f7 (diff)
downloadwix-38afa9e7bc7eacc021f8805f607368a05751e3c3.tar.gz
wix-38afa9e7bc7eacc021f8805f607368a05751e3c3.tar.bz2
wix-38afa9e7bc7eacc021f8805f607368a05751e3c3.zip
The Great Tuple to Symbol Rename (tm)
Diffstat (limited to 'src/WixToolset.Core/ExtensibilityServices')
-rw-r--r--src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs126
-rw-r--r--src/WixToolset.Core/ExtensibilityServices/TupleDefinitionCreator.cs24
2 files changed, 75 insertions, 75 deletions
diff --git a/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs b/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs
index 3c092bd4..7160c32e 100644
--- a/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs
+++ b/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs
@@ -12,7 +12,7 @@ namespace WixToolset.Core.ExtensibilityServices
12 using System.Text.RegularExpressions; 12 using System.Text.RegularExpressions;
13 using System.Xml.Linq; 13 using System.Xml.Linq;
14 using WixToolset.Data; 14 using WixToolset.Data;
15 using WixToolset.Data.Tuples; 15 using WixToolset.Data.Symbols;
16 using WixToolset.Data.WindowsInstaller; 16 using WixToolset.Data.WindowsInstaller;
17 using WixToolset.Extensibility; 17 using WixToolset.Extensibility;
18 using WixToolset.Extensibility.Data; 18 using WixToolset.Extensibility.Data;
@@ -44,7 +44,7 @@ namespace WixToolset.Core.ExtensibilityServices
44 44
45 private IMessaging Messaging { get; } 45 private IMessaging Messaging { get; }
46 46
47 private ITupleDefinitionCreator Creator { get; set; } 47 private ISymbolDefinitionCreator Creator { get; set; }
48 48
49 public bool ContainsProperty(string possibleProperty) 49 public bool ContainsProperty(string possibleProperty)
50 { 50 {
@@ -54,7 +54,7 @@ namespace WixToolset.Core.ExtensibilityServices
54 public void CreateComplexReference(IntermediateSection section, SourceLineNumber sourceLineNumbers, ComplexReferenceParentType parentType, string parentId, string parentLanguage, ComplexReferenceChildType childType, string childId, bool isPrimary) 54 public void CreateComplexReference(IntermediateSection section, SourceLineNumber sourceLineNumbers, ComplexReferenceParentType parentType, string parentId, string parentLanguage, ComplexReferenceChildType childType, string childId, bool isPrimary)
55 { 55 {
56 56
57 section.AddTuple(new WixComplexReferenceTuple(sourceLineNumbers) 57 section.AddSymbol(new WixComplexReferenceSymbol(sourceLineNumbers)
58 { 58 {
59 Parent = parentId, 59 Parent = parentId,
60 ParentType = parentType, 60 ParentType = parentType,
@@ -64,16 +64,16 @@ namespace WixToolset.Core.ExtensibilityServices
64 IsPrimary = isPrimary 64 IsPrimary = isPrimary
65 }); 65 });
66 66
67 this.CreateWixGroupTuple(section, sourceLineNumbers, parentType, parentId, childType, childId); 67 this.CreateWixGroupSymbol(section, sourceLineNumbers, parentType, parentId, childType, childId);
68 } 68 }
69 69
70 [Obsolete] 70 [Obsolete]
71 public Identifier CreateDirectoryRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, Identifier id, string parentId, string name, ISet<string> sectionInlinedDirectoryIds, string shortName = null, string sourceName = null, string shortSourceName = null) 71 public Identifier CreateDirectoryRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, Identifier id, string parentId, string name, ISet<string> sectionInlinedDirectoryIds, string shortName = null, string sourceName = null, string shortSourceName = null)
72 { 72 {
73 return this.CreateDirectoryTuple(section, sourceLineNumbers, id, parentId, name, sectionInlinedDirectoryIds, shortName, sourceName, shortSourceName); 73 return this.CreateDirectorySymbol(section, sourceLineNumbers, id, parentId, name, sectionInlinedDirectoryIds, shortName, sourceName, shortSourceName);
74 } 74 }
75 75
76 public Identifier CreateDirectoryTuple(IntermediateSection section, SourceLineNumber sourceLineNumbers, Identifier id, string parentId, string name, ISet<string> sectionInlinedDirectoryIds, string shortName = null, string sourceName = null, string shortSourceName = null) 76 public Identifier CreateDirectorySymbol(IntermediateSection section, SourceLineNumber sourceLineNumbers, Identifier id, string parentId, string name, ISet<string> sectionInlinedDirectoryIds, string shortName = null, string sourceName = null, string shortSourceName = null)
77 { 77 {
78 if (String.IsNullOrEmpty(shortName) && !name.Equals("SourceDir") && !this.IsValidShortFilename(name)) 78 if (String.IsNullOrEmpty(shortName) && !name.Equals("SourceDir") && !this.IsValidShortFilename(name))
79 { 79 {
@@ -86,7 +86,7 @@ namespace WixToolset.Core.ExtensibilityServices
86 } 86 }
87 87
88 // For anonymous directories, create the identifier. If this identifier already exists in the 88 // For anonymous directories, create the identifier. If this identifier already exists in the
89 // active section, bail so we don't add duplicate anonymous directory tuples (which are legal 89 // active section, bail so we don't add duplicate anonymous directory symbols (which are legal
90 // but bloat the intermediate and ultimately make the linker do "busy work"). 90 // but bloat the intermediate and ultimately make the linker do "busy work").
91 if (null == id) 91 if (null == id)
92 { 92 {
@@ -98,7 +98,7 @@ namespace WixToolset.Core.ExtensibilityServices
98 } 98 }
99 } 99 }
100 100
101 var tuple = section.AddTuple(new DirectoryTuple(sourceLineNumbers, id) 101 var symbol = section.AddSymbol(new DirectorySymbol(sourceLineNumbers, id)
102 { 102 {
103 ParentDirectoryRef = parentId, 103 ParentDirectoryRef = parentId,
104 Name = name, 104 Name = name,
@@ -107,7 +107,7 @@ namespace WixToolset.Core.ExtensibilityServices
107 SourceShortName = shortSourceName 107 SourceShortName = shortSourceName
108 }); 108 });
109 109
110 return tuple.Id; 110 return symbol.Id;
111 } 111 }
112 112
113 public string CreateDirectoryReferenceFromInlineSyntax(IntermediateSection section, SourceLineNumber sourceLineNumbers, string parentId, XAttribute attribute, ISet<string> sectionInlinedDirectoryIds) 113 public string CreateDirectoryReferenceFromInlineSyntax(IntermediateSection section, SourceLineNumber sourceLineNumbers, string parentId, XAttribute attribute, ISet<string> sectionInlinedDirectoryIds)
@@ -122,9 +122,9 @@ namespace WixToolset.Core.ExtensibilityServices
122 if (1 == inlineSyntax.Length) 122 if (1 == inlineSyntax.Length)
123 { 123 {
124 id = inlineSyntax[0]; 124 id = inlineSyntax[0];
125 this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.Directory, id); 125 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.Directory, id);
126 } 126 }
127 else // start creating tuples for the entries in the inline syntax 127 else // start creating symbols for the entries in the inline syntax
128 { 128 {
129 id = parentId; 129 id = parentId;
130 130
@@ -138,14 +138,14 @@ namespace WixToolset.Core.ExtensibilityServices
138 //} 138 //}
139 139
140 id = inlineSyntax[0].TrimEnd(':'); 140 id = inlineSyntax[0].TrimEnd(':');
141 this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.Directory, id); 141 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.Directory, id);
142 142
143 pathStartsAt = 1; 143 pathStartsAt = 1;
144 } 144 }
145 145
146 for (var i = pathStartsAt; i < inlineSyntax.Length; ++i) 146 for (var i = pathStartsAt; i < inlineSyntax.Length; ++i)
147 { 147 {
148 var inlineId = this.CreateDirectoryTuple(section, sourceLineNumbers, null, id, inlineSyntax[i], sectionInlinedDirectoryIds); 148 var inlineId = this.CreateDirectorySymbol(section, sourceLineNumbers, null, id, inlineSyntax[i], sectionInlinedDirectoryIds);
149 id = inlineId.Id; 149 id = inlineId.Id;
150 } 150 }
151 } 151 }
@@ -174,10 +174,10 @@ namespace WixToolset.Core.ExtensibilityServices
174 [Obsolete] 174 [Obsolete]
175 public Identifier CreateRegistryRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, RegistryRootType root, string key, string name, string value, string componentId, bool escapeLeadingHash) 175 public Identifier CreateRegistryRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, RegistryRootType root, string key, string name, string value, string componentId, bool escapeLeadingHash)
176 { 176 {
177 return this.CreateRegistryTuple(section, sourceLineNumbers, root, key, name, value, componentId, escapeLeadingHash); 177 return this.CreateRegistrySymbol(section, sourceLineNumbers, root, key, name, value, componentId, escapeLeadingHash);
178 } 178 }
179 179
180 public Identifier CreateRegistryTuple(IntermediateSection section, SourceLineNumber sourceLineNumbers, RegistryRootType root, string key, string name, string value, string componentId, bool escapeLeadingHash) 180 public Identifier CreateRegistrySymbol(IntermediateSection section, SourceLineNumber sourceLineNumbers, RegistryRootType root, string key, string name, string value, string componentId, bool escapeLeadingHash)
181 { 181 {
182 if (RegistryRootType.Unknown == root) 182 if (RegistryRootType.Unknown == root)
183 { 183 {
@@ -202,7 +202,7 @@ namespace WixToolset.Core.ExtensibilityServices
202 202
203 var id = this.CreateIdentifier("reg", componentId, ((int)root).ToString(CultureInfo.InvariantCulture.NumberFormat), key.ToLowerInvariant(), (null != name ? name.ToLowerInvariant() : name)); 203 var id = this.CreateIdentifier("reg", componentId, ((int)root).ToString(CultureInfo.InvariantCulture.NumberFormat), key.ToLowerInvariant(), (null != name ? name.ToLowerInvariant() : name));
204 204
205 var tuple = section.AddTuple(new RegistryTuple(sourceLineNumbers, id) 205 var symbol = section.AddSymbol(new RegistrySymbol(sourceLineNumbers, id)
206 { 206 {
207 Root = root, 207 Root = root,
208 Key = key, 208 Key = key,
@@ -211,30 +211,30 @@ namespace WixToolset.Core.ExtensibilityServices
211 ComponentRef = componentId, 211 ComponentRef = componentId,
212 }); 212 });
213 213
214 return tuple.Id; 214 return symbol.Id;
215 } 215 }
216 216
217 public void CreateSimpleReference(IntermediateSection section, SourceLineNumber sourceLineNumbers, string tupleName, params string[] primaryKeys) 217 public void CreateSimpleReference(IntermediateSection section, SourceLineNumber sourceLineNumbers, string symbolName, params string[] primaryKeys)
218 { 218 {
219 section.AddTuple(new WixSimpleReferenceTuple(sourceLineNumbers) 219 section.AddSymbol(new WixSimpleReferenceSymbol(sourceLineNumbers)
220 { 220 {
221 Table = tupleName, 221 Table = symbolName,
222 PrimaryKeys = String.Join("/", primaryKeys) 222 PrimaryKeys = String.Join("/", primaryKeys)
223 }); 223 });
224 } 224 }
225 225
226 public void CreateSimpleReference(IntermediateSection section, SourceLineNumber sourceLineNumbers, IntermediateTupleDefinition tupleDefinition, params string[] primaryKeys) 226 public void CreateSimpleReference(IntermediateSection section, SourceLineNumber sourceLineNumbers, IntermediateSymbolDefinition symbolDefinition, params string[] primaryKeys)
227 { 227 {
228 this.CreateSimpleReference(section, sourceLineNumbers, tupleDefinition.Name, primaryKeys); 228 this.CreateSimpleReference(section, sourceLineNumbers, symbolDefinition.Name, primaryKeys);
229 } 229 }
230 230
231 [Obsolete] 231 [Obsolete]
232 public void CreateWixGroupRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, ComplexReferenceParentType parentType, string parentId, ComplexReferenceChildType childType, string childId) 232 public void CreateWixGroupRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, ComplexReferenceParentType parentType, string parentId, ComplexReferenceChildType childType, string childId)
233 { 233 {
234 this.CreateWixGroupTuple(section, sourceLineNumbers, parentType, parentId, childType, childId); 234 this.CreateWixGroupSymbol(section, sourceLineNumbers, parentType, parentId, childType, childId);
235 } 235 }
236 236
237 public void CreateWixGroupTuple(IntermediateSection section, SourceLineNumber sourceLineNumbers, ComplexReferenceParentType parentType, string parentId, ComplexReferenceChildType childType, string childId) 237 public void CreateWixGroupSymbol(IntermediateSection section, SourceLineNumber sourceLineNumbers, ComplexReferenceParentType parentType, string parentId, ComplexReferenceChildType childType, string childId)
238 { 238 {
239 if (null == parentId || ComplexReferenceParentType.Unknown == parentType) 239 if (null == parentId || ComplexReferenceParentType.Unknown == parentType)
240 { 240 {
@@ -246,7 +246,7 @@ namespace WixToolset.Core.ExtensibilityServices
246 throw new ArgumentNullException("childId"); 246 throw new ArgumentNullException("childId");
247 } 247 }
248 248
249 section.AddTuple(new WixGroupTuple(sourceLineNumbers) 249 section.AddSymbol(new WixGroupSymbol(sourceLineNumbers)
250 { 250 {
251 ParentId = parentId, 251 ParentId = parentId,
252 ParentType = parentType, 252 ParentType = parentType,
@@ -255,7 +255,7 @@ namespace WixToolset.Core.ExtensibilityServices
255 }); 255 });
256 } 256 }
257 257
258 public void CreateWixSearchTuple(IntermediateSection section, SourceLineNumber sourceLineNumbers, string elementName, Identifier id, string variable, string condition, string after, string bundleExtensionId) 258 public void CreateWixSearchSymbol(IntermediateSection section, SourceLineNumber sourceLineNumbers, string elementName, Identifier id, string variable, string condition, string after, string bundleExtensionId)
259 { 259 {
260 // TODO: verify variable is not a standard bundle variable 260 // TODO: verify variable is not a standard bundle variable
261 if (variable == null) 261 if (variable == null)
@@ -263,7 +263,7 @@ namespace WixToolset.Core.ExtensibilityServices
263 this.Messaging.Write(ErrorMessages.ExpectedAttribute(sourceLineNumbers, elementName, "Variable")); 263 this.Messaging.Write(ErrorMessages.ExpectedAttribute(sourceLineNumbers, elementName, "Variable"));
264 } 264 }
265 265
266 section.AddTuple(new WixSearchTuple(sourceLineNumbers, id) 266 section.AddSymbol(new WixSearchSymbol(sourceLineNumbers, id)
267 { 267 {
268 Variable = variable, 268 Variable = variable,
269 Condition = condition, 269 Condition = condition,
@@ -272,20 +272,20 @@ namespace WixToolset.Core.ExtensibilityServices
272 272
273 if (after != null) 273 if (after != null)
274 { 274 {
275 this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.WixSearch, after); 275 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.WixSearch, after);
276 // TODO: We're currently defaulting to "always run after", which we will need to change... 276 // TODO: We're currently defaulting to "always run after", which we will need to change...
277 this.CreateWixSearchRelationTuple(section, sourceLineNumbers, id, after, 2); 277 this.CreateWixSearchRelationSymbol(section, sourceLineNumbers, id, after, 2);
278 } 278 }
279 279
280 if (!String.IsNullOrEmpty(bundleExtensionId)) 280 if (!String.IsNullOrEmpty(bundleExtensionId))
281 { 281 {
282 this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.WixBundleExtension, bundleExtensionId); 282 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.WixBundleExtension, bundleExtensionId);
283 } 283 }
284 } 284 }
285 285
286 public void CreateWixSearchRelationTuple(IntermediateSection section, SourceLineNumber sourceLineNumbers, Identifier id, string parentId, int attributes) 286 public void CreateWixSearchRelationSymbol(IntermediateSection section, SourceLineNumber sourceLineNumbers, Identifier id, string parentId, int attributes)
287 { 287 {
288 section.AddTuple(new WixSearchRelationTuple(sourceLineNumbers, id) 288 section.AddSymbol(new WixSearchRelationSymbol(sourceLineNumbers, id)
289 { 289 {
290 ParentSearchRef = parentId, 290 ParentSearchRef = parentId,
291 Attributes = attributes, 291 Attributes = attributes,
@@ -293,43 +293,43 @@ namespace WixToolset.Core.ExtensibilityServices
293 } 293 }
294 294
295 [Obsolete] 295 [Obsolete]
296 public IntermediateTuple CreateRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, string tableName, Identifier identifier = null) 296 public IntermediateSymbol CreateRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, string tableName, Identifier identifier = null)
297 { 297 {
298 return this.CreateTuple(section, sourceLineNumbers, tableName, identifier); 298 return this.CreateSymbol(section, sourceLineNumbers, tableName, identifier);
299 } 299 }
300 300
301 [Obsolete] 301 [Obsolete]
302 public IntermediateTuple CreateRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, TupleDefinitionType tupleType, Identifier identifier = null) 302 public IntermediateSymbol CreateRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, SymbolDefinitionType symbolType, Identifier identifier = null)
303 { 303 {
304 return this.CreateTuple(section, sourceLineNumbers, tupleType, identifier); 304 return this.CreateSymbol(section, sourceLineNumbers, symbolType, identifier);
305 } 305 }
306 306
307 public IntermediateTuple CreateTuple(IntermediateSection section, SourceLineNumber sourceLineNumbers, string tupleName, Identifier identifier = null) 307 public IntermediateSymbol CreateSymbol(IntermediateSection section, SourceLineNumber sourceLineNumbers, string symbolName, Identifier identifier = null)
308 { 308 {
309 if (this.Creator == null) 309 if (this.Creator == null)
310 { 310 {
311 this.CreateTupleDefinitionCreator(); 311 this.CreateSymbolDefinitionCreator();
312 } 312 }
313 313
314 if (!this.Creator.TryGetTupleDefinitionByName(tupleName, out var tupleDefinition)) 314 if (!this.Creator.TryGetSymbolDefinitionByName(symbolName, out var symbolDefinition))
315 { 315 {
316 throw new ArgumentException(nameof(tupleName)); 316 throw new ArgumentException(nameof(symbolName));
317 } 317 }
318 318
319 return this.CreateTuple(section, sourceLineNumbers, tupleDefinition, identifier); 319 return this.CreateSymbol(section, sourceLineNumbers, symbolDefinition, identifier);
320 } 320 }
321 321
322 [Obsolete] 322 [Obsolete]
323 public IntermediateTuple CreateTuple(IntermediateSection section, SourceLineNumber sourceLineNumbers, TupleDefinitionType tupleType, Identifier identifier = null) 323 public IntermediateSymbol CreateSymbol(IntermediateSection section, SourceLineNumber sourceLineNumbers, SymbolDefinitionType symbolType, Identifier identifier = null)
324 { 324 {
325 var tupleDefinition = TupleDefinitions.ByType(tupleType); 325 var symbolDefinition = SymbolDefinitions.ByType(symbolType);
326 326
327 return this.CreateTuple(section, sourceLineNumbers, tupleDefinition, identifier); 327 return this.CreateSymbol(section, sourceLineNumbers, symbolDefinition, identifier);
328 } 328 }
329 329
330 public IntermediateTuple CreateTuple(IntermediateSection section, SourceLineNumber sourceLineNumbers, IntermediateTupleDefinition tupleDefinition, Identifier identifier = null) 330 public IntermediateSymbol CreateSymbol(IntermediateSection section, SourceLineNumber sourceLineNumbers, IntermediateSymbolDefinition symbolDefinition, Identifier identifier = null)
331 { 331 {
332 return section.AddTuple(tupleDefinition.CreateTuple(sourceLineNumbers, identifier)); 332 return section.AddSymbol(symbolDefinition.CreateSymbol(sourceLineNumbers, identifier));
333 } 333 }
334 334
335 public string CreateShortName(string longName, bool keepExtension, bool allowWildcards, params string[] args) 335 public string CreateShortName(string longName, bool keepExtension, bool allowWildcards, params string[] args)
@@ -384,34 +384,34 @@ namespace WixToolset.Core.ExtensibilityServices
384 384
385 public void EnsureTable(IntermediateSection section, SourceLineNumber sourceLineNumbers, TableDefinition tableDefinition) 385 public void EnsureTable(IntermediateSection section, SourceLineNumber sourceLineNumbers, TableDefinition tableDefinition)
386 { 386 {
387 section.AddTuple(new WixEnsureTableTuple(sourceLineNumbers) 387 section.AddSymbol(new WixEnsureTableSymbol(sourceLineNumbers)
388 { 388 {
389 Table = tableDefinition.Name, 389 Table = tableDefinition.Name,
390 }); 390 });
391 391
392 // TODO: Check if the given table definition is a custom table. For now we have to assume that it isn't. 392 // TODO: Check if the given table definition is a custom table. For now we have to assume that it isn't.
393 //this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.WixCustomTable, tableDefinition.Name); 393 //this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.WixCustomTable, tableDefinition.Name);
394 } 394 }
395 395
396 public void EnsureTable(IntermediateSection section, SourceLineNumber sourceLineNumbers, string tableName) 396 public void EnsureTable(IntermediateSection section, SourceLineNumber sourceLineNumbers, string tableName)
397 { 397 {
398 section.AddTuple(new WixEnsureTableTuple(sourceLineNumbers) 398 section.AddSymbol(new WixEnsureTableSymbol(sourceLineNumbers)
399 { 399 {
400 Table = tableName, 400 Table = tableName,
401 }); 401 });
402 402
403 if (this.Creator == null) 403 if (this.Creator == null)
404 { 404 {
405 this.CreateTupleDefinitionCreator(); 405 this.CreateSymbolDefinitionCreator();
406 } 406 }
407 407
408 // TODO: The tableName may not be the same as the tupleName. For now, we have to assume that it is. 408 // TODO: The tableName may not be the same as the symbolName. For now, we have to assume that it is.
409 // We don't add custom table definitions to the tableDefinitions collection, 409 // We don't add custom table definitions to the tableDefinitions collection,
410 // so if it's not in there, it better be a custom table. If the Id is just wrong, 410 // so if it's not in there, it better be a custom table. If the Id is just wrong,
411 // instead of a custom table, we get an unresolved reference at link time. 411 // instead of a custom table, we get an unresolved reference at link time.
412 if (!this.Creator.TryGetTupleDefinitionByName(tableName, out var _)) 412 if (!this.Creator.TryGetSymbolDefinitionByName(tableName, out var _))
413 { 413 {
414 this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.WixCustomTable, tableName); 414 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.WixCustomTable, tableName);
415 } 415 }
416 } 416 }
417 417
@@ -898,11 +898,11 @@ namespace WixToolset.Core.ExtensibilityServices
898 } 898 }
899 } 899 }
900 900
901 public WixActionTuple ScheduleActionTuple(IntermediateSection section, SourceLineNumber sourceLineNumbers, AccessModifier access, SequenceTable sequence, string actionName, string condition, string beforeAction, string afterAction, bool overridable = false) 901 public WixActionSymbol ScheduleActionSymbol(IntermediateSection section, SourceLineNumber sourceLineNumbers, AccessModifier access, SequenceTable sequence, string actionName, string condition, string beforeAction, string afterAction, bool overridable = false)
902 { 902 {
903 var actionId = new Identifier(access, sequence, actionName); 903 var actionId = new Identifier(access, sequence, actionName);
904 904
905 var actionTuple = section.AddTuple(new WixActionTuple(sourceLineNumbers, actionId) 905 var actionSymbol = section.AddSymbol(new WixActionSymbol(sourceLineNumbers, actionId)
906 { 906 {
907 SequenceTable = sequence, 907 SequenceTable = sequence,
908 Action = actionName, 908 Action = actionName,
@@ -916,11 +916,11 @@ namespace WixToolset.Core.ExtensibilityServices
916 { 916 {
917 if (WindowsInstallerStandard.IsStandardAction(beforeAction)) 917 if (WindowsInstallerStandard.IsStandardAction(beforeAction))
918 { 918 {
919 this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.WixAction, sequence.ToString(), beforeAction); 919 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.WixAction, sequence.ToString(), beforeAction);
920 } 920 }
921 else 921 else
922 { 922 {
923 this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.CustomAction, beforeAction); 923 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.CustomAction, beforeAction);
924 } 924 }
925 } 925 }
926 926
@@ -928,15 +928,15 @@ namespace WixToolset.Core.ExtensibilityServices
928 { 928 {
929 if (WindowsInstallerStandard.IsStandardAction(afterAction)) 929 if (WindowsInstallerStandard.IsStandardAction(afterAction))
930 { 930 {
931 this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.WixAction, sequence.ToString(), afterAction); 931 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.WixAction, sequence.ToString(), afterAction);
932 } 932 }
933 else 933 else
934 { 934 {
935 this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.CustomAction, afterAction); 935 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.CustomAction, afterAction);
936 } 936 }
937 } 937 }
938 938
939 return actionTuple; 939 return actionSymbol;
940 } 940 }
941 941
942 public void CreateCustomActionReference(SourceLineNumber sourceLineNumbers, IntermediateSection section, string customAction, Platform currentPlatform, CustomActionPlatforms supportedPlatforms) 942 public void CreateCustomActionReference(SourceLineNumber sourceLineNumbers, IntermediateSection section, string customAction, Platform currentPlatform, CustomActionPlatforms supportedPlatforms)
@@ -968,7 +968,7 @@ namespace WixToolset.Core.ExtensibilityServices
968 break; 968 break;
969 } 969 }
970 970
971 this.CreateSimpleReference(section, sourceLineNumbers, TupleDefinitions.CustomAction, name + suffix); 971 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.CustomAction, name + suffix);
972 } 972 }
973 } 973 }
974 974
@@ -984,9 +984,9 @@ namespace WixToolset.Core.ExtensibilityServices
984 this.Messaging.Write(ErrorMessages.UnexpectedElement(sourceLineNumbers, parentElement.Name.LocalName, childElement.Name.LocalName)); 984 this.Messaging.Write(ErrorMessages.UnexpectedElement(sourceLineNumbers, parentElement.Name.LocalName, childElement.Name.LocalName));
985 } 985 }
986 986
987 private void CreateTupleDefinitionCreator() 987 private void CreateSymbolDefinitionCreator()
988 { 988 {
989 this.Creator = this.ServiceProvider.GetService<ITupleDefinitionCreator>(); 989 this.Creator = this.ServiceProvider.GetService<ISymbolDefinitionCreator>();
990 } 990 }
991 991
992 private static bool TryFindExtension(IEnumerable<ICompilerExtension> extensions, XNamespace ns, out ICompilerExtension extension) 992 private static bool TryFindExtension(IEnumerable<ICompilerExtension> extensions, XNamespace ns, out ICompilerExtension extension)
diff --git a/src/WixToolset.Core/ExtensibilityServices/TupleDefinitionCreator.cs b/src/WixToolset.Core/ExtensibilityServices/TupleDefinitionCreator.cs
index 7ef72afc..2bff21d6 100644
--- a/src/WixToolset.Core/ExtensibilityServices/TupleDefinitionCreator.cs
+++ b/src/WixToolset.Core/ExtensibilityServices/TupleDefinitionCreator.cs
@@ -8,9 +8,9 @@ namespace WixToolset.Core.ExtensibilityServices
8 using WixToolset.Extensibility; 8 using WixToolset.Extensibility;
9 using WixToolset.Extensibility.Services; 9 using WixToolset.Extensibility.Services;
10 10
11 internal class TupleDefinitionCreator : ITupleDefinitionCreator 11 internal class SymbolDefinitionCreator : ISymbolDefinitionCreator
12 { 12 {
13 public TupleDefinitionCreator(IWixToolsetServiceProvider serviceProvider) 13 public SymbolDefinitionCreator(IWixToolsetServiceProvider serviceProvider)
14 { 14 {
15 this.ServiceProvider = serviceProvider; 15 this.ServiceProvider = serviceProvider;
16 } 16 }
@@ -19,9 +19,9 @@ namespace WixToolset.Core.ExtensibilityServices
19 19
20 private IEnumerable<IExtensionData> ExtensionData { get; set; } 20 private IEnumerable<IExtensionData> ExtensionData { get; set; }
21 21
22 private Dictionary<string, IntermediateTupleDefinition> CustomDefinitionByName { get; } = new Dictionary<string, IntermediateTupleDefinition>(); 22 private Dictionary<string, IntermediateSymbolDefinition> CustomDefinitionByName { get; } = new Dictionary<string, IntermediateSymbolDefinition>();
23 23
24 public void AddCustomTupleDefinition(IntermediateTupleDefinition definition) 24 public void AddCustomSymbolDefinition(IntermediateSymbolDefinition definition)
25 { 25 {
26 if (!this.CustomDefinitionByName.TryGetValue(definition.Name, out var existing) || definition.Revision > existing.Revision) 26 if (!this.CustomDefinitionByName.TryGetValue(definition.Name, out var existing) || definition.Revision > existing.Revision)
27 { 27 {
@@ -29,12 +29,12 @@ namespace WixToolset.Core.ExtensibilityServices
29 } 29 }
30 } 30 }
31 31
32 public bool TryGetTupleDefinitionByName(string name, out IntermediateTupleDefinition tupleDefinition) 32 public bool TryGetSymbolDefinitionByName(string name, out IntermediateSymbolDefinition symbolDefinition)
33 { 33 {
34 // First, look in the built-ins. 34 // First, look in the built-ins.
35 tupleDefinition = TupleDefinitions.ByName(name); 35 symbolDefinition = SymbolDefinitions.ByName(name);
36 36
37 if (tupleDefinition == null) 37 if (symbolDefinition == null)
38 { 38 {
39 if (this.ExtensionData == null) 39 if (this.ExtensionData == null)
40 { 40 {
@@ -44,20 +44,20 @@ namespace WixToolset.Core.ExtensibilityServices
44 // Second, look in the extensions. 44 // Second, look in the extensions.
45 foreach (var data in this.ExtensionData) 45 foreach (var data in this.ExtensionData)
46 { 46 {
47 if (data.TryGetTupleDefinitionByName(name, out tupleDefinition)) 47 if (data.TryGetSymbolDefinitionByName(name, out symbolDefinition))
48 { 48 {
49 break; 49 break;
50 } 50 }
51 } 51 }
52 52
53 // Finally, look in the custom tuple definitions provided during an intermediate load. 53 // Finally, look in the custom symbol definitions provided during an intermediate load.
54 if (tupleDefinition == null) 54 if (symbolDefinition == null)
55 { 55 {
56 this.CustomDefinitionByName.TryGetValue(name, out tupleDefinition); 56 this.CustomDefinitionByName.TryGetValue(name, out symbolDefinition);
57 } 57 }
58 } 58 }
59 59
60 return tupleDefinition != null; 60 return symbolDefinition != null;
61 } 61 }
62 62
63 private void LoadExtensionData() 63 private void LoadExtensionData()