diff options
| author | Rob Mensching <rob@firegiant.com> | 2019-10-16 17:04:28 -0700 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2019-10-18 11:34:46 -0700 |
| commit | 7d699fdbbe8a15c72b69f633ac9799fb757e2acc (patch) | |
| tree | 2638bd4694a849e23d5156521c21057460c2c5d1 /src/WixToolset.Core | |
| parent | 9ca5e0a95d0858a177fe1efdc15a962e5f7c1d84 (diff) | |
| download | wix-7d699fdbbe8a15c72b69f633ac9799fb757e2acc.tar.gz wix-7d699fdbbe8a15c72b69f633ac9799fb757e2acc.tar.bz2 wix-7d699fdbbe8a15c72b69f633ac9799fb757e2acc.zip | |
Several fixes
Diffstat (limited to 'src/WixToolset.Core')
| -rw-r--r-- | src/WixToolset.Core/Compiler_2.cs | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/WixToolset.Core/Compiler_2.cs b/src/WixToolset.Core/Compiler_2.cs index 7eeb2e2e..740219cb 100644 --- a/src/WixToolset.Core/Compiler_2.cs +++ b/src/WixToolset.Core/Compiler_2.cs | |||
| @@ -1297,7 +1297,7 @@ namespace WixToolset.Core | |||
| 1297 | { | 1297 | { |
| 1298 | this.Core.Write(ErrorMessages.AdvertiseStateMustMatch(sourceLineNumbers, advertise.ToString(), progIdAdvertise.ToString())); | 1298 | this.Core.Write(ErrorMessages.AdvertiseStateMustMatch(sourceLineNumbers, advertise.ToString(), progIdAdvertise.ToString())); |
| 1299 | } | 1299 | } |
| 1300 | else | 1300 | else if (YesNoType.NotSet != progIdAdvertise) |
| 1301 | { | 1301 | { |
| 1302 | advertise = progIdAdvertise; | 1302 | advertise = progIdAdvertise; |
| 1303 | } | 1303 | } |
| @@ -2020,6 +2020,7 @@ namespace WixToolset.Core | |||
| 2020 | var tuple = new RegistryTuple(sourceLineNumbers, id) | 2020 | var tuple = new RegistryTuple(sourceLineNumbers, id) |
| 2021 | { | 2021 | { |
| 2022 | Root = root.Value, | 2022 | Root = root.Value, |
| 2023 | Key = key, | ||
| 2023 | Name = name, | 2024 | Name = name, |
| 2024 | Value = value, | 2025 | Value = value, |
| 2025 | ValueType = valueType, | 2026 | ValueType = valueType, |
| @@ -4923,7 +4924,7 @@ namespace WixToolset.Core | |||
| 4923 | 4924 | ||
| 4924 | // Ensure that RemoveExistingProducts is authored in InstallExecuteSequence | 4925 | // Ensure that RemoveExistingProducts is authored in InstallExecuteSequence |
| 4925 | // if at least one row in Upgrade table lacks the OnlyDetect attribute. | 4926 | // if at least one row in Upgrade table lacks the OnlyDetect attribute. |
| 4926 | if (onlyDetect) | 4927 | if (!onlyDetect) |
| 4927 | { | 4928 | { |
| 4928 | this.Core.CreateSimpleReference(sourceLineNumbers, "WixAction", "InstallExecuteSequence", "RemoveExistingProducts"); | 4929 | this.Core.CreateSimpleReference(sourceLineNumbers, "WixAction", "InstallExecuteSequence", "RemoveExistingProducts"); |
| 4929 | } | 4930 | } |
