diff options
| author | Bob Arnson <bob@firegiant.com> | 2020-08-24 17:25:00 -0400 |
|---|---|---|
| committer | Bob Arnson <bob@firegiant.com> | 2020-08-24 18:57:49 -0400 |
| commit | c237bb3bb00d36c50271a70baac68f49890e35e1 (patch) | |
| tree | 25f90ddb7b74180fc3ef299c899585f24e88809f /src/WixToolset.Core | |
| parent | 2c040e2d5b401af3607cf6e482cffeaa511d167a (diff) | |
| download | wix-c237bb3bb00d36c50271a70baac68f49890e35e1.tar.gz wix-c237bb3bb00d36c50271a70baac68f49890e35e1.tar.bz2 wix-c237bb3bb00d36c50271a70baac68f49890e35e1.zip | |
Update decompiler to use XDocument rather than generated classes.
- Use CompareXml for diffing.
- Change CustomAction/@ScriptFile to @ScriptSourceFile.
Diffstat (limited to 'src/WixToolset.Core')
| -rw-r--r-- | src/WixToolset.Core/CommandLine/DecompileCommand.cs | 2 | ||||
| -rw-r--r-- | src/WixToolset.Core/Compiler.cs | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/WixToolset.Core/CommandLine/DecompileCommand.cs b/src/WixToolset.Core/CommandLine/DecompileCommand.cs index 1e11ae52..fc77a7b4 100644 --- a/src/WixToolset.Core/CommandLine/DecompileCommand.cs +++ b/src/WixToolset.Core/CommandLine/DecompileCommand.cs | |||
| @@ -33,7 +33,7 @@ namespace WixToolset.Core.CommandLine | |||
| 33 | 33 | ||
| 34 | public Task<int> ExecuteAsync(CancellationToken _) | 34 | public Task<int> ExecuteAsync(CancellationToken _) |
| 35 | { | 35 | { |
| 36 | if (this.commandLine.ShowHelp) | 36 | if (this.commandLine.ShowHelp || String.IsNullOrEmpty(this.commandLine.DecompileFilePath)) |
| 37 | { | 37 | { |
| 38 | Console.WriteLine("TODO: Show decompile command help"); | 38 | Console.WriteLine("TODO: Show decompile command help"); |
| 39 | return Task.FromResult(-1); | 39 | return Task.FromResult(-1); |
diff --git a/src/WixToolset.Core/Compiler.cs b/src/WixToolset.Core/Compiler.cs index c641bceb..6cc3a2e8 100644 --- a/src/WixToolset.Core/Compiler.cs +++ b/src/WixToolset.Core/Compiler.cs | |||
| @@ -3331,7 +3331,7 @@ namespace WixToolset.Core | |||
| 3331 | break; | 3331 | break; |
| 3332 | } | 3332 | } |
| 3333 | break; | 3333 | break; |
| 3334 | case "ScriptFile": | 3334 | case "ScriptSourceFile": |
| 3335 | scriptFile = this.Core.GetAttributeValue(sourceLineNumbers, attrib); | 3335 | scriptFile = this.Core.GetAttributeValue(sourceLineNumbers, attrib); |
| 3336 | break; | 3336 | break; |
| 3337 | case "SuppressModularization": | 3337 | case "SuppressModularization": |
| @@ -3387,7 +3387,7 @@ namespace WixToolset.Core | |||
| 3387 | { | 3387 | { |
| 3388 | if (String.IsNullOrEmpty(scriptFile)) | 3388 | if (String.IsNullOrEmpty(scriptFile)) |
| 3389 | { | 3389 | { |
| 3390 | this.Core.Write(ErrorMessages.ExpectedAttribute(sourceLineNumbers, node.Name.LocalName, "ScriptFile", "Script")); | 3390 | this.Core.Write(ErrorMessages.ExpectedAttribute(sourceLineNumbers, node.Name.LocalName, "ScriptSourceFile", "Script")); |
| 3391 | } | 3391 | } |
| 3392 | } | 3392 | } |
| 3393 | else if (CustomActionTargetType.VBScript == targetType) // non-inline vbscript | 3393 | else if (CustomActionTargetType.VBScript == targetType) // non-inline vbscript |
| @@ -3426,7 +3426,7 @@ namespace WixToolset.Core | |||
| 3426 | 3426 | ||
| 3427 | if (!inlineScript && !String.IsNullOrEmpty(scriptFile)) | 3427 | if (!inlineScript && !String.IsNullOrEmpty(scriptFile)) |
| 3428 | { | 3428 | { |
| 3429 | this.Core.Write(ErrorMessages.IllegalAttributeWithoutOtherAttributes(sourceLineNumbers, node.Name.LocalName, "ScriptFile", "Script")); | 3429 | this.Core.Write(ErrorMessages.IllegalAttributeWithoutOtherAttributes(sourceLineNumbers, node.Name.LocalName, "ScriptSourceFile", "Script")); |
| 3430 | } | 3430 | } |
| 3431 | 3431 | ||
| 3432 | if (win64 && CustomActionTargetType.VBScript != targetType && CustomActionTargetType.JScript != targetType) | 3432 | if (win64 && CustomActionTargetType.VBScript != targetType && CustomActionTargetType.JScript != targetType) |
