Finish the XML documentation in WixToolset.Mba.Core.

4623

1 files changed, 13 insertions, 1 deletions

diff --git a/src/api/burn/test/WixToolsetTest.Mba.Core/VerUtilFixture.cs b/src/api/burn/test/WixToolsetTest.Mba.Core/VerUtilFixture.cs
index 6fb8aced..9c213945 100644
--- a/src/api/burn/test/WixToolsetTest.Mba.Core/VerUtilFixture.cs
+++ b/src/api/burn/test/WixToolsetTest.Mba.Core/VerUtilFixture.cs
@@ -45,7 +45,7 @@ namespace WixToolsetTest.Mba.Core
         public void CanCreateFromQword()
         {
             var version = new Version(100, 200, 300, 400);
-            var qwVersion = Engine.VersionToLong(version);
+            var qwVersion = VersionToLong(version);
 
             using var parsedVersion = VerUtil.VersionFromQword(qwVersion);
             Assert.Equal("100.200.300.400", parsedVersion.Version);
@@ -99,5 +99,17 @@ namespace WixToolsetTest.Mba.Core
             Assert.True(parsedVersion.ReleaseLabels[4].IsNumeric);
             Assert.Equal(5u, parsedVersion.ReleaseLabels[4].Value);
         }
+
+        private static long VersionToLong(Version version)
+        {
+            // In Windows, each version component has a max value of 65535,
+            // so we truncate the version before shifting it, which will overflow if invalid.
+            long major = (long)(ushort)version.Major << 48;
+            long minor = (long)(ushort)version.Minor << 32;
+            long build = (long)(ushort)version.Build << 16;
+            long revision = (long)(ushort)version.Revision;
+
+            return major | minor | build | revision;
+        }
     }
 }