diff options
author | Rob Mensching <rob@firegiant.com> | 2024-12-29 18:01:20 -0800 |
---|---|---|
committer | Rob Mensching <rob@firegiant.com> | 2024-12-30 06:45:49 -0800 |
commit | 523c66a62a619e6aa9f30070173ea33edfb5e328 (patch) | |
tree | 04fa3146250b7eeaa6864b0f71e37905a2d77be1 /src/burn/engine/section.cpp | |
parent | 6edc5d1e2a289eac50c6d59a29e195353bb023cb (diff) | |
download | wix-523c66a62a619e6aa9f30070173ea33edfb5e328.tar.gz wix-523c66a62a619e6aa9f30070173ea33edfb5e328.tar.bz2 wix-523c66a62a619e6aa9f30070173ea33edfb5e328.zip |
Rename "bundle id" concept to "bundle code"
The "bundle id" always had more in common with the PackageCode from the Windows
Installer. With the introduction of an actual Id attribute on the Bundle
element, there is potential for confusion, so there is finally real motivation
to rename "bundle id" to "bundle code".
Diffstat (limited to 'src/burn/engine/section.cpp')
-rw-r--r-- | src/burn/engine/section.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/burn/engine/section.cpp b/src/burn/engine/section.cpp index fd3ce92c..f7c508f3 100644 --- a/src/burn/engine/section.cpp +++ b/src/burn/engine/section.cpp | |||
@@ -9,7 +9,7 @@ typedef struct _BURN_SECTION_HEADER | |||
9 | DWORD dwMagic; | 9 | DWORD dwMagic; |
10 | DWORD dwVersion; | 10 | DWORD dwVersion; |
11 | 11 | ||
12 | GUID guidBundleId; | 12 | GUID guidBundleCode; |
13 | 13 | ||
14 | DWORD dwStubSize; | 14 | DWORD dwStubSize; |
15 | DWORD dwOriginalChecksum; | 15 | DWORD dwOriginalChecksum; |
@@ -235,7 +235,7 @@ extern "C" HRESULT SectionInitialize( | |||
235 | memcpy(pSection->rgcbContainers, pBurnSectionHeader->rgcbContainers, sizeof(DWORD) * pSection->cContainers); | 235 | memcpy(pSection->rgcbContainers, pBurnSectionHeader->rgcbContainers, sizeof(DWORD) * pSection->cContainers); |
236 | 236 | ||
237 | // TODO: verify more than just the GUID. | 237 | // TODO: verify more than just the GUID. |
238 | hr = VerifySectionMatchesMemoryPEHeader(pBurnSectionHeader->guidBundleId); | 238 | hr = VerifySectionMatchesMemoryPEHeader(pBurnSectionHeader->guidBundleCode); |
239 | ExitOnRootFailure(hr, "PE Header from file didn't match PE Header in memory."); | 239 | ExitOnRootFailure(hr, "PE Header from file didn't match PE Header in memory."); |
240 | 240 | ||
241 | LExit: | 241 | LExit: |
@@ -299,7 +299,7 @@ LExit: | |||
299 | } | 299 | } |
300 | 300 | ||
301 | HRESULT VerifySectionMatchesMemoryPEHeader( | 301 | HRESULT VerifySectionMatchesMemoryPEHeader( |
302 | __in REFGUID pBundleId | 302 | __in REFGUID pBundleCode |
303 | ) | 303 | ) |
304 | { | 304 | { |
305 | HRESULT hr = S_OK; | 305 | HRESULT hr = S_OK; |
@@ -382,7 +382,7 @@ HRESULT VerifySectionMatchesMemoryPEHeader( | |||
382 | ExitOnRootFailure(hr, "Failed to read section info, unsupported version: %08x", pBurnSectionHeader->dwVersion); | 382 | ExitOnRootFailure(hr, "Failed to read section info, unsupported version: %08x", pBurnSectionHeader->dwVersion); |
383 | } | 383 | } |
384 | 384 | ||
385 | if (!::IsEqualGUID(pBundleId, pBurnSectionHeader->guidBundleId)) | 385 | if (!::IsEqualGUID(pBundleCode, pBurnSectionHeader->guidBundleCode)) |
386 | { | 386 | { |
387 | hr = E_INVALIDDATA; | 387 | hr = E_INVALIDDATA; |
388 | ExitOnRootFailure(hr, "Bundle guid didn't match the guid in the PE Header in memory."); | 388 | ExitOnRootFailure(hr, "Bundle guid didn't match the guid in the PE Header in memory."); |