diff options
author | Bob Arnson <bob@firegiant.com> | 2025-07-19 22:25:25 -0400 |
---|---|---|
committer | Bob Arnson <bob@firegiant.com> | 2025-07-20 20:10:41 -0400 |
commit | a4a0818ff7335b5c86b590d1f6e990671c2ef387 (patch) | |
tree | b4a39ab7bcbb1f66ce0dee41dc567b66c85e83ad /src/ext/Firewall | |
parent | baf02e973f152ddb7d74d90f505cafc0be17c4fd (diff) | |
download | wix-bob/WixTestTargets.tar.gz wix-bob/WixTestTargets.tar.bz2 wix-bob/WixTestTargets.zip |
Embiggen build perf.bob/WixTestTargets
- Move ext tests to targets for better MSBuild scheduling.
- Parallelize long-running tests.
- Disable Firewall ICEs for dev builds; they're redundant with
round-tripping and ICEs are mutex'd to make them painfully serial.
Diffstat (limited to '')
-rw-r--r-- | src/ext/Firewall/firewall_t.proj | 6 | ||||
-rw-r--r-- | src/ext/Firewall/test/WixToolsetTest.Firewall/FirewallExtensionFixture.cs | 8 |
2 files changed, 12 insertions, 2 deletions
diff --git a/src/ext/Firewall/firewall_t.proj b/src/ext/Firewall/firewall_t.proj index 72128805..f2cee0a0 100644 --- a/src/ext/Firewall/firewall_t.proj +++ b/src/ext/Firewall/firewall_t.proj | |||
@@ -3,7 +3,7 @@ | |||
3 | 3 | ||
4 | <Project Sdk="Microsoft.Build.Traversal"> | 4 | <Project Sdk="Microsoft.Build.Traversal"> |
5 | <ItemGroup> | 5 | <ItemGroup> |
6 | <ProjectReference Include="test\WixToolsetTest.Firewall\WixToolsetTest.Firewall.csproj" Targets="Test" /> | 6 | <ProjectReference Include="test\WixToolsetTest.Firewall\WixToolsetTest.Firewall.csproj" /> |
7 | <ProjectReference Include="wixext\WixToolset.Firewall.wixext.csproj" Targets="Pack" Properties="NoBuild=true" /> | 7 | <ProjectReference Include="wixext\WixToolset.Firewall.wixext.csproj" Targets="Pack" Properties="NoBuild=true" /> |
8 | </ItemGroup> | 8 | </ItemGroup> |
9 | 9 | ||
@@ -14,4 +14,8 @@ | |||
14 | 14 | ||
15 | <Delete Files="$(ArtifactsFolder)WixToolset.Firewall.wixext.*.nupkg" /> | 15 | <Delete Files="$(ArtifactsFolder)WixToolset.Firewall.wixext.*.nupkg" /> |
16 | </Target> | 16 | </Target> |
17 | |||
18 | <Target Name="WixTest"> | ||
19 | <MSBuild Projects="test\WixToolsetTest.Firewall\WixToolsetTest.Firewall.csproj" Targets="Test" /> | ||
20 | </Target> | ||
17 | </Project> | 21 | </Project> |
diff --git a/src/ext/Firewall/test/WixToolsetTest.Firewall/FirewallExtensionFixture.cs b/src/ext/Firewall/test/WixToolsetTest.Firewall/FirewallExtensionFixture.cs index 9b4cb2b1..3be8af0e 100644 --- a/src/ext/Firewall/test/WixToolsetTest.Firewall/FirewallExtensionFixture.cs +++ b/src/ext/Firewall/test/WixToolsetTest.Firewall/FirewallExtensionFixture.cs | |||
@@ -1,7 +1,12 @@ | |||
1 | // Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. | 1 | // Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. |
2 | 2 | ||
3 | using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
4 | |||
5 | [assembly: Parallelize(Scope = ExecutionScope.MethodLevel)] | ||
6 | |||
3 | namespace WixToolsetTest.Firewall | 7 | namespace WixToolsetTest.Firewall |
4 | { | 8 | { |
9 | using System; | ||
5 | using System.Data; | 10 | using System.Data; |
6 | using System.IO; | 11 | using System.IO; |
7 | using System.Linq; | 12 | using System.Linq; |
@@ -687,8 +692,9 @@ namespace WixToolsetTest.Firewall | |||
687 | var folder = TestData.Get(@"TestData", path); | 692 | var folder = TestData.Get(@"TestData", path); |
688 | var build = new Builder(folder, typeof(FirewallExtensionFactory), new[] { folder }); | 693 | var build = new Builder(folder, typeof(FirewallExtensionFactory), new[] { folder }); |
689 | var output = Path.Combine(folder, $"Firewall{ruleName}.xml"); | 694 | var output = Path.Combine(folder, $"Firewall{ruleName}.xml"); |
695 | var isOfficialBuild = !String.IsNullOrEmpty(Environment.GetEnvironmentVariable("WixOfficialBuild")); | ||
690 | 696 | ||
691 | build.BuildAndDecompileAndBuild(Build, Decompile, output, validate: true); | 697 | build.BuildAndDecompileAndBuild(Build, Decompile, output, validate: isOfficialBuild); |
692 | 698 | ||
693 | var doc = XDocument.Load(output); | 699 | var doc = XDocument.Load(output); |
694 | var actual = doc.Descendants() | 700 | var actual = doc.Descendants() |