LocUtil occasionally failed due to XmlInitialization

Split into separate classes to prevent potential parallelism race conditions.

1 files changed, 93 insertions, 0 deletions

diff --git a/src/libs/dutil/test/DUtilUnitTest/LocStringsUtilTests.cpp b/src/libs/dutil/test/DUtilUnitTest/LocStringsUtilTests.cpp
new file mode 100644
index 00000000..1bfc4bb4
--- /dev/null
+++ b/src/libs/dutil/test/DUtilUnitTest/LocStringsUtilTests.cpp
@@ -0,0 +1,93 @@
+// Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information.
+
+#include "precomp.h"
+
+using namespace System;
+using namespace Xunit;
+using namespace WixInternal::TestSupport;
+
+namespace DutilTests
+{
+    public ref class LocStringsUtil
+    {
+    public:
+        [Fact]
+        void CanLoadStringsWxl()
+        {
+            HRESULT hr = S_OK;
+            WIX_LOCALIZATION* pLoc = NULL;
+            LOC_STRING* pLocString = NULL;
+            LPWSTR sczValue = NULL;
+
+            DutilInitialize(&DutilTestTraceError);
+
+            try
+            {
+                hr = XmlInitialize();
+                NativeAssert::Succeeded(hr, "Failed to initialize Xml.");
+
+                pin_ptr<const wchar_t> wxlFilePath = PtrToStringChars(TestData::Get("TestData", "LocUtilTests", "strings.wxl"));
+                hr = LocLoadFromFile(wxlFilePath, &pLoc);
+                NativeAssert::Succeeded(hr, "Failed to parse strings.wxl: {0}", wxlFilePath);
+
+                Assert::Equal(4ul, pLoc->cLocStrings);
+
+                hr = LocGetString(pLoc, L"#(loc.Ex1)", &pLocString);
+                NativeAssert::Succeeded(hr, "Failed to get loc string 'Ex1' from: {0}", wxlFilePath);
+                NativeAssert::StringEqual(L"#(loc.Ex1)", pLocString->wzId);
+                NativeAssert::StringEqual(L"This is example #1", pLocString->wzText);
+                NativeAssert::True(pLocString->bOverridable);
+
+                hr = LocGetString(pLoc, L"#(loc.Ex2)", &pLocString);
+                NativeAssert::Succeeded(hr, "Failed to get loc string 'Ex2' from: {0}", wxlFilePath);
+                NativeAssert::StringEqual(L"#(loc.Ex2)", pLocString->wzId);
+                NativeAssert::StringEqual(L"This is example #2", pLocString->wzText);
+                NativeAssert::False(pLocString->bOverridable);
+
+                hr = LocGetString(pLoc, L"#(loc.Ex3)", &pLocString);
+                NativeAssert::Succeeded(hr, "Failed to get loc string 'Ex3' from: {0}", wxlFilePath);
+                NativeAssert::StringEqual(L"#(loc.Ex3)", pLocString->wzId);
+                NativeAssert::StringEqual(L"This is example #3", pLocString->wzText);
+                NativeAssert::False(pLocString->bOverridable);
+
+                hr = LocGetString(pLoc, L"#(loc.Ex4)", &pLocString);
+                NativeAssert::Succeeded(hr, "Failed to get loc string 'Ex4' from: {0}", wxlFilePath);
+                NativeAssert::StringEqual(L"#(loc.Ex4)", pLocString->wzId);
+                NativeAssert::StringEqual(L"", pLocString->wzText);
+                NativeAssert::False(pLocString->bOverridable);
+
+                hr = StrAllocString(&sczValue, L"Before #(loc.Ex1) After", 0);
+                NativeAssert::Succeeded(hr, "Failed to create localizable Ex1 string");
+
+                hr = LocLocalizeString(pLoc, &sczValue);
+                NativeAssert::Succeeded(hr, "Failed to localize Ex1 string using: {0}", wxlFilePath);
+                NativeAssert::StringEqual(L"Before This is example #1 After", sczValue);
+
+                hr = StrAllocString(&sczValue, L"Xxx#(loc.Ex3)yyY", 0);
+                NativeAssert::Succeeded(hr, "Failed to create localizable Ex3 string");
+
+                hr = LocLocalizeString(pLoc, &sczValue);
+                NativeAssert::Succeeded(hr, "Failed to localize Ex3 string using: {0}", wxlFilePath);
+                NativeAssert::StringEqual(L"XxxThis is example #3yyY", sczValue);
+
+                hr = StrAllocString(&sczValue, L"aaa#(loc.Ex4)bbb", 0);
+                NativeAssert::Succeeded(hr, "Failed to create localizable Ex4 string");
+
+                hr = LocLocalizeString(pLoc, &sczValue);
+                NativeAssert::Succeeded(hr, "Failed to localize Ex4 string using: {0}", wxlFilePath);
+                NativeAssert::StringEqual(L"aaabbb", sczValue);
+            }
+            finally
+            {
+                ReleaseStr(sczValue);
+
+                if (pLoc)
+                {
+                    LocFree(pLoc);
+                }
+
+                DutilUninitialize();
+            }
+        }
+    };
+}