diff options
author | Sean Hall <r.sean.hall@gmail.com> | 2020-03-30 19:25:36 +1000 |
---|---|---|
committer | Sean Hall <r.sean.hall@gmail.com> | 2020-03-30 21:47:13 +1000 |
commit | d5b89ecb2ba931cd5429e00a78b9457f8a63c6d2 (patch) | |
tree | 8e63d6e71579a143e10a8715d3b73089bb71855a /src/wixstdba | |
parent | 16f6a68d0bb1a0d5892a8cef10b835acc4e2a317 (diff) | |
download | wix-d5b89ecb2ba931cd5429e00a78b9457f8a63c6d2.tar.gz wix-d5b89ecb2ba931cd5429e00a78b9457f8a63c6d2.tar.bz2 wix-d5b89ecb2ba931cd5429e00a78b9457f8a63c6d2.zip |
Upgrade to latest dependencies.
Stop skipping CanBuildUsingWixStdBa.
Fix memory leak in wixstdba.
Diffstat (limited to 'src/wixstdba')
-rw-r--r-- | src/wixstdba/WixStandardBootstrapperApplication.cpp | 4 | ||||
-rw-r--r-- | src/wixstdba/packages.config | 4 | ||||
-rw-r--r-- | src/wixstdba/precomp.h | 3 | ||||
-rw-r--r-- | src/wixstdba/wixstdba.cpp | 7 | ||||
-rw-r--r-- | src/wixstdba/wixstdba.vcxproj | 8 |
5 files changed, 16 insertions, 10 deletions
diff --git a/src/wixstdba/WixStandardBootstrapperApplication.cpp b/src/wixstdba/WixStandardBootstrapperApplication.cpp index 6d2fd3e2..afc6a3ee 100644 --- a/src/wixstdba/WixStandardBootstrapperApplication.cpp +++ b/src/wixstdba/WixStandardBootstrapperApplication.cpp | |||
@@ -3726,7 +3726,8 @@ HRESULT CreateBootstrapperApplication( | |||
3726 | __in HRESULT hrHostInitialization, | 3726 | __in HRESULT hrHostInitialization, |
3727 | __in IBootstrapperEngine* pEngine, | 3727 | __in IBootstrapperEngine* pEngine, |
3728 | __in const BOOTSTRAPPER_CREATE_ARGS* pArgs, | 3728 | __in const BOOTSTRAPPER_CREATE_ARGS* pArgs, |
3729 | __inout BOOTSTRAPPER_CREATE_RESULTS* pResults | 3729 | __inout BOOTSTRAPPER_CREATE_RESULTS* pResults, |
3730 | __out IBootstrapperApplication** ppApplication | ||
3730 | ) | 3731 | ) |
3731 | { | 3732 | { |
3732 | HRESULT hr = S_OK; | 3733 | HRESULT hr = S_OK; |
@@ -3737,6 +3738,7 @@ HRESULT CreateBootstrapperApplication( | |||
3737 | 3738 | ||
3738 | pResults->pfnBootstrapperApplicationProc = BalBaseBootstrapperApplicationProc; | 3739 | pResults->pfnBootstrapperApplicationProc = BalBaseBootstrapperApplicationProc; |
3739 | pResults->pvBootstrapperApplicationProcContext = pApplication; | 3740 | pResults->pvBootstrapperApplicationProcContext = pApplication; |
3741 | *ppApplication = pApplication; | ||
3740 | pApplication = NULL; | 3742 | pApplication = NULL; |
3741 | 3743 | ||
3742 | LExit: | 3744 | LExit: |
diff --git a/src/wixstdba/packages.config b/src/wixstdba/packages.config index fbcb6700..56b68f10 100644 --- a/src/wixstdba/packages.config +++ b/src/wixstdba/packages.config | |||
@@ -1,7 +1,7 @@ | |||
1 | <?xml version="1.0" encoding="utf-8"?> | 1 | <?xml version="1.0" encoding="utf-8"?> |
2 | <packages> | 2 | <packages> |
3 | <package id="Nerdbank.GitVersioning" version="2.1.65" targetFramework="native" developmentDependency="true" /> | 3 | <package id="Nerdbank.GitVersioning" version="2.1.65" targetFramework="native" developmentDependency="true" /> |
4 | <package id="WixToolset.BootstrapperCore.Native" version="4.0.11" targetFramework="native" /> | 4 | <package id="WixToolset.BootstrapperCore.Native" version="4.0.13" targetFramework="native" /> |
5 | <package id="WixToolset.BalUtil" version="4.0.13" targetFramework="native" /> | 5 | <package id="WixToolset.BalUtil" version="4.0.16" targetFramework="native" /> |
6 | <package id="WixToolset.DUtil" version="4.0.18" targetFramework="native" /> | 6 | <package id="WixToolset.DUtil" version="4.0.18" targetFramework="native" /> |
7 | </packages> \ No newline at end of file | 7 | </packages> \ No newline at end of file |
diff --git a/src/wixstdba/precomp.h b/src/wixstdba/precomp.h index 925a80ce..9c2b9f6a 100644 --- a/src/wixstdba/precomp.h +++ b/src/wixstdba/precomp.h | |||
@@ -52,5 +52,6 @@ HRESULT CreateBootstrapperApplication( | |||
52 | __in HRESULT hrHostInitialization, | 52 | __in HRESULT hrHostInitialization, |
53 | __in IBootstrapperEngine* pEngine, | 53 | __in IBootstrapperEngine* pEngine, |
54 | __in const BOOTSTRAPPER_CREATE_ARGS* pArgs, | 54 | __in const BOOTSTRAPPER_CREATE_ARGS* pArgs, |
55 | __inout BOOTSTRAPPER_CREATE_RESULTS* pResults | 55 | __inout BOOTSTRAPPER_CREATE_RESULTS* pResults, |
56 | __out IBootstrapperApplication** ppApplication | ||
56 | ); | 57 | ); |
diff --git a/src/wixstdba/wixstdba.cpp b/src/wixstdba/wixstdba.cpp index f47c1f4e..2767c74e 100644 --- a/src/wixstdba/wixstdba.cpp +++ b/src/wixstdba/wixstdba.cpp | |||
@@ -3,6 +3,7 @@ | |||
3 | #include "precomp.h" | 3 | #include "precomp.h" |
4 | 4 | ||
5 | static HINSTANCE vhInstance = NULL; | 5 | static HINSTANCE vhInstance = NULL; |
6 | static IBootstrapperApplication* vpApplication = NULL; | ||
6 | 7 | ||
7 | extern "C" BOOL WINAPI DllMain( | 8 | extern "C" BOOL WINAPI DllMain( |
8 | IN HINSTANCE hInstance, | 9 | IN HINSTANCE hInstance, |
@@ -37,7 +38,7 @@ extern "C" HRESULT WINAPI BootstrapperApplicationCreate( | |||
37 | hr = BalInitializeFromCreateArgs(pArgs, &pEngine); | 38 | hr = BalInitializeFromCreateArgs(pArgs, &pEngine); |
38 | ExitOnFailure(hr, "Failed to initialize Bal."); | 39 | ExitOnFailure(hr, "Failed to initialize Bal."); |
39 | 40 | ||
40 | hr = CreateBootstrapperApplication(vhInstance, FALSE, S_OK, pEngine, pArgs, pResults); | 41 | hr = CreateBootstrapperApplication(vhInstance, FALSE, S_OK, pEngine, pArgs, pResults, &vpApplication); |
41 | BalExitOnFailure(hr, "Failed to create bootstrapper application interface."); | 42 | BalExitOnFailure(hr, "Failed to create bootstrapper application interface."); |
42 | 43 | ||
43 | LExit: | 44 | LExit: |
@@ -49,6 +50,7 @@ LExit: | |||
49 | 50 | ||
50 | extern "C" void WINAPI BootstrapperApplicationDestroy() | 51 | extern "C" void WINAPI BootstrapperApplicationDestroy() |
51 | { | 52 | { |
53 | ReleaseNullObject(vpApplication); | ||
52 | BalUninitialize(); | 54 | BalUninitialize(); |
53 | } | 55 | } |
54 | 56 | ||
@@ -64,7 +66,7 @@ extern "C" HRESULT WINAPI MbaPrereqBootstrapperApplicationCreate( | |||
64 | 66 | ||
65 | BalInitialize(pEngine); | 67 | BalInitialize(pEngine); |
66 | 68 | ||
67 | hr = CreateBootstrapperApplication(vhInstance, TRUE, hrHostInitialization, pEngine, pArgs, pResults); | 69 | hr = CreateBootstrapperApplication(vhInstance, TRUE, hrHostInitialization, pEngine, pArgs, pResults, &vpApplication); |
68 | BalExitOnFailure(hr, "Failed to create managed prerequisite bootstrapper application interface."); | 70 | BalExitOnFailure(hr, "Failed to create managed prerequisite bootstrapper application interface."); |
69 | 71 | ||
70 | LExit: | 72 | LExit: |
@@ -74,5 +76,6 @@ LExit: | |||
74 | 76 | ||
75 | extern "C" void WINAPI MbaPrereqBootstrapperApplicationDestroy() | 77 | extern "C" void WINAPI MbaPrereqBootstrapperApplicationDestroy() |
76 | { | 78 | { |
79 | ReleaseNullObject(vpApplication); | ||
77 | BalUninitialize(); | 80 | BalUninitialize(); |
78 | } | 81 | } |
diff --git a/src/wixstdba/wixstdba.vcxproj b/src/wixstdba/wixstdba.vcxproj index b6c3ebc0..009bdb54 100644 --- a/src/wixstdba/wixstdba.vcxproj +++ b/src/wixstdba/wixstdba.vcxproj | |||
@@ -2,8 +2,8 @@ | |||
2 | <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. --> | 2 | <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. --> |
3 | 3 | ||
4 | <Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | 4 | <Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> |
5 | <Import Project="..\..\packages\WixToolset.BalUtil.4.0.13\build\WixToolset.BalUtil.props" Condition="Exists('..\..\packages\WixToolset.BalUtil.4.0.13\build\WixToolset.BalUtil.props')" /> | 5 | <Import Project="..\..\packages\WixToolset.BalUtil.4.0.16\build\WixToolset.BalUtil.props" Condition="Exists('..\..\packages\WixToolset.BalUtil.4.0.16\build\WixToolset.BalUtil.props')" /> |
6 | <Import Project="..\..\packages\WixToolset.BootstrapperCore.Native.4.0.11\build\WixToolset.BootstrapperCore.Native.props" Condition="Exists('..\..\packages\WixToolset.BootstrapperCore.Native.4.0.11\build\WixToolset.BootstrapperCore.Native.props')" /> | 6 | <Import Project="..\..\packages\WixToolset.BootstrapperCore.Native.4.0.13\build\WixToolset.BootstrapperCore.Native.props" Condition="Exists('..\..\packages\WixToolset.BootstrapperCore.Native.4.0.13\build\WixToolset.BootstrapperCore.Native.props')" /> |
7 | <Import Project="..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props" Condition="Exists('..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props')" /> | 7 | <Import Project="..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props" Condition="Exists('..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props')" /> |
8 | 8 | ||
9 | <ItemGroup Label="ProjectConfigurations"> | 9 | <ItemGroup Label="ProjectConfigurations"> |
@@ -107,8 +107,8 @@ rc.exe -fo "$(OutDir)wixstdba.res" "$(IntDir)wixstdba.messages.rc"</Command> | |||
107 | <PropertyGroup> | 107 | <PropertyGroup> |
108 | <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText> | 108 | <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText> |
109 | </PropertyGroup> | 109 | </PropertyGroup> |
110 | <Error Condition="!Exists('..\..\packages\WixToolset.BalUtil.4.0.13\build\WixToolset.BalUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.BalUtil.4.0.13\build\WixToolset.BalUtil.props'))" /> | 110 | <Error Condition="!Exists('..\..\packages\WixToolset.BalUtil.4.0.16\build\WixToolset.BalUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.BalUtil.4.0.16\build\WixToolset.BalUtil.props'))" /> |
111 | <Error Condition="!Exists('..\..\packages\WixToolset.BootstrapperCore.Native.4.0.11\build\WixToolset.BootstrapperCore.Native.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.BootstrapperCore.Native.4.0.11\build\WixToolset.BootstrapperCore.Native.props'))" /> | 111 | <Error Condition="!Exists('..\..\packages\WixToolset.BootstrapperCore.Native.4.0.13\build\WixToolset.BootstrapperCore.Native.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.BootstrapperCore.Native.4.0.13\build\WixToolset.BootstrapperCore.Native.props'))" /> |
112 | <Error Condition="!Exists('..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props'))" /> | 112 | <Error Condition="!Exists('..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props'))" /> |
113 | <Error Condition="!Exists('..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets'))" /> | 113 | <Error Condition="!Exists('..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets'))" /> |
114 | </Target> | 114 | </Target> |