diff options
| author | Rob Mensching <rob@firegiant.com> | 2022-08-05 14:01:44 -0700 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2022-08-06 18:45:31 -0700 |
| commit | 93df57931e0c260c413bd1036492354c0d8375de (patch) | |
| tree | b5756809d810e49c19ce4fc6c25e538a231419a7 /src | |
| parent | 6e5c9269b8dbf293fc944d179f21c66c03be1e12 (diff) | |
| download | wix-93df57931e0c260c413bd1036492354c0d8375de.tar.gz wix-93df57931e0c260c413bd1036492354c0d8375de.tar.bz2 wix-93df57931e0c260c413bd1036492354c0d8375de.zip | |
Improve exception messages and minor code clean up
Diffstat (limited to 'src')
| -rw-r--r-- | src/wix/WixToolset.Core.Burn/Bind/BindBundleCommand.cs | 4 | ||||
| -rw-r--r-- | src/wix/WixToolset.Core.WindowsInstaller/Bind/BindDatabaseCommand.cs | 4 | ||||
| -rw-r--r-- | src/wix/wix/ConsoleMessageListener.cs | 10 |
3 files changed, 11 insertions, 7 deletions
diff --git a/src/wix/WixToolset.Core.Burn/Bind/BindBundleCommand.cs b/src/wix/WixToolset.Core.Burn/Bind/BindBundleCommand.cs index 67b869e1..45718031 100644 --- a/src/wix/WixToolset.Core.Burn/Bind/BindBundleCommand.cs +++ b/src/wix/WixToolset.Core.Burn/Bind/BindBundleCommand.cs | |||
| @@ -685,7 +685,7 @@ namespace WixToolset.Core.Burn | |||
| 685 | 685 | ||
| 686 | if (0 == symbols.Count) | 686 | if (0 == symbols.Count) |
| 687 | { | 687 | { |
| 688 | throw new WixException(ErrorMessages.MissingBundleInformation(nameof(T))); | 688 | throw new WixException(ErrorMessages.MissingBundleInformation(typeof(T).Name)); |
| 689 | } | 689 | } |
| 690 | 690 | ||
| 691 | return symbols; | 691 | return symbols; |
| @@ -697,7 +697,7 @@ namespace WixToolset.Core.Burn | |||
| 697 | 697 | ||
| 698 | if (1 != symbols.Count) | 698 | if (1 != symbols.Count) |
| 699 | { | 699 | { |
| 700 | throw new WixException(ErrorMessages.MissingBundleInformation(nameof(T))); | 700 | throw new WixException(ErrorMessages.MissingBundleInformation(typeof(T).Name)); |
| 701 | } | 701 | } |
| 702 | 702 | ||
| 703 | return symbols[0]; | 703 | return symbols[0]; |
diff --git a/src/wix/WixToolset.Core.WindowsInstaller/Bind/BindDatabaseCommand.cs b/src/wix/WixToolset.Core.WindowsInstaller/Bind/BindDatabaseCommand.cs index 1589cc7a..ef8dec38 100644 --- a/src/wix/WixToolset.Core.WindowsInstaller/Bind/BindDatabaseCommand.cs +++ b/src/wix/WixToolset.Core.WindowsInstaller/Bind/BindDatabaseCommand.cs | |||
| @@ -98,8 +98,6 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 98 | 98 | ||
| 99 | private string IntermediateFolder { get; } | 99 | private string IntermediateFolder { get; } |
| 100 | 100 | ||
| 101 | private bool SuppressValidation { get; } | ||
| 102 | |||
| 103 | public IBindResult Execute() | 101 | public IBindResult Execute() |
| 104 | { | 102 | { |
| 105 | if (!this.Intermediate.HasLevel(Data.IntermediateLevels.Linked) || !this.Intermediate.HasLevel(Data.IntermediateLevels.Resolved)) | 103 | if (!this.Intermediate.HasLevel(Data.IntermediateLevels.Linked) || !this.Intermediate.HasLevel(Data.IntermediateLevels.Resolved)) |
| @@ -587,7 +585,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 587 | 585 | ||
| 588 | if (1 != symbols.Count) | 586 | if (1 != symbols.Count) |
| 589 | { | 587 | { |
| 590 | throw new WixException(ErrorMessages.MissingBundleInformation(nameof(T))); | 588 | throw new WixException($"Expected to find a single symbol of type {typeof(T).Name} but found {symbols.Count}"); |
| 591 | } | 589 | } |
| 592 | 590 | ||
| 593 | return symbols[0]; | 591 | return symbols[0]; |
diff --git a/src/wix/wix/ConsoleMessageListener.cs b/src/wix/wix/ConsoleMessageListener.cs index ebf1622b..53c73f68 100644 --- a/src/wix/wix/ConsoleMessageListener.cs +++ b/src/wix/wix/ConsoleMessageListener.cs | |||
| @@ -48,9 +48,15 @@ namespace WixToolset.Tools.Core | |||
| 48 | } | 48 | } |
| 49 | } | 49 | } |
| 50 | 50 | ||
| 51 | public void Write(string message) => Console.Out.WriteLine(message); | 51 | public void Write(string message) |
| 52 | { | ||
| 53 | Console.Out.WriteLine(message); | ||
| 54 | } | ||
| 52 | 55 | ||
| 53 | public MessageLevel CalculateMessageLevel(IMessaging messaging, Message message, MessageLevel defaultMessageLevel) => defaultMessageLevel; | 56 | public MessageLevel CalculateMessageLevel(IMessaging messaging, Message message, MessageLevel defaultMessageLevel) |
| 57 | { | ||
| 58 | return defaultMessageLevel; | ||
| 59 | } | ||
| 54 | 60 | ||
| 55 | private static IList<string> GetFileNames(SourceLineNumber sourceLineNumbers) | 61 | private static IList<string> GetFileNames(SourceLineNumber sourceLineNumbers) |
| 56 | { | 62 | { |
