diff options
| author | Rob Mensching <rob@firegiant.com> | 2019-05-23 15:15:17 -0700 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2019-05-23 15:43:40 -0700 |
| commit | bb84eab87c7361d0af10f68b2ef6369d20762c67 (patch) | |
| tree | a86b59277da4f49b95bcaf3b8000a8668a3d2d3a /src | |
| parent | 97c4c3eaffef05764bd060cb2d78f0be5171d576 (diff) | |
| download | wix-bb84eab87c7361d0af10f68b2ef6369d20762c67.tar.gz wix-bb84eab87c7361d0af10f68b2ef6369d20762c67.tar.bz2 wix-bb84eab87c7361d0af10f68b2ef6369d20762c67.zip | |
Minor fixes
Diffstat (limited to 'src')
| -rw-r--r-- | src/WixToolset.Data/Intermediate.cs | 2 | ||||
| -rw-r--r-- | src/WixToolset.Data/Tuples/FileTuple.cs | 16 | ||||
| -rw-r--r-- | src/WixToolset.Data/Tuples/MediaTuple.cs | 4 | ||||
| -rw-r--r-- | src/test/WixToolsetTest.Data/TupleDefinitionFixture.cs | 4 |
4 files changed, 13 insertions, 13 deletions
diff --git a/src/WixToolset.Data/Intermediate.cs b/src/WixToolset.Data/Intermediate.cs index 4b7daa4e..7693b815 100644 --- a/src/WixToolset.Data/Intermediate.cs +++ b/src/WixToolset.Data/Intermediate.cs | |||
| @@ -130,7 +130,7 @@ namespace WixToolset.Data | |||
| 130 | /// <param name="intermediateFiles">Paths to intermediate files saved on disk.</param> | 130 | /// <param name="intermediateFiles">Paths to intermediate files saved on disk.</param> |
| 131 | /// <param name="suppressVersionCheck">Suppress checking for wix.dll version mismatches.</param> | 131 | /// <param name="suppressVersionCheck">Suppress checking for wix.dll version mismatches.</param> |
| 132 | /// <returns>Returns the loaded intermediates</returns> | 132 | /// <returns>Returns the loaded intermediates</returns> |
| 133 | public static IEnumerable<Intermediate> Load(IEnumerable<string> intermediateFiles, bool suppressVersionCheck = false) | 133 | public static IEnumerable<Intermediate> Load(IEnumerable<string> intermediateFiles) |
| 134 | { | 134 | { |
| 135 | var creator = new SimpleTupleDefinitionCreator(); | 135 | var creator = new SimpleTupleDefinitionCreator(); |
| 136 | 136 | ||
diff --git a/src/WixToolset.Data/Tuples/FileTuple.cs b/src/WixToolset.Data/Tuples/FileTuple.cs index 6d7281cc..43de8b46 100644 --- a/src/WixToolset.Data/Tuples/FileTuple.cs +++ b/src/WixToolset.Data/Tuples/FileTuple.cs | |||
| @@ -11,8 +11,8 @@ namespace WixToolset.Data | |||
| 11 | new[] | 11 | new[] |
| 12 | { | 12 | { |
| 13 | new IntermediateFieldDefinition(nameof(FileTupleFields.ComponentRef), IntermediateFieldType.String), | 13 | new IntermediateFieldDefinition(nameof(FileTupleFields.ComponentRef), IntermediateFieldType.String), |
| 14 | new IntermediateFieldDefinition(nameof(FileTupleFields.ShortName), IntermediateFieldType.String), | ||
| 15 | new IntermediateFieldDefinition(nameof(FileTupleFields.Name), IntermediateFieldType.String), | 14 | new IntermediateFieldDefinition(nameof(FileTupleFields.Name), IntermediateFieldType.String), |
| 15 | new IntermediateFieldDefinition(nameof(FileTupleFields.ShortName), IntermediateFieldType.String), | ||
| 16 | new IntermediateFieldDefinition(nameof(FileTupleFields.FileSize), IntermediateFieldType.Number), | 16 | new IntermediateFieldDefinition(nameof(FileTupleFields.FileSize), IntermediateFieldType.Number), |
| 17 | new IntermediateFieldDefinition(nameof(FileTupleFields.Version), IntermediateFieldType.String), | 17 | new IntermediateFieldDefinition(nameof(FileTupleFields.Version), IntermediateFieldType.String), |
| 18 | new IntermediateFieldDefinition(nameof(FileTupleFields.Language), IntermediateFieldType.String), | 18 | new IntermediateFieldDefinition(nameof(FileTupleFields.Language), IntermediateFieldType.String), |
| @@ -35,8 +35,8 @@ namespace WixToolset.Data.Tuples | |||
| 35 | public enum FileTupleFields | 35 | public enum FileTupleFields |
| 36 | { | 36 | { |
| 37 | ComponentRef, | 37 | ComponentRef, |
| 38 | ShortName, | ||
| 39 | Name, | 38 | Name, |
| 39 | ShortName, | ||
| 40 | FileSize, | 40 | FileSize, |
| 41 | Version, | 41 | Version, |
| 42 | Language, | 42 | Language, |
| @@ -69,18 +69,18 @@ namespace WixToolset.Data.Tuples | |||
| 69 | set => this.Set((int)FileTupleFields.ComponentRef, value); | 69 | set => this.Set((int)FileTupleFields.ComponentRef, value); |
| 70 | } | 70 | } |
| 71 | 71 | ||
| 72 | public string ShortName | ||
| 73 | { | ||
| 74 | get => (string)this.Fields[(int)FileTupleFields.ShortName]; | ||
| 75 | set => this.Set((int)FileTupleFields.ShortName, value); | ||
| 76 | } | ||
| 77 | |||
| 78 | public string Name | 72 | public string Name |
| 79 | { | 73 | { |
| 80 | get => (string)this.Fields[(int)FileTupleFields.Name]; | 74 | get => (string)this.Fields[(int)FileTupleFields.Name]; |
| 81 | set => this.Set((int)FileTupleFields.Name, value); | 75 | set => this.Set((int)FileTupleFields.Name, value); |
| 82 | } | 76 | } |
| 83 | 77 | ||
| 78 | public string ShortName | ||
| 79 | { | ||
| 80 | get => (string)this.Fields[(int)FileTupleFields.ShortName]; | ||
| 81 | set => this.Set((int)FileTupleFields.ShortName, value); | ||
| 82 | } | ||
| 83 | |||
| 84 | public int FileSize | 84 | public int FileSize |
| 85 | { | 85 | { |
| 86 | get => (int)this.Fields[(int)FileTupleFields.FileSize]; | 86 | get => (int)this.Fields[(int)FileTupleFields.FileSize]; |
diff --git a/src/WixToolset.Data/Tuples/MediaTuple.cs b/src/WixToolset.Data/Tuples/MediaTuple.cs index 009a588f..a9cbb034 100644 --- a/src/WixToolset.Data/Tuples/MediaTuple.cs +++ b/src/WixToolset.Data/Tuples/MediaTuple.cs | |||
| @@ -55,9 +55,9 @@ namespace WixToolset.Data.Tuples | |||
| 55 | set => this.Set((int)MediaTupleFields.DiskId, value); | 55 | set => this.Set((int)MediaTupleFields.DiskId, value); |
| 56 | } | 56 | } |
| 57 | 57 | ||
| 58 | public int LastSequence | 58 | public int? LastSequence |
| 59 | { | 59 | { |
| 60 | get => (int)this.Fields[(int)MediaTupleFields.LastSequence]; | 60 | get => (int?)this.Fields[(int)MediaTupleFields.LastSequence]; |
| 61 | set => this.Set((int)MediaTupleFields.LastSequence, value); | 61 | set => this.Set((int)MediaTupleFields.LastSequence, value); |
| 62 | } | 62 | } |
| 63 | 63 | ||
diff --git a/src/test/WixToolsetTest.Data/TupleDefinitionFixture.cs b/src/test/WixToolsetTest.Data/TupleDefinitionFixture.cs index 35e7bf33..9854ba9f 100644 --- a/src/test/WixToolsetTest.Data/TupleDefinitionFixture.cs +++ b/src/test/WixToolsetTest.Data/TupleDefinitionFixture.cs | |||
| @@ -43,10 +43,10 @@ namespace WixToolsetTest.Data | |||
| 43 | public void CanCheckNameofField() | 43 | public void CanCheckNameofField() |
| 44 | { | 44 | { |
| 45 | var fileTuple = new FileTuple(); | 45 | var fileTuple = new FileTuple(); |
| 46 | Assert.Equal("Component_", fileTuple.Definition.FieldDefinitions[0].Name); | 46 | Assert.Equal("ComponentRef", fileTuple.Definition.FieldDefinitions[0].Name); |
| 47 | Assert.Null(fileTuple.Fields[0]); | 47 | Assert.Null(fileTuple.Fields[0]); |
| 48 | fileTuple.ComponentRef = "Foo"; | 48 | fileTuple.ComponentRef = "Foo"; |
| 49 | Assert.Equal("Component_", fileTuple.Fields[0].Name); | 49 | Assert.Equal("ComponentRef", fileTuple.Fields[0].Name); |
| 50 | Assert.Same(fileTuple.Definition.FieldDefinitions[0].Name, fileTuple.Fields[0].Name); | 50 | Assert.Same(fileTuple.Definition.FieldDefinitions[0].Name, fileTuple.Fields[0].Name); |
| 51 | } | 51 | } |
| 52 | 52 | ||
