aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2022-02-14 13:52:59 -0800
committerRob Mensching <rob@firegiant.com>2022-02-17 14:52:59 -0800
commit18c8a4eedb907b56abdd92963fffde9f59e9dae2 (patch)
tree43e3d478d103ff7d36c14f027a53b986458fa2c9 /src
parent4310916863735f641d2aa2e3f44d47c7b08c9d49 (diff)
downloadwix-18c8a4eedb907b56abdd92963fffde9f59e9dae2.tar.gz
wix-18c8a4eedb907b56abdd92963fffde9f59e9dae2.tar.bz2
wix-18c8a4eedb907b56abdd92963fffde9f59e9dae2.zip
Remove use of InternalsVisibleTo
Ensure the tests validate the correct error code is sent, not that the correct internal variable was used return the error code.
Diffstat (limited to 'src')
-rw-r--r--src/wix/WixToolset.Core/WixToolset.Core.csproj12
-rw-r--r--src/wix/test/WixToolsetTest.CoreIntegration/BundleFixture.cs8
-rw-r--r--src/wix/test/WixToolsetTest.CoreIntegration/PayloadFixture.cs2
3 files changed, 5 insertions, 17 deletions
diff --git a/src/wix/WixToolset.Core/WixToolset.Core.csproj b/src/wix/WixToolset.Core/WixToolset.Core.csproj
index 71742b66..c2551b21 100644
--- a/src/wix/WixToolset.Core/WixToolset.Core.csproj
+++ b/src/wix/WixToolset.Core/WixToolset.Core.csproj
@@ -15,18 +15,6 @@
15 </PropertyGroup> 15 </PropertyGroup>
16 16
17 <ItemGroup> 17 <ItemGroup>
18 <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
19 <_Parameter1>WixToolset.Core.TestPackage, PublicKey=0024000004800000940000000602000000240000525341310004000001000100a9967ec28982f42ee51a47dd5204315975a6ed69294b982146a99a70130a2fa13e226aaddde14c17d1bf3af69e8956d69a86585e74d208efcc5ac98a0686055327b2e87960d3c39bf3a6bc1e572863327d19dbf4fd2616dda124dbea260755a2d1d39d3cf1049ea526493eb2bf996b8ad985e3012308529e5b9b0f5cd5fa04bd</_Parameter1>
20 </AssemblyAttribute>
21 <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
22 <_Parameter1>WixToolsetTest.Core.Burn, PublicKey=0024000004800000940000000602000000240000525341310004000001000100a9967ec28982f42ee51a47dd5204315975a6ed69294b982146a99a70130a2fa13e226aaddde14c17d1bf3af69e8956d69a86585e74d208efcc5ac98a0686055327b2e87960d3c39bf3a6bc1e572863327d19dbf4fd2616dda124dbea260755a2d1d39d3cf1049ea526493eb2bf996b8ad985e3012308529e5b9b0f5cd5fa04bd</_Parameter1>
23 </AssemblyAttribute>
24 <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
25 <_Parameter1>WixToolsetTest.CoreIntegration, PublicKey=0024000004800000940000000602000000240000525341310004000001000100a9967ec28982f42ee51a47dd5204315975a6ed69294b982146a99a70130a2fa13e226aaddde14c17d1bf3af69e8956d69a86585e74d208efcc5ac98a0686055327b2e87960d3c39bf3a6bc1e572863327d19dbf4fd2616dda124dbea260755a2d1d39d3cf1049ea526493eb2bf996b8ad985e3012308529e5b9b0f5cd5fa04bd</_Parameter1>
26 </AssemblyAttribute>
27 </ItemGroup>
28
29 <ItemGroup>
30 <ProjectReference Include="..\WixToolset.Core.Native\WixToolset.Core.Native.csproj" /> 18 <ProjectReference Include="..\WixToolset.Core.Native\WixToolset.Core.Native.csproj" />
31 </ItemGroup> 19 </ItemGroup>
32 20
diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/BundleFixture.cs b/src/wix/test/WixToolsetTest.CoreIntegration/BundleFixture.cs
index 601503ab..711b2fda 100644
--- a/src/wix/test/WixToolsetTest.CoreIntegration/BundleFixture.cs
+++ b/src/wix/test/WixToolsetTest.CoreIntegration/BundleFixture.cs
@@ -441,7 +441,7 @@ namespace WixToolsetTest.CoreIntegration
441 "-o", exePath, 441 "-o", exePath,
442 }); 442 });
443 443
444 Assert.Equal((int)LinkerErrors.Ids.OrphanedPayload, result.ExitCode); 444 Assert.Equal(7000, result.ExitCode);
445 } 445 }
446 } 446 }
447 447
@@ -468,7 +468,7 @@ namespace WixToolsetTest.CoreIntegration
468 "-o", exePath, 468 "-o", exePath,
469 }); 469 });
470 470
471 Assert.Equal((int)LinkerErrors.Ids.PackageInMultipleContainers, result.ExitCode); 471 Assert.Equal(7001, result.ExitCode);
472 } 472 }
473 } 473 }
474 474
@@ -494,7 +494,7 @@ namespace WixToolsetTest.CoreIntegration
494 "-o", exePath, 494 "-o", exePath,
495 }); 495 });
496 496
497 Assert.Equal((int)LinkerErrors.Ids.UnscheduledChainPackage, result.ExitCode); 497 Assert.Equal(7003, result.ExitCode);
498 } 498 }
499 } 499 }
500 500
@@ -520,7 +520,7 @@ namespace WixToolsetTest.CoreIntegration
520 "-o", exePath, 520 "-o", exePath,
521 }); 521 });
522 522
523 Assert.Equal((int)LinkerErrors.Ids.UnscheduledRollbackBoundary, result.ExitCode); 523 Assert.Equal(7004, result.ExitCode);
524 } 524 }
525 } 525 }
526 } 526 }
diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/PayloadFixture.cs b/src/wix/test/WixToolsetTest.CoreIntegration/PayloadFixture.cs
index cb35976a..bda642cb 100644
--- a/src/wix/test/WixToolsetTest.CoreIntegration/PayloadFixture.cs
+++ b/src/wix/test/WixToolsetTest.CoreIntegration/PayloadFixture.cs
@@ -140,7 +140,7 @@ namespace WixToolsetTest.CoreIntegration
140 "-o", bundlePath, 140 "-o", bundlePath,
141 }); 141 });
142 142
143 Assert.Equal((int)LinkerErrors.Ids.PayloadSharedWithBA, result.ExitCode); 143 Assert.Equal(7002, result.ExitCode);
144 } 144 }
145 } 145 }
146 146