aboutsummaryrefslogtreecommitdiff
path: root/src/WixToolset.Converters/Wix3Converter.cs
diff options
context:
space:
mode:
Diffstat (limited to 'src/WixToolset.Converters/Wix3Converter.cs')
-rw-r--r--src/WixToolset.Converters/Wix3Converter.cs23
1 files changed, 23 insertions, 0 deletions
diff --git a/src/WixToolset.Converters/Wix3Converter.cs b/src/WixToolset.Converters/Wix3Converter.cs
index 27c29e4d..2d603c4f 100644
--- a/src/WixToolset.Converters/Wix3Converter.cs
+++ b/src/WixToolset.Converters/Wix3Converter.cs
@@ -407,6 +407,15 @@ namespace WixToolset.Converters
407 407
408 private void ConvertComponentElement(XElement element) 408 private void ConvertComponentElement(XElement element)
409 { 409 {
410 var guid = element.Attribute("Guid");
411 if (guid != null && guid.Value == "*")
412 {
413 if (this.OnError(ConverterTestType.AutoGuidUnnecessary, element, "Using '*' for the Component Guid attribute is unnecessary. Remove the attribute to remove the redundancy."))
414 {
415 guid.Remove();
416 }
417 }
418
410 var xCondition = element.Element(ConditionElementName); 419 var xCondition = element.Element(ConditionElementName);
411 if (xCondition != null) 420 if (xCondition != null)
412 { 421 {
@@ -523,6 +532,15 @@ namespace WixToolset.Converters
523 532
524 private void ConvertProductElement(XElement element) 533 private void ConvertProductElement(XElement element)
525 { 534 {
535 var id = element.Attribute("Id");
536 if (id != null && id.Value == "*")
537 {
538 if (this.OnError(ConverterTestType.AutoGuidUnnecessary, element, "Using '*' for the Product Id attribute is unnecessary. Remove the attribute to remove the redundancy."))
539 {
540 id.Remove();
541 }
542 }
543
526 var xCondition = element.Element(ConditionElementName); 544 var xCondition = element.Element(ConditionElementName);
527 if (xCondition != null) 545 if (xCondition != null)
528 { 546 {
@@ -1029,6 +1047,11 @@ namespace WixToolset.Converters
1029 /// Inner text value should move to an attribute. 1047 /// Inner text value should move to an attribute.
1030 /// </summary> 1048 /// </summary>
1031 InnerTextDeprecated, 1049 InnerTextDeprecated,
1050
1051 /// <summary>
1052 /// Explicit auto-GUID unnecessary.
1053 /// </summary>
1054 AutoGuidUnnecessary,
1032 } 1055 }
1033 } 1056 }
1034} 1057}