diff options
Diffstat (limited to 'src/WixToolset.Converters/WixConverter.cs')
-rw-r--r-- | src/WixToolset.Converters/WixConverter.cs | 20 |
1 files changed, 19 insertions, 1 deletions
diff --git a/src/WixToolset.Converters/WixConverter.cs b/src/WixToolset.Converters/WixConverter.cs index 5f6ee2df..b82c4490 100644 --- a/src/WixToolset.Converters/WixConverter.cs +++ b/src/WixToolset.Converters/WixConverter.cs | |||
@@ -469,7 +469,7 @@ namespace WixToolset.Converters | |||
469 | if (modularization != null) | 469 | if (modularization != null) |
470 | { | 470 | { |
471 | var camelCaseValue = LowercaseFirstChar(modularization.Value); | 471 | var camelCaseValue = LowercaseFirstChar(modularization.Value); |
472 | if (category.Value != camelCaseValue && | 472 | if (modularization.Value != camelCaseValue && |
473 | this.OnError(ConverterTestType.ColumnModularizeCamelCase, element, "The CustomTable Modularize attribute contains an incorrectly cased '{0}' value. Lowercase the first character instead.", modularization.Name)) | 473 | this.OnError(ConverterTestType.ColumnModularizeCamelCase, element, "The CustomTable Modularize attribute contains an incorrectly cased '{0}' value. Lowercase the first character instead.", modularization.Name)) |
474 | { | 474 | { |
475 | modularization.Value = camelCaseValue; | 475 | modularization.Value = camelCaseValue; |
@@ -759,6 +759,19 @@ namespace WixToolset.Converters | |||
759 | private void ConvertCustomActionElement(XElement xCustomAction) | 759 | private void ConvertCustomActionElement(XElement xCustomAction) |
760 | { | 760 | { |
761 | var xBinaryKey = xCustomAction.Attribute("BinaryKey"); | 761 | var xBinaryKey = xCustomAction.Attribute("BinaryKey"); |
762 | if (xBinaryKey != null && this.OnError(ConverterTestType.CustomActionKeysAreNowRefs, xCustomAction, "The CustomAction attributes have been renamed from BinaryKey and FileKey to BinaryRef and FileRef.")) | ||
763 | { | ||
764 | xCustomAction.SetAttributeValue("BinaryRef", xBinaryKey.Value); | ||
765 | xBinaryKey.Remove(); | ||
766 | xBinaryKey = xCustomAction.Attribute("BinaryRef"); | ||
767 | } | ||
768 | |||
769 | var xFileKey = xCustomAction.Attribute("FileKey"); | ||
770 | if (xFileKey != null && this.OnError(ConverterTestType.CustomActionKeysAreNowRefs, xCustomAction, "The CustomAction attributes have been renamed from BinaryKey and FileKey to BinaryRef and FileRef.")) | ||
771 | { | ||
772 | xCustomAction.SetAttributeValue("FileRef", xFileKey.Value); | ||
773 | xFileKey.Remove(); | ||
774 | } | ||
762 | 775 | ||
763 | if (xBinaryKey?.Value == "WixCA" || xBinaryKey?.Value == "UtilCA") | 776 | if (xBinaryKey?.Value == "WixCA" || xBinaryKey?.Value == "UtilCA") |
764 | { | 777 | { |
@@ -1282,6 +1295,11 @@ namespace WixToolset.Converters | |||
1282 | /// The string variable type was previously treated as formatted. | 1295 | /// The string variable type was previously treated as formatted. |
1283 | /// </summary> | 1296 | /// </summary> |
1284 | AssignVariableTypeFormatted, | 1297 | AssignVariableTypeFormatted, |
1298 | |||
1299 | /// <summary> | ||
1300 | /// The CustomAction attributes have been renamed from BinaryKey and FileKey to BinaryRef and FileRef. | ||
1301 | /// </summary> | ||
1302 | CustomActionKeysAreNowRefs, | ||
1285 | } | 1303 | } |
1286 | } | 1304 | } |
1287 | } | 1305 | } |