diff options
Diffstat (limited to 'src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs')
| -rw-r--r-- | src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs index 2199bbde..2bfd587f 100644 --- a/src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs +++ b/src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs | |||
| @@ -57,7 +57,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 57 | 57 | ||
| 58 | var mediaRows = new Dictionary<int, MediaTuple>(); | 58 | var mediaRows = new Dictionary<int, MediaTuple>(); |
| 59 | 59 | ||
| 60 | List<FileFacade> uncompressedFiles = new List<FileFacade>(); | 60 | var uncompressedFiles = new List<FileFacade>(); |
| 61 | 61 | ||
| 62 | var mediaTable = this.Section.Tuples.OfType<MediaTuple>().ToList(); | 62 | var mediaTable = this.Section.Tuples.OfType<MediaTuple>().ToList(); |
| 63 | var mediaTemplateTable = this.Section.Tuples.OfType<WixMediaTemplateTuple>().ToList(); | 63 | var mediaTemplateTable = this.Section.Tuples.OfType<WixMediaTemplateTuple>().ToList(); |
| @@ -109,8 +109,8 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 109 | 109 | ||
| 110 | ulong currentPreCabSize = 0; | 110 | ulong currentPreCabSize = 0; |
| 111 | ulong maxPreCabSizeInBytes; | 111 | ulong maxPreCabSizeInBytes; |
| 112 | int maxPreCabSizeInMB = 0; | 112 | var maxPreCabSizeInMB = 0; |
| 113 | int currentCabIndex = 0; | 113 | var currentCabIndex = 0; |
| 114 | 114 | ||
| 115 | MediaTuple currentMediaRow = null; | 115 | MediaTuple currentMediaRow = null; |
| 116 | 116 | ||
| @@ -131,7 +131,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 131 | this.CabinetNameTemplate = mediaTemplateRow.CabinetTemplate; | 131 | this.CabinetNameTemplate = mediaTemplateRow.CabinetTemplate; |
| 132 | } | 132 | } |
| 133 | 133 | ||
| 134 | string mumsString = Environment.GetEnvironmentVariable("WIX_MUMS"); | 134 | var mumsString = Environment.GetEnvironmentVariable("WIX_MUMS"); |
| 135 | 135 | ||
| 136 | try | 136 | try |
| 137 | { | 137 | { |
| @@ -170,13 +170,13 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 170 | { | 170 | { |
| 171 | // Associate current file with last cab (irrespective of the size) and cab index is not incremented anymore. | 171 | // Associate current file with last cab (irrespective of the size) and cab index is not incremented anymore. |
| 172 | var cabinetFiles = filesByCabinetMedia[currentMediaRow]; | 172 | var cabinetFiles = filesByCabinetMedia[currentMediaRow]; |
| 173 | facade.File.DiskId = currentCabIndex; | 173 | facade.DiskId = currentCabIndex; |
| 174 | cabinetFiles.Add(facade); | 174 | cabinetFiles.Add(facade); |
| 175 | continue; | 175 | continue; |
| 176 | } | 176 | } |
| 177 | 177 | ||
| 178 | // Update current cab size. | 178 | // Update current cab size. |
| 179 | currentPreCabSize += (ulong)facade.File.FileSize; | 179 | currentPreCabSize += (ulong)facade.FileSize; |
| 180 | 180 | ||
| 181 | if (currentPreCabSize > maxPreCabSizeInBytes) | 181 | if (currentPreCabSize > maxPreCabSizeInBytes) |
| 182 | { | 182 | { |
| @@ -186,10 +186,10 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 186 | filesByCabinetMedia.Add(currentMediaRow, new List<FileFacade>()); | 186 | filesByCabinetMedia.Add(currentMediaRow, new List<FileFacade>()); |
| 187 | 187 | ||
| 188 | var cabinetFileRows = filesByCabinetMedia[currentMediaRow]; | 188 | var cabinetFileRows = filesByCabinetMedia[currentMediaRow]; |
| 189 | facade.File.DiskId = currentCabIndex; | 189 | facade.DiskId = currentCabIndex; |
| 190 | cabinetFileRows.Add(facade); | 190 | cabinetFileRows.Add(facade); |
| 191 | // Now files larger than MaxUncompressedMediaSize will be the only file in its cabinet so as to respect MaxUncompressedMediaSize | 191 | // Now files larger than MaxUncompressedMediaSize will be the only file in its cabinet so as to respect MaxUncompressedMediaSize |
| 192 | currentPreCabSize = (ulong)facade.File.FileSize; | 192 | currentPreCabSize = (ulong)facade.FileSize; |
| 193 | } | 193 | } |
| 194 | else | 194 | else |
| 195 | { | 195 | { |
| @@ -204,7 +204,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 204 | 204 | ||
| 205 | // Associate current file with current cab. | 205 | // Associate current file with current cab. |
| 206 | var cabinetFiles = filesByCabinetMedia[currentMediaRow]; | 206 | var cabinetFiles = filesByCabinetMedia[currentMediaRow]; |
| 207 | facade.File.DiskId = currentCabIndex; | 207 | facade.DiskId = currentCabIndex; |
| 208 | cabinetFiles.Add(facade); | 208 | cabinetFiles.Add(facade); |
| 209 | } | 209 | } |
| 210 | } | 210 | } |
| @@ -260,18 +260,18 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 260 | } | 260 | } |
| 261 | } | 261 | } |
| 262 | 262 | ||
| 263 | foreach (FileFacade facade in fileFacades) | 263 | foreach (var facade in fileFacades) |
| 264 | { | 264 | { |
| 265 | if (!mediaRows.TryGetValue(facade.DiskId, out var mediaRow)) | 265 | if (!mediaRows.TryGetValue(facade.DiskId, out var mediaRow)) |
| 266 | { | 266 | { |
| 267 | this.Messaging.Write(ErrorMessages.MissingMedia(facade.File.SourceLineNumbers, facade.DiskId)); | 267 | this.Messaging.Write(ErrorMessages.MissingMedia(facade.SourceLineNumber, facade.DiskId)); |
| 268 | continue; | 268 | continue; |
| 269 | } | 269 | } |
| 270 | 270 | ||
| 271 | // When building a product, if the current file is to be uncompressed or if | 271 | // When building a product, if the current file is to be uncompressed or if |
| 272 | // the package set not to be compressed, don't cab it. | 272 | // the package set not to be compressed, don't cab it. |
| 273 | var compressed = (facade.File.Attributes & FileTupleAttributes.Compressed) == FileTupleAttributes.Compressed; | 273 | var compressed = facade.Compressed; |
| 274 | var uncompressed = (facade.File.Attributes & FileTupleAttributes.Uncompressed) == FileTupleAttributes.Uncompressed; | 274 | var uncompressed = facade.Uncompressed; |
| 275 | if (SectionType.Product == this.Section.Type && (uncompressed || (!compressed && !this.FilesCompressed))) | 275 | if (SectionType.Product == this.Section.Type && (uncompressed || (!compressed && !this.FilesCompressed))) |
| 276 | { | 276 | { |
| 277 | uncompressedFiles.Add(facade); | 277 | uncompressedFiles.Add(facade); |
| @@ -284,7 +284,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 284 | } | 284 | } |
| 285 | else | 285 | else |
| 286 | { | 286 | { |
| 287 | this.Messaging.Write(ErrorMessages.ExpectedMediaCabinet(facade.File.SourceLineNumbers, facade.File.Id.Id, facade.DiskId)); | 287 | this.Messaging.Write(ErrorMessages.ExpectedMediaCabinet(facade.SourceLineNumber, facade.Id, facade.DiskId)); |
| 288 | } | 288 | } |
| 289 | } | 289 | } |
| 290 | } | 290 | } |
