aboutsummaryrefslogtreecommitdiff
path: root/src/WixToolset.Core/Linker.cs
diff options
context:
space:
mode:
Diffstat (limited to 'src/WixToolset.Core/Linker.cs')
-rw-r--r--src/WixToolset.Core/Linker.cs36
1 files changed, 18 insertions, 18 deletions
diff --git a/src/WixToolset.Core/Linker.cs b/src/WixToolset.Core/Linker.cs
index cbdb46d0..862681bb 100644
--- a/src/WixToolset.Core/Linker.cs
+++ b/src/WixToolset.Core/Linker.cs
@@ -149,12 +149,12 @@ namespace WixToolset.Core
149 throw new WixException(ErrorMessages.MissingEntrySection(this.Context.ExpectedOutputType.ToString())); 149 throw new WixException(ErrorMessages.MissingEntrySection(this.Context.ExpectedOutputType.ToString()));
150 } 150 }
151 151
152 // Add the missing standard action symbols. 152 // Add the missing standard action tuples.
153 this.LoadStandardActionSymbols(find.EntrySection, find.Symbols); 153 this.LoadStandardActions(find.EntrySection, find.TuplesByName);
154 154
155 // Resolve the symbol references to find the set of sections we care about for linking. 155 // Resolve the tuple references to find the set of sections we care about for linking.
156 // Of course, we start with the entry section (that's how it got its name after all). 156 // Of course, we start with the entry section (that's how it got its name after all).
157 var resolve = new ResolveReferencesCommand(this.Messaging, find.EntrySection, find.Symbols); 157 var resolve = new ResolveReferencesCommand(this.Messaging, find.EntrySection, find.TuplesByName);
158 158
159 resolve.Execute(); 159 resolve.Execute();
160 160
@@ -190,16 +190,16 @@ namespace WixToolset.Core
190 } 190 }
191 191
192 // Display an error message for Components that were not referenced by a Feature. 192 // Display an error message for Components that were not referenced by a Feature.
193 foreach (var symbol in resolve.ReferencedSymbols.Where(s => s.Row.Definition.Type == TupleDefinitionType.Component)) 193 foreach (var tupleWithSection in resolve.ReferencedTupleWithSections.Where(s => s.Tuple.Definition.Type == TupleDefinitionType.Component))
194 { 194 {
195 if (!referencedComponents.Contains(symbol.Name)) 195 if (!referencedComponents.Contains(tupleWithSection.Name))
196 { 196 {
197 this.Messaging.Write(ErrorMessages.OrphanedComponent(symbol.Row.SourceLineNumbers, symbol.Row.Id.Id)); 197 this.Messaging.Write(ErrorMessages.OrphanedComponent(tupleWithSection.Tuple.SourceLineNumbers, tupleWithSection.Tuple.Id.Id));
198 } 198 }
199 } 199 }
200 200
201 // Report duplicates that would ultimately end up being primary key collisions. 201 // Report duplicates that would ultimately end up being primary key collisions.
202 var reportDupes = new ReportConflictingSymbolsCommand(this.Messaging, find.PossiblyConflictingSymbols, resolve.ResolvedSections); 202 var reportDupes = new ReportConflictingTuplesCommand(this.Messaging, find.PossibleConflicts, resolve.ResolvedSections);
203 reportDupes.Execute(); 203 reportDupes.Execute();
204 204
205 if (this.Messaging.EncounteredError) 205 if (this.Messaging.EncounteredError)
@@ -208,7 +208,7 @@ namespace WixToolset.Core
208 } 208 }
209 209
210 // resolve the feature to feature connects 210 // resolve the feature to feature connects
211 this.ResolveFeatureToFeatureConnects(featuresToFeatures, find.Symbols); 211 this.ResolveFeatureToFeatureConnects(featuresToFeatures, find.TuplesByName);
212 212
213 // Create the section to hold the linked content. 213 // Create the section to hold the linked content.
214 var resolvedSection = new IntermediateSection(find.EntrySection.Id, find.EntrySection.Type, find.EntrySection.Codepage); 214 var resolvedSection = new IntermediateSection(find.EntrySection.Id, find.EntrySection.Type, find.EntrySection.Codepage);
@@ -734,17 +734,17 @@ namespace WixToolset.Core
734 /// <summary> 734 /// <summary>
735 /// Load the standard action symbols. 735 /// Load the standard action symbols.
736 /// </summary> 736 /// </summary>
737 /// <param name="symbols">Collection of symbols.</param> 737 /// <param name="tuplesByName">Collection of symbols.</param>
738 private void LoadStandardActionSymbols(IntermediateSection section, IDictionary<string, Symbol> symbols) 738 private void LoadStandardActions(IntermediateSection section, IDictionary<string, TupleWithSection> tuplesByName)
739 { 739 {
740 foreach (var actionRow in WindowsInstallerStandard.StandardActions()) 740 foreach (var actionTuple in WindowsInstallerStandard.StandardActions())
741 { 741 {
742 var symbol = new Symbol(section, actionRow); 742 var tupleWithSection = new TupleWithSection(section, actionTuple);
743 743
744 // If the action's symbol has not already been defined (i.e. overriden by the user), add it now. 744 // If the action's tuple has not already been defined (i.e. overriden by the user), add it now.
745 if (!symbols.ContainsKey(symbol.Name)) 745 if (!tuplesByName.ContainsKey(tupleWithSection.Name))
746 { 746 {
747 symbols.Add(symbol.Name, symbol); 747 tuplesByName.Add(tupleWithSection.Name, tupleWithSection);
748 } 748 }
749 } 749 }
750 } 750 }
@@ -1242,7 +1242,7 @@ namespace WixToolset.Core
1242 /// </summary> 1242 /// </summary>
1243 /// <param name="featuresToFeatures">Feature to feature complex references.</param> 1243 /// <param name="featuresToFeatures">Feature to feature complex references.</param>
1244 /// <param name="allSymbols">All symbols loaded from the sections.</param> 1244 /// <param name="allSymbols">All symbols loaded from the sections.</param>
1245 private void ResolveFeatureToFeatureConnects(ConnectToFeatureCollection featuresToFeatures, IDictionary<string, Symbol> allSymbols) 1245 private void ResolveFeatureToFeatureConnects(ConnectToFeatureCollection featuresToFeatures, IDictionary<string, TupleWithSection> allSymbols)
1246 { 1246 {
1247 foreach (ConnectToFeature connection in featuresToFeatures) 1247 foreach (ConnectToFeature connection in featuresToFeatures)
1248 { 1248 {
@@ -1254,7 +1254,7 @@ namespace WixToolset.Core
1254 1254
1255 if (allSymbols.TryGetValue(wixSimpleReferenceRow.SymbolicName, out var symbol)) 1255 if (allSymbols.TryGetValue(wixSimpleReferenceRow.SymbolicName, out var symbol))
1256 { 1256 {
1257 var featureTuple = (FeatureTuple)symbol.Row; 1257 var featureTuple = (FeatureTuple)symbol.Tuple;
1258 featureTuple.ParentFeatureRef = connection.PrimaryFeature; 1258 featureTuple.ParentFeatureRef = connection.PrimaryFeature;
1259 } 1259 }
1260 } 1260 }