aboutsummaryrefslogtreecommitdiff
path: root/src/api/burn/balutil/balinfo.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'src/api/burn/balutil/balinfo.cpp')
-rw-r--r--src/api/burn/balutil/balinfo.cpp11
1 files changed, 5 insertions, 6 deletions
diff --git a/src/api/burn/balutil/balinfo.cpp b/src/api/burn/balutil/balinfo.cpp
index 751ba4f1..6f609a40 100644
--- a/src/api/burn/balutil/balinfo.cpp
+++ b/src/api/burn/balutil/balinfo.cpp
@@ -223,7 +223,6 @@ LExit:
223DAPI_(HRESULT) BalInfoAddUpdateBundleAsPackage( 223DAPI_(HRESULT) BalInfoAddUpdateBundleAsPackage(
224 __in BAL_INFO_PACKAGES* pPackages, 224 __in BAL_INFO_PACKAGES* pPackages,
225 __in_z LPCWSTR wzId, 225 __in_z LPCWSTR wzId,
226 __in_z LPCWSTR /*wzPreviousId*/,
227 __out_opt BAL_INFO_PACKAGE** ppPackage 226 __out_opt BAL_INFO_PACKAGE** ppPackage
228 ) 227 )
229{ 228{
@@ -356,7 +355,7 @@ DAPI_(HRESULT) BalSetOverridableVariablesFromEngine(
356 LPCWSTR wzVariableValue = pCommand->rgVariableValues[i]; 355 LPCWSTR wzVariableValue = pCommand->rgVariableValues[i];
357 356
358 hr = DictGetValue(pOverridableVariables->sdVariables, wzVariableName, reinterpret_cast<void**>(&pOverridableVariable)); 357 hr = DictGetValue(pOverridableVariables->sdVariables, wzVariableName, reinterpret_cast<void**>(&pOverridableVariable));
359 if (E_NOTFOUND == hr) 358 if (E_NOTFOUND == hr || E_INVALIDARG == hr)
360 { 359 {
361 BalLog(BOOTSTRAPPER_LOG_LEVEL_ERROR, "Ignoring attempt to set non-overridable variable: '%ls'.", wzVariableName); 360 BalLog(BOOTSTRAPPER_LOG_LEVEL_ERROR, "Ignoring attempt to set non-overridable variable: '%ls'.", wzVariableName);
362 hr = S_OK; 361 hr = S_OK;
@@ -549,16 +548,16 @@ static HRESULT ParseBalPackageInfoFromXml(
549 } 548 }
550 ExitOnFailure(hr, "Failed to parse all WixBalPackageInfo elements."); 549 ExitOnFailure(hr, "Failed to parse all WixBalPackageInfo elements.");
551 550
552 hr = XmlSelectNodes(pixdManifest, L"/BootstrapperApplicationData/WixMbaPrereqInformation", &pNodeList); 551 hr = XmlSelectNodes(pixdManifest, L"/BootstrapperApplicationData/WixPrereqInformation", &pNodeList);
553 ExitOnFailure(hr, "Failed to select all packages."); 552 ExitOnFailure(hr, "Failed to select all packages.");
554 553
555 while (S_OK == (hr = XmlNextElement(pNodeList, &pNode, NULL))) 554 while (S_OK == (hr = XmlNextElement(pNodeList, &pNode, NULL)))
556 { 555 {
557 hr = XmlGetAttributeEx(pNode, L"PackageId", &scz); 556 hr = XmlGetAttributeEx(pNode, L"PackageId", &scz);
558 ExitOnRequiredXmlQueryFailure(hr, "Failed to get package identifier for WixMbaPrereqInformation."); 557 ExitOnRequiredXmlQueryFailure(hr, "Failed to get package identifier for WixPrereqInformation.");
559 558
560 hr = BalInfoFindPackageById(pPackages, scz, &pPackage); 559 hr = BalInfoFindPackageById(pPackages, scz, &pPackage);
561 ExitOnFailure(hr, "Failed to find package specified in WixMbaPrereqInformation: %ls", scz); 560 ExitOnFailure(hr, "Failed to find package specified in WixPrereqInformation: %ls", scz);
562 561
563 pPackage->fPrereqPackage = TRUE; 562 pPackage->fPrereqPackage = TRUE;
564 563
@@ -570,7 +569,7 @@ static HRESULT ParseBalPackageInfoFromXml(
570 569
571 ReleaseNullObject(pNode); 570 ReleaseNullObject(pNode);
572 } 571 }
573 ExitOnFailure(hr, "Failed to parse all WixMbaPrereqInformation elements."); 572 ExitOnFailure(hr, "Failed to parse all WixPrereqInformation elements.");
574 573
575 if (S_FALSE == hr) 574 if (S_FALSE == hr)
576 { 575 {