aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* WiX Toolset v4.0.5v4.0.5Rob Mensching2024-03-221-1/+1
|
* Work around lack of upper-bound limit on extension versionsRob Mensching2024-03-222-7/+7
| | | | See issue 8033 for more details
* Protect elevated working folder from malicious dataRob Mensching2024-03-227-37/+49
| | | | | | | | | | | | | | | When running elevated, Burn uses the Windows Temp folder as its working folder to prevent normal processes from tampering with the files. Windows Temp does allow non-elevated processes to write to the folder but they cannot see the files there. Unfortunately, contrary to our belief, non-elevated processes can read the files in Windows Temp by watching for directory changes. This allows a malicious process to lie in wait, watching the Windows Temp folder until a Burn process is launched elevated, then attack the working folder. Mitigate that attack by protecting the working folder to only elevated users. Managed custom actions also fall back to using the Windows Temp folder in some cases and thus can be exposed in a similar fashion as an elevated Burn process. Remove that possibility.
* Don't follow junctions when recursing directories.Rob Mensching2024-03-222-3/+13
| | | | | | | | | | | | | | When deleting directories recursively, an elevated custom action following junctions in a user-writable location could recurse into any directory, including some that you might not want to be deleted. Therefore, avoid recursing into directories that are actually junctions (aka "reparse points"). This applies to: - The RemoveFoldersEx custom action (which doesn't actually do deletions but would instruct elevated MSI to delete on your behalf). - DTF's custom action runner.
* Start WiX Toolset v4.0.5Rob Mensching2024-03-221-1/+1
|
* WiX Toolset v4.0.4v4.0.4Rob Mensching2024-02-062-5/+2
|
* Do not follow junctions when recursively deleting directoriesRob Mensching2024-02-061-4/+4
| | | | | | This will prevent elevated processes from accidentally following a junction from a user-writable directory to a per-machine directory and erroneously deleting the per-machine contents.
* Mitigate .local DLL redirection Windows bug.Bob Arnson2024-02-063-0/+28
|
* Fix crash when CloseApplications_X64 closes Electron appAndrzej Wojtas2024-02-061-1/+1
|
* Clean up TouchFile.Bob Arnson2024-02-062-6/+6
|
* Normalize signing command-lineRob Mensching2024-02-061-9/+8
|
* Build tweaks to support VS 17.8...Bob Arnson2024-01-286-4/+19
| | | | | | | ...because SemVer is just a suggestion. - Also fix missing NuGet cleanup. - And update NuGet^2 packages because v6.3.1 has vulnerabilities.
* Start WiX Toolset v4.0.4Rob Mensching2024-01-282-4/+4
|
* WiX Toolset v4.0.3v4.0.3Rob Mensching2023-11-131-1/+1
|
* Return intermediate even if compiler encounters errorRob Mensching2023-11-131-1/+1
| | | | Fixes 7854
* Include build permission to push to GitHub PackagesRob Mensching2023-11-071-0/+1
|
* Include duplicated inline directory symbols referenced in subsequent sectionsRob Mensching2023-11-077-52/+108
| | | | | | | | | Due to the handling of redundant symbols, which are only used by inline directory syntax, the symbols were only defined in the first section encountered by the linker. Fix that so at most one duplicated inline directory symbol is included when referenced. Fixes 7840
* Fix duplication of AdditionalOptions being added to command-lineRob Mensching2023-11-075-9/+0
| | | | Fixes 7837
* Correctly handle top-level AppId elementRob Mensching2023-11-075-35/+97
| | | | Fixes 7738
* Avoid use of Encoding.WindowsCodePageRob Mensching2023-11-074-4/+62
| | | | Fixes 7612
* Start WiX Toolset v4.0.3Rob Mensching2023-11-072-6/+4
|
* WiX Toolset v4.0.2v4.0.2Rob Mensching2023-09-121-1/+1
|
* Update to latest signing infrastructureRob Mensching2023-09-125-48/+37
| | | | Fixes 7546
* Correctly process build -outputType switchRob Mensching2023-09-0513-13/+73
| | | | | | Also add a few additional output types to built-in backends. Fixes 7708
* Properly fragment NetFx custom actions.Bob Arnson2023-08-152-22/+11
| | | | FIxes https://github.com/wixtoolset/issues/issues/7677.
* Fix the use of ModuleSubstitution tableRob Mensching2023-08-086-3/+93
| | | | | | | | | Addresses two issues in the creation of configurable merge modules. First, the ModuleConfiguration table Id should not be modularized. Second, the ModuleSubstitution table was never created. Fixing both of those allows configurable merge modules to work again. Fixes 7559
* Ensure the Font actions are scheduled for TrueType fontsRob Mensching2023-08-073-5/+13
| | | | | | | | TrueType fonts are denoted by the empty string in the FontTitle field of the FileSymbol. That means a non-null FontTitle field value means a font is being installed. Fixes 7593
* Remove legacy permissions support.Bob Arnson2023-08-072-49/+4
| | | | | | | | | | In the long ago, a share could have one user/permissions pair. That's really limited, of course, so support for _n_ user/permissions pairs was added. In the move to WiX v4, support for that single, legacy user was removed from the extension side but not the custom action side. Remove that support. Fixes https://github.com/wixtoolset/issues/issues/7632.
* fix stack corruption around cbdata when adding a machine certificatechris_bednarski2023-08-071-3/+3
|
* Partial fix for the weirdly broken...Bob Arnson2023-07-135-7/+82
| | | | | | IWindowsInstallerDecompileContext.TreatProductAsModule. https://github.com/wixtoolset/issues/issues/7607
* Extract object fields with modularization GUIDs.Bob Arnson2023-06-304-4/+30
|
* Handle MergeModule.CABinet for extraction.Bob Arnson2023-06-213-16/+36
| | | | Fixes https://github.com/wixtoolset/issues/issues/7568,
* Start WiX Toolset v4.0.2.Bob Arnson2023-06-212-2/+4
|
* WiX Toolset v4.0.1v4.0.1Rob Mensching2023-06-041-1/+1
|
* ProjectReferences to wixlibs should participate in DefineConstants creationRob Mensching2023-06-032-3/+6
| | | | | | Also fix documentation in ResolveWixLibraryReferences target. Fixes 7512
* Downgrade bad ProductVersion error to warning.Bob Arnson2023-06-038-27/+85
| | | | Fixes https://github.com/wixtoolset/issues/issues/7522.
* Obsolete removed PackageState.Cached valueRob Mensching2023-06-032-6/+7
| | | | | | | | A package's cached status is no longer set via the PackageState. The value was removed in native code but the managed code was missed throwing off the enum mapping. Fixes 7399
* Update CLA signatures locationRob Mensching2023-06-031-4/+4
|
* Fix duplicate keys from inline subdirectories.Bob Arnson2023-06-033-11/+36
| | | | Fixes https://github.com/wixtoolset/issues/issues/7459.
* Skip processing missing FeatureComponents table.Bob Arnson2023-06-038-1/+55
| | | | Fixes https://github.com/wixtoolset/issues/issues/7472.
* Fix Dialog table decompilation.Bob Arnson2023-06-033-1/+5
| | | | | | | Fix duplicate NoMinimize attribute and add attributes that were entirely missing. Fixes https://github.com/wixtoolset/issues/issues/7482.
* Show correct error message when upgrade is blockedtimberto2023-06-033-3/+39
|
* Fix Msmq key table relationship.Bob Arnson2023-06-031-1/+1
| | | | Fixes https://github.com/wixtoolset/issues/issues/7454.
* Fix build failure when bundle has multiple RemoteBundle elementsNir Bar2023-06-035-2/+49
|
* Fix XmlConfig decompile to produce schema element, Add unitest for XmlDecomilefyodorkor2023-06-032-9/+34
|
* Tame some wild pointers.Bob Arnson2023-06-032-5/+16
| | | | | | Maybe Rust wouldn't be so bad... Fixes https://github.com/wixtoolset/issues/issues/7451.
* Fix XmlConfig lookup logic.Bob Arnson2023-06-038-16/+134
| | | | | Fixes https://github.com/wixtoolset/issues/issues/7377. Requires fix for https://github.com/wixtoolset/issues/issues/7444.
* Fix WcaErrorMessage `cArgs==-1` case.Bob Arnson2023-06-034-17/+26
| | | | | | | | | | - Count args before creating message record. - Document terminating NULL requirement. - Add terminating NULL in MessageExit* macros. - Enhance tests for problems encountered fixing this nightmare. Fixes https://github.com/wixtoolset/issues/issues/7422. Fixes https://github.com/wixtoolset/issues/issues/7444.
* Remove InstallDirDlg reference from WixUI_MondoBob Arnson2023-06-032-2/+0
| | | | Fixes https://github.com/wixtoolset/issues/issues/7436.
* Fix merged ProductCode from mergemod.cub and...Bob Arnson2023-06-037-54/+86
| | | | | | ...work around other bugs in mergemod.cub. Fixes https://github.com/wixtoolset/issues/issues/7413.